From 1075cccb4ff7314e6cef6b72ffadb65d3389641c Mon Sep 17 00:00:00 2001 From: Brian Crissup Date: Fri, 21 Mar 2025 10:22:16 -0400 Subject: [PATCH] fix(snapshot) skip subscription filters for IA log groups --- .../src/snapshot/lib/aws-cloudwatch.ts | 27 ++++++++++--------- 1 file changed, 15 insertions(+), 12 deletions(-) diff --git a/reference-artifacts/Custom-Scripts/lza-upgrade/src/snapshot/lib/aws-cloudwatch.ts b/reference-artifacts/Custom-Scripts/lza-upgrade/src/snapshot/lib/aws-cloudwatch.ts index 3c49612ea..a328a70b8 100644 --- a/reference-artifacts/Custom-Scripts/lza-upgrade/src/snapshot/lib/aws-cloudwatch.ts +++ b/reference-artifacts/Custom-Scripts/lza-upgrade/src/snapshot/lib/aws-cloudwatch.ts @@ -20,6 +20,7 @@ import { LogGroup, MetricFilter, SubscriptionFilter, + LogGroupClass, } from '@aws-sdk/client-cloudwatch-logs'; import { AwsCredentialIdentity } from '@aws-sdk/types'; @@ -170,19 +171,21 @@ export async function snapshotCloudWatchLogResources( }); } + if (logGroup.logGroupClass && logGroup.logGroupClass !== LogGroupClass.INFREQUENT_ACCESS) { //get subscription filters - const subscriptionFilterResults = await describeSubscriptionFilters( - logGroup.logGroupName!, - region, - credentials, - ); - await snapshotTable.writeResource({ - accountId: accountId, - region: region, - resourceName: `subscription-filters-${logGroup.logGroupName!}`, - preMigration: preMigration, - data: subscriptionFilterResults, - }); + const subscriptionFilterResults = await describeSubscriptionFilters( + logGroup.logGroupName!, + region, + credentials, + ); + await snapshotTable.writeResource({ + accountId: accountId, + region: region, + resourceName: `subscription-filters-${logGroup.logGroupName!}`, + preMigration: preMigration, + data: subscriptionFilterResults, + }); + } } } } while (nextToken);