Skip to content

Commit 574f83e

Browse files
hsohail94Sohail-Haaris-bah
authored andcommitted
fix!: Fixing case and Name parameter value for AMI's Distribution Configuration
fix!: Fix casing and Name parameter value for AMI's Distribution Configuration#
1 parent f607be5 commit 574f83e

File tree

4 files changed

+109
-99
lines changed

4 files changed

+109
-99
lines changed

package-lock.json

Lines changed: 8 additions & 8 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/index.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -242,9 +242,11 @@ export class ImagePipeline extends Construct {
242242
const distributionConfig: any = {
243243
region: distributionRegion,
244244
amiDistributionConfiguration: {
245-
name: `${props.imageRecipe}-${distributionRegion}`,
246-
description: `copy AMI ${props.imageRecipe} to ${distributionRegion}`,
247-
targetAccountIds: props.distributionAccountIDs,
245+
//Capital case here because it's an object of type any, but capital case is what is expected in CloudFormation
246+
//https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-imagebuilder-distributionconfiguration-amidistributionconfiguration.html
247+
Name: `${props.imageRecipe}-${distributionRegion}-{{imagebuilder:buildDate}}`,
248+
Description: `copy AMI ${props.imageRecipe} to ${distributionRegion}`,
249+
TargetAccountIds: props.distributionAccountIDs,
248250
},
249251
};
250252
distributionsList.push(distributionConfig);

test/imagepipeline.test.ts

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,8 +56,8 @@ const propsWithVolumeConfig: ImagePipelineProps = {
5656
throughput: 1000,
5757
},
5858
enableCrossAccountDistribution: true,
59-
distributionAccountIDs: ['111222333444', '222444666888'],
60-
distributionRegions: ['us-east-1', 'us-west-2'],
59+
distributionAccountIDs: ['111222333444'],
60+
distributionRegions: ['us-east-1'],
6161
};
6262

6363
beforeAll(() => {
@@ -163,6 +163,14 @@ test('Infrastructure Configuration is built with provided EBS volume properties'
163163
templateWithVolume.hasResourceProperties('AWS::ImageBuilder::DistributionConfiguration', {
164164
Name: 'TestImageRecipe-distribution-config',
165165
Description: 'Cross account distribution settings for TestImageRecipe',
166+
Distributions: [{
167+
Region: 'us-east-1',
168+
AmiDistributionConfiguration: {
169+
Name: 'TestImageRecipe-us-east-1-{{imagebuilder:buildDate}}',
170+
Description: 'copy AMI TestImageRecipe to us-east-1',
171+
TargetAccountIds: ['111222333444'],
172+
},
173+
}],
166174
});
167175
});
168176

0 commit comments

Comments
 (0)