move lambda creation to external template

Author: mwunderl

.ebextensions/lambda-function.config

@@ -1,19 +1,3 @@
-Resources:
-  RandomNameFunction:
-    Type: "AWS::Lambda::Function"
-    Properties:
-      Code:
-        ZipFile: "PLACEHOLDER"
-      Description: "Generate random names"
-      Environment:
-        Variables:
-          REGION_NAME: {"Ref" : "AWS::Region"}
-          TOPIC_ARN: {"Ref" : "NotificationTopic"}
-      FunctionName: random-name
-      Handler: index.handler
-      Role: { "Fn::Join": [ "", [ "arn:aws:iam::",{"Ref" : "AWS::AccountId"},":role/service-role/scorekeep-lambda" ] ] }
-      Runtime: nodejs4.3
-
 commands:
   install-npm:
     command: sudo -u ec2-user /tmp/install-npm.sh
@@ -48,7 +32,9 @@ files:
       #!/bin/bash
       REGION=$(/opt/elasticbeanstalk/bin/get-config environment -k AWS_REGION)
       STAGINGDIR=$(/opt/elasticbeanstalk/bin/get-config container -k container_staging_dir)
+      TOPIC=$(/opt/elasticbeanstalk/bin/get-config environment -k NOTIFICATION_TOPIC))
       cd _lambda/random-name
       /home/ec2-user/bin/npm install
       zip -r ../random-name.zip *
       aws lambda update-function-code --function-name random-name --zip-file fileb://../random-name.zip --region $REGION
+      aws lambda update-function-configuration --function-name random-name --environment "{\"Variables\": {\"NOTIFICATION_TOPIC\": \"$TOPIC\"} }"

_lambda/lambda-role.yml

@@ -20,3 +20,18 @@ Resources:
         - arn:aws:iam::aws:policy/service-role/AWSLambdaBasicExecutionRole
       Path: /service-role/
       RoleName: scorekeep-lambda
+
+  RandomNameFunction:
+    Type: "AWS::Lambda::Function"
+    Properties:
+      Code:
+        ZipFile: "PLACEHOLDER"
+      Description: "Generate random names"
+      Environment:
+        Variables:
+          REGION_NAME: {"Ref" : "AWS::Region"}
+          TOPIC_ARN: "PLACEHOLDER"
+      FunctionName: random-name
+      Handler: index.handler
+      Role: { "Fn::Join": [ "", [ "arn:aws:iam::",{"Ref" : "AWS::AccountId"},":role/service-role/scorekeep-lambda" ] ] }
+      Runtime: nodejs4.3

_lambda/random-name/index.js

@@ -1,7 +1,7 @@
 var AWSXRay = require('aws-xray-sdk-core');
 var AWS = AWSXRay.captureAWS(require('aws-sdk'));
 
-AWS.config.update({region: process.env.REGION});
+AWS.config.update({region: process.env.AWS_REGION});
 var Chance = require('chance');
 
 var myFunction = function(event, context, callback) {