Skip to content

Commit 49d263d

Browse files
committed
remove load balancer and add outputs
1 parent d91d628 commit 49d263d

File tree

2 files changed

+18
-16
lines changed

2 files changed

+18
-16
lines changed

cloudformation/Makefile

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,11 @@ check: check-region
1616

1717
outputs: check-region
1818
@aws --region $(AWS_REGION) cloudformation describe-stacks --stack-name scorekeep --query 'Stacks[0].Outputs[?OutputKey==`PubPrivateVPCID`].OutputValue' --output text
19+
@aws --region $(AWS_REGION) cloudformation describe-stacks --stack-name scorekeep --query 'Stacks[0].Outputs[?OutputKey==`SecurityGroupID`].OutputValue' --output text
1920
@aws --region $(AWS_REGION) cloudformation describe-stacks --stack-name scorekeep --query 'Stacks[0].Outputs[?OutputKey==`PrivateSubnet1ID`].OutputValue' --output text
2021
@aws --region $(AWS_REGION) cloudformation describe-stacks --stack-name scorekeep --query 'Stacks[0].Outputs[?OutputKey==`PrivateSubnet2ID`].OutputValue' --output text
22+
@aws --region $(AWS_REGION) cloudformation describe-stacks --stack-name scorekeep --query 'Stacks[0].Outputs[?OutputKey==`PublicSubnet1ID`].OutputValue' --output text
23+
@aws --region $(AWS_REGION) cloudformation describe-stacks --stack-name scorekeep --query 'Stacks[0].Outputs[?OutputKey==`PublicSubnet2ID`].OutputValue' --output text
2124

2225
clean: check-region
2326
aws --region $(AWS_REGION) cloudformation delete-stack --stack-name scorekeep

cloudformation/cf-resources.yaml

Lines changed: 15 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -276,22 +276,6 @@ Resources:
276276
ToPort: '8080'
277277
SourceSecurityGroupId: !Ref ScorekeepLbSecurityGroup
278278
DependsOn: ScorekeepLbSecurityGroup
279-
ScorekeepLoadBalancer:
280-
Type: "AWS::ElasticLoadBalancingV2::LoadBalancer"
281-
Properties:
282-
Name: "scorekeep-lb"
283-
Scheme: "internet-facing"
284-
SecurityGroups:
285-
- !Ref ScorekeepLbSecurityGroup
286-
Subnets:
287-
- !Ref PublicSubnet1
288-
- !Ref PublicSubnet2
289-
Tags:
290-
- Key: Name
291-
Value: !Join [_, [!Ref 'AWS::StackName']]
292-
Type: "application"
293-
IpAddressType: "ipv4"
294-
DependsOn: ScorekeepLbSecurityGroup
295279
Outputs:
296280
PubPrivateVPCID:
297281
Description: VPC ID
@@ -308,3 +292,18 @@ Outputs:
308292
Value: !Ref "PrivateSubnet2"
309293
Export:
310294
Name: ScorekeepPrivateSubnet2ID
295+
PublicSubnet1ID:
296+
Description: Public Subnet A ID
297+
Value: !Ref "PublicSubnet1"
298+
Export:
299+
Name: ScorekeepPublicSubnet1ID
300+
PublicSubnet2ID:
301+
Description: Public Subnet B ID
302+
Value: !Ref "PublicSubnet2"
303+
Export:
304+
Name: ScorekeepPublicSubnet2ID
305+
SecurityGroupID:
306+
Description: Security Group ID
307+
Value: !Ref "ScorekeepLbSecurityGroup"
308+
Export:
309+
Name: ScorekeepSecurityGroup2ID

0 commit comments

Comments
 (0)