make class models, factories, controllers final

Author: mwunderl

src/main/java/scorekeep/GameController.java

@@ -28,11 +28,11 @@
     Use GameModel to persist updated Game objects to DynamoDB
 **/
 public class GameController {
-  private SecureRandom random = new SecureRandom();
-  private GameFactory gameFactory = new GameFactory();
-  private RulesFactory rulesFactory = new RulesFactory();
-  private StateFactory stateFactory = new StateFactory();
-  private GameModel model = new GameModel();
+  private final SecureRandom random = new SecureRandom();
+  private final GameFactory gameFactory = new GameFactory();
+  private final RulesFactory rulesFactory = new RulesFactory();
+  private final StateFactory stateFactory = new StateFactory();
+  private final GameModel model = new GameModel();
   private final Logger logger = LoggerFactory.getLogger(this.getClass());
   /* GET /game/SESSION/ */
   @RequestMapping(method=RequestMethod.GET)

src/main/java/scorekeep/GameFactory.java

@@ -5,10 +5,10 @@
 import java.lang.Exception;
 
 public class GameFactory {
-  private SecureRandom random = new SecureRandom();
+  private final SecureRandom random = new SecureRandom();
   private final HashMap<String, Game> allGames = new HashMap<String, Game>(1);
-  private GameModel model = new GameModel();
-  private SessionController sessionController = new SessionController();
+  private final GameModel model = new GameModel();
+  private final SessionController sessionController = new SessionController();
 
   public GameFactory(){
   }

src/main/java/scorekeep/MoveController.java

@@ -20,9 +20,9 @@
 @RestController
 @RequestMapping(value="/api/move/{sessionId}/{gameId}")
 public class MoveController {
-  private MoveFactory moveFactory = new MoveFactory();
-  private MoveModel model = new MoveModel();
-  private GameController gameController = new GameController();
+  private final MoveFactory moveFactory = new MoveFactory();
+  private final MoveModel model = new MoveModel();
+  private final GameController gameController = new GameController();
   /* GET /move/SESSION/GAME */
   @RequestMapping(method=RequestMethod.GET)
   public List<Move> getMoves(@PathVariable String sessionId, @PathVariable String gameId) throws SessionNotFoundException, GameNotFoundException {

src/main/java/scorekeep/MoveFactory.java

@@ -13,13 +13,13 @@
 
 public class MoveFactory {
   private static final Logger logger = LoggerFactory.getLogger(MoveFactory.class);
-  private SecureRandom random = new SecureRandom();
+  private final SecureRandom random = new SecureRandom();
   private final HashMap<String, Move> allMoves = new HashMap<String, Move>(1);
-  private MoveModel moveModel = new MoveModel();
-  private StateModel stateModel = new StateModel();
-  private GameController gameController = new GameController();
-  private StateController stateController = new StateController();
-  private RulesFactory rulesFactory = new RulesFactory(); 
+  private final MoveModel moveModel = new MoveModel();
+  private final StateModel stateModel = new StateModel();
+  private final GameController gameController = new GameController();
+  private final StateController stateController = new StateController();
+  private final RulesFactory rulesFactory = new RulesFactory(); 
 
   public MoveFactory(){
   }

src/main/java/scorekeep/MoveModel.java

@@ -17,8 +17,8 @@ public class MoveModel {
         .withRegion(Regions.fromName(System.getenv("AWS_REGION")))
         .build();
   private DynamoDBMapper mapper = new DynamoDBMapper(client);
-  private SessionModel sessionModel = new SessionModel();
-  private GameModel gameModel = new GameModel();
+  private final SessionModel sessionModel = new SessionModel();
+  private final GameModel gameModel = new GameModel();
 
   public void saveMove(Move move) throws SessionNotFoundException, GameNotFoundException {
     // check session

src/main/java/scorekeep/RulesController.java

@@ -15,8 +15,8 @@
 @RestController
 @RequestMapping(value="/api/rules")
 public class RulesController {
-  private SecureRandom random = new SecureRandom();
-  private RulesFactory rulesFactory = new RulesFactory();
+  private final SecureRandom random = new SecureRandom();
+  private final RulesFactory rulesFactory = new RulesFactory();
 
   /* GET /rules */
   @RequestMapping(method=RequestMethod.GET)

src/main/java/scorekeep/RulesFactory.java

@@ -4,7 +4,7 @@
 import java.math.BigInteger;
 
 public class RulesFactory {
-  private SecureRandom random = new SecureRandom();
+  private final SecureRandom random = new SecureRandom();
   private final HashMap<String, Rules> allRules = new HashMap<String, Rules>(1);
 
   public RulesFactory(){

src/main/java/scorekeep/SessionController.java

@@ -18,9 +18,9 @@
 @RestController
 @RequestMapping(value="/api/session")
 public class SessionController {
-  private SecureRandom random = new SecureRandom();
-  private SessionFactory sessionFactory = new SessionFactory();
-  private SessionModel model = new SessionModel();
+  private final SecureRandom random = new SecureRandom();
+  private final SessionFactory sessionFactory = new SessionFactory();
+  private final SessionModel model = new SessionModel();
 
   /* POST /session */
   @RequestMapping(method=RequestMethod.POST)

src/main/java/scorekeep/SessionFactory.java

@@ -5,8 +5,8 @@
 import java.lang.Exception;
 
 public class SessionFactory {
-  private SecureRandom random = new SecureRandom();
-  private SessionModel model = new SessionModel();
+  private final SecureRandom random = new SecureRandom();
+  private final SessionModel model = new SessionModel();
 
   public SessionFactory(){
   }

src/main/java/scorekeep/StateController.java

@@ -20,10 +20,10 @@
 @RestController
 @RequestMapping(value="/api/state/{sessionId}/{gameId}")
 public class StateController {
-  private SecureRandom random = new SecureRandom();
-  private StateFactory stateFactory = new StateFactory();
-  private StateModel model = new StateModel();
-  private GameController gameController = new GameController();
+  private final SecureRandom random = new SecureRandom();
+  private final StateFactory stateFactory = new StateFactory();
+  private final StateModel model = new StateModel();
+  private final GameController gameController = new GameController();
 
   /* GET /state/SESSION/GAME */
   @RequestMapping(method=RequestMethod.GET)