Skip to content

Commit ab58537

Browse files
author
Michael Wunderlich
committed
Merge branch 'master' into xray-gettingstarted
2 parents 8d3b0fc + 402359e commit ab58537

File tree

4 files changed

+19
-7
lines changed

4 files changed

+19
-7
lines changed

public/app/gameController.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,5 +72,8 @@ function Game($q, $scope, $http, $interval, $routeParams, SessionService, UserSe
7272

7373
});
7474
}
75-
75+
$scope.$on('$destroy',function(){
76+
if($scope.interval)
77+
$interval.cancel($scope.interval);
78+
});
7679
}

public/app/sessionController.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@ function Session($scope, $http, $location, $interval, $routeParams, SessionServi
4141
$scope.interval = $interval(function(){
4242
$scope.loadSession();
4343
}, 5000);
44-
4544
$scope.createGame = function (gamename, gamerules) {
4645
var sessionid = $routeParams.sessionid;
4746

@@ -95,4 +94,8 @@ function Session($scope, $http, $location, $interval, $routeParams, SessionServi
9594
$location.path('/');
9695
});
9796
};
97+
$scope.$on('$destroy',function(){
98+
if($scope.interval)
99+
$interval.cancel($scope.interval);
100+
});
98101
}

public/css/scorekeep.css

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,12 @@ body {
1212
text-align: center;
1313
}
1414

15+
a, a:active, a:focus, a:hover {
16+
color: #000;
17+
outline: none;
18+
text-decoration: none;
19+
}
20+
1521
/* Extra markup and styles for table-esque vertical and horizontal centering */
1622
.site-wrapper {
1723
display: table;
@@ -241,4 +247,4 @@ input {
241247
}
242248
.square:active {
243249
background-color: #85144b;
244-
}
250+
}

public/index.html

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,9 @@
1818
<script src="app/sessionCollection.js"></script>
1919
<script src="app/gameCollection.js"></script>
2020
<script src="app/mainController.js"></script>
21-
<link rel="stylesheet" href="css/scorekeep.css"></link>
22-
<link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/bootstrap/4.0.0-alpha.5/css/bootstrap.min.css" integrity="sha384-AysaV+vQoT3kOAXZkl02PThvDr8HYKPZhNT5h/CXfBThSRXQ6jW5DO2ekP5ViFdi" crossorigin="anonymous"></link>
23-
<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/tether/1.3.7/css/tether.css"></link>
21+
<link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/bootstrap/4.0.0-alpha.5/css/bootstrap.min.css" integrity="sha384-AysaV+vQoT3kOAXZkl02PThvDr8HYKPZhNT5h/CXfBThSRXQ6jW5DO2ekP5ViFdi" crossorigin="anonymous"/>
22+
<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/tether/1.3.7/css/tether.css"/>
23+
<link rel="stylesheet" href="css/scorekeep.css"/>
2424
<script src="https://cdnjs.cloudflare.com/ajax/libs/tether/1.3.7/js/tether.js"></script>
2525
<script src="https://code.jquery.com/jquery-3.1.1.js" integrity="sha256-16cdPddA6VdVInumRGo6IbivbERE8p7CQR3HzTBuELA=" crossorigin="anonymous"></script>
2626
<script src="https://maxcdn.bootstrapcdn.com/bootstrap/4.0.0-alpha.5/js/bootstrap.min.js" integrity="sha384-BLiI7JTZm+JWlgKa0M0kGRpJbF2J8q+qreVrKBC47e3K6BW78kGLrCkeRX6I9RoK" crossorigin="anonymous"></script>
@@ -42,7 +42,7 @@
4242
<div class="cover-container">
4343
<div class="masthead clearfix">
4444
<div class="inner">
45-
<h3 class="masthead-brand">Scorekeep</h3>
45+
<h3 class="masthead-brand"><a href="#/">Scorekeep</a></h3>
4646
<nav class="nav nav-masthead">
4747
<a class="nav-link" href='#/' onclick="showhide('instructions');return false;">Instructions</a>
4848
<a class="nav-link" target="blank" href="https://aws.amazon.com/xray/">Powered by AWS X-Ray</a>

0 commit comments

Comments
 (0)