Update top-level Deployment parameters.sh doco page since SECRET_NAME is Optional, not Mandatory from deploying perspective... #357
gbayfield-em
started this conversation in
General
Replies: 1 comment 1 reply
-
The deployment section here is geared towards new deployments. As new deployments do not currently support CodeCommit, I would argue that the SECRET_NAME is a mandatory parameter required for external repository integration. |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Very simple TEAM deployment doc change since SECRET_NAME is in-effect Optional, not Mandatory from perspective of a deployment configuration. This is important since means we can upgrade to v1.3.0 using current CodeCommit repo first, test & THEN switch to in-house GitHub Repo, as TWO separate tasks. This would not be the case if SECRET_NAME was mandatory, but its impl is as a new CloudFormation Template parameter with a default 'No' value, so from the deployment perspective can be omitted from the parameters.sh config file. Do i need to put this simple doco change in as PR (if agree) ?

Beta Was this translation helpful? Give feedback.
All reactions