Skip to content

Commit 2891b9e

Browse files
author
Hoseong-Seo
committed
Remove 'codecommit' string from data
1 parent 43df480 commit 2891b9e

File tree

3 files changed

+9
-12
lines changed

3 files changed

+9
-12
lines changed

README.md

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ If you are using Cloud9, make sure to use `Amazon Linux 2023` AMI for the EC2 wi
3434
- Make sure you have [AWS CLI 2.14](https://docs.aws.amazon.com/cli/latest/userguide/cli-chap-install.html) or above installed.
3535
- Make sure you have [Docker Engine](https://docs.aws.amazon.com/serverless-application-model/latest/developerguide/install-docker.html) installed.
3636
- Make sure you have the latest version of [AWS CDK CLI](https://docs.aws.amazon.com/cdk/latest/guide/cli.html) installed. Not having the release version of CDK can cause deployment issues.
37-
- Make sure you have the latest version of [git-remote-codecommit](https://docs.aws.amazon.com/codecommit/latest/userguide/setting-up-git-remote-codecommit.html) installed.
3837
- Make sure that you have Node 18 or above.
3938
- Make sure that you have Git installed.
4039

@@ -55,7 +54,7 @@ Note that, ```build-application.sh``` builds docker images of sample SaaS applic
5554

5655
And, ```install.sh``` deploys the following:
5756

58-
- Creates an AWS CodeCommit repo in your AWS account and pushes this reference solution code to the repo
57+
- Creates an AWS S3 bucket in your AWS account and pushes this reference solution code to the bucket
5958
- Cdk stack `controlplane-stack` which provisions
6059
- SaaS Builder Toolkit(SBT) control plane components which allows infrastructure to provision/de-provision a tenant.
6160
- Cdk stack `coreappplane-stack` which provisions
@@ -64,8 +63,6 @@ And, ```install.sh``` deploys the following:
6463
- Shared application infrastructure like Amazon VPC, Amazon API Gateway, and Load balancers.
6564
- Cdk stack `tenant-template-stack`, which provisions
6665
- ECS Cluster and ECS services order, product & user microservices.
67-
- Cdk stack `tenant-update-stack` which provisions
68-
- AWS Code Pipeline to update tenant deployments on any changes to source in CodeCommit repo.
6966

7067
## Steps to Clean-up
7168

server/lib/cdknag/control-plane-nag.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ export class ControlPlaneNag extends Construct {
120120
[
121121
{
122122
id: 'AwsSolutions-IAM4',
123-
reason: 'CDKBucket substitute codecommit',
123+
reason: 'CDK S3 Bucket for Ref',
124124
appliesTo: [
125125
'Policy::arn:<AWS::Partition>:iam::aws:policy/service-role/AWSLambdaBasicExecutionRole'
126126
]
@@ -134,7 +134,7 @@ export class ControlPlaneNag extends Construct {
134134
[
135135
{
136136
id: 'AwsSolutions-L1',
137-
reason: 'CDKBucket substitute codecommit',
137+
reason: 'CDK S3 Bucket for Ref',
138138
}
139139
]
140140
);
@@ -147,7 +147,7 @@ export class ControlPlaneNag extends Construct {
147147
[
148148
{
149149
id: 'AwsSolutions-S1',
150-
reason: 'CDKBucket substitute codecommit',
150+
reason: 'CDK S3 Bucket for Ref',
151151
}
152152
]
153153
);
@@ -159,7 +159,7 @@ export class ControlPlaneNag extends Construct {
159159
[
160160
{
161161
id: 'AwsSolutions-CB4',
162-
reason: 'CDKBucket substitute codecommit',
162+
reason: 'CDK S3 Bucket for Ref',
163163
}
164164
]
165165
);

server/lib/cdknag/core-app-plane-nag.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ export class CoreAppPlaneNag extends Construct {
8383
[
8484
{
8585
id: 'AwsSolutions-IAM4',
86-
reason: 'CDKBucket substitute codecommit',
86+
reason: 'CDK S3 Bucket for Ref',
8787
appliesTo: [
8888
'Policy::arn:<AWS::Partition>:iam::aws:policy/service-role/AWSLambdaBasicExecutionRole'
8989
]
@@ -99,7 +99,7 @@ export class CoreAppPlaneNag extends Construct {
9999
[
100100
{
101101
id: 'AwsSolutions-S1',
102-
reason: 'CDKBucket substitute codecommit',
102+
reason: 'CDK S3 Bucket for Ref',
103103
}
104104
]
105105
);
@@ -110,7 +110,7 @@ export class CoreAppPlaneNag extends Construct {
110110
[
111111
{
112112
id: 'AwsSolutions-CB4',
113-
reason: 'CDKBucket substitute codecommit',
113+
reason: 'CDK S3 Bucket for Ref',
114114
}
115115
]
116116
);
@@ -120,7 +120,7 @@ export class CoreAppPlaneNag extends Construct {
120120
[
121121
{
122122
id: 'AwsSolutions-L1',
123-
reason: 'CDKBucket substitute codecommit',
123+
reason: 'CDK S3 Bucket for Ref',
124124
}
125125
]
126126
);

0 commit comments

Comments
 (0)