Merge branch 'bugfix/FE-linting-fixes' into 'develop'

Bugfix/fe linting fixes

See merge request genaiic-reusable-assets/engagement-artifacts/genaiic-idp-accelerator!375

Author: rstrahan

src/ui/.eslintrc.json

@@ -56,6 +56,8 @@
       {
         "ignore": ["\\.css$"]
       }
-    ]
+    ],
+    "react/require-default-props": "off",
+    "react/default-props-match-prop-types": "off"
   }
 }

src/ui/src/components/common/confidence-alerts-utils.js

@@ -293,13 +293,15 @@ export const getFieldConfidenceInfo = (fieldName, explainabilityInfo, path = [],
         // Handle array indices
         const index = parseInt(pathSegment, 10);
         if (!Number.isNaN(index) && index >= 0 && index < currentExplainabilityData.length) {
-          currentExplainabilityData = currentExplainabilityData[index];  // nosemgrep: javascript.lang.security.audit.prototype-pollution.prototype-pollution-loop.prototype-pollution-loop - Index from controlled array iteration
+          // nosemgrep: javascript.lang.security.audit.prototype-pollution.prototype-pollution-loop
+          currentExplainabilityData = currentExplainabilityData[index];
         } else {
           return { hasConfidenceInfo: false };
         }
       } else {
         // Handle object properties
-        currentExplainabilityData = currentExplainabilityData[pathSegment];  // nosemgrep: javascript.lang.security.audit.prototype-pollution.prototype-pollution-loop.prototype-pollution-loop - Index from controlled array iteration
+        // nosemgrep: javascript.lang.security.audit.prototype-pollution.prototype-pollution-loop
+        currentExplainabilityData = currentExplainabilityData[pathSegment];
       }
     } else {
       return { hasConfidenceInfo: false };

src/ui/src/components/common/debug-utils.js

@@ -29,7 +29,7 @@ export const debugSectionStructure = (section, sectionId = 'Unknown') => {
           );
 
           if (hasConfidenceFields) {
-            console.log(`Found confidence data in Output.${key}:`, value);  // nosemgrep: javascript.lang.security.audit.unsafe-formatstring.unsafe-formatstring - Data from trusted internal source only
+            console.log(`Found confidence data in Output.${key}:`, value); // nosemgrep: javascript.lang.security.audit.unsafe-formatstring.unsafe-formatstring - Data from trusted internal source only
           }
         }
       });

src/ui/src/hooks/use-graphql-api.js

@@ -43,29 +43,32 @@ const useGraphQlApi = ({ initialPeriodsToLoad = DOCUMENT_LIST_SHARDS_PER_DAY * 2
     });
   }, []);
 
-  const getDocumentDetailsFromIds = useCallback(async (objectKeys) => {
-    // prettier-ignore
-    logger.debug('getDocumentDetailsFromIds', objectKeys);
-    const getDocumentPromises = objectKeys.map((objectKey) =>
-      client.graphql({ query: getDocument, variables: { objectKey } }),
-    );
-    const getDocumentResolutions = await Promise.allSettled(getDocumentPromises);
-    const getDocumentRejected = getDocumentResolutions.filter((r) => r.status === 'rejected');
-    if (getDocumentRejected.length) {
-      setErrorMessage('failed to get document details - please try again later');
-      logger.error('get document promises rejected', getDocumentRejected);
-    }
-    const documentValues = getDocumentResolutions
-      .filter((r) => r.status === 'fulfilled')
-      .map((r) => r.value?.data?.getDocument);
+  const getDocumentDetailsFromIds = useCallback(
+    async (objectKeys) => {
+      // prettier-ignore
+      logger.debug('getDocumentDetailsFromIds', objectKeys);
+      const getDocumentPromises = objectKeys.map((objectKey) =>
+        client.graphql({ query: getDocument, variables: { objectKey } }),
+      );
+      const getDocumentResolutions = await Promise.allSettled(getDocumentPromises);
+      const getDocumentRejected = getDocumentResolutions.filter((r) => r.status === 'rejected');
+      if (getDocumentRejected.length) {
+        setErrorMessage('failed to get document details - please try again later');
+        logger.error('get document promises rejected', getDocumentRejected);
+      }
+      const documentValues = getDocumentResolutions
+        .filter((r) => r.status === 'fulfilled')
+        .map((r) => r.value?.data?.getDocument);
 
-    return documentValues;
-  }, [setErrorMessage]);
+      return documentValues;
+    },
+    [setErrorMessage],
+  );
 
   useEffect(() => {
     if (subscriptionsRef.current.onCreate) {
       logger.debug('onCreateDocument subscription already exists, skipping');
-      return;
+      return undefined;
     }
 
     logger.debug('onCreateDocument subscription');
@@ -105,7 +108,7 @@ const useGraphQlApi = ({ initialPeriodsToLoad = DOCUMENT_LIST_SHARDS_PER_DAY * 2
   useEffect(() => {
     if (subscriptionsRef.current.onUpdate) {
       logger.debug('onUpdateDocument subscription already exists, skipping');
-      return;
+      return undefined;
     }
 
     logger.debug('onUpdateDocument subscription setup');