Skip to content

Commit 447a4a6

Browse files
author
Bob Strahan
committed
Merge branch 'fix/scan-warnings' into develop
2 parents f914cc9 + 7ab3721 commit 447a4a6

File tree

5 files changed

+33
-0
lines changed

5 files changed

+33
-0
lines changed

notebooks/examples/demo-lambda/template.yml

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,19 @@ Resources:
2323

2424
DemoLambdaFunction:
2525
Type: AWS::Serverless::Function
26+
Metadata:
27+
cfn_nag:
28+
rules_to_suppress:
29+
- id: W89
30+
reason: "Demo function - does not require VPC access"
31+
- id: W92
32+
reason: "Demo function - does not require reserved concurrency as it scales based on demand"
33+
- id: W58
34+
reason: "Demo function - DLQ not required"
35+
# checkov:skip=CKV_AWS_116: "DLQ not required for AppSync resolver function as GraphQL handles retries"
36+
# checkov:skip=CKV_AWS_117: "Function does not require VPC access as it only interacts with AWS services via APIs"
37+
# checkov:skip=CKV_AWS_115: "Function does not require reserved concurrency as it scales based on demand"
38+
# checkov:skip=CKV_AWS_173: "Environment variables do not contain sensitive data - only configuration values like feature flags and non-sensitive settings"
2639
Properties:
2740
FunctionName: GENAIIDP-notebook-demo-extractor
2841
PermissionsBoundary: !If [HasPermissionsBoundary, !Ref PermissionsBoundaryArn, !Ref AWS::NoValue]
@@ -43,6 +56,12 @@ Resources:
4356

4457
DemoLambdaLogGroup:
4558
Type: AWS::Logs::LogGroup
59+
Metadata:
60+
cfn_nag:
61+
rules_to_suppress:
62+
- id: W84
63+
reason: "Demo function - KMS CMK not required, but can be added by customer for production use cases"
64+
# checkov:skip=CKV_AWS_158: "Demo function - KMS CMK not required, but can be added by customer for production use cases"
4665
Properties:
4766
LogGroupName: !Sub "/aws/lambda/GENAIIDP-notebook-demo-extractor"
4867
RetentionInDays: 7 # Short retention for demo purposes

options/bda-lending-project/template.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,8 @@ Resources:
9292
reason: "This Lambda function does not require VPC access as it only interacts with AWS services via AWS APIs"
9393
- id: W92
9494
reason: "Function does not require concurrent execution limits as it is designed to scale based on demand"
95+
- id: W58
96+
reason: "DLQ not required for this function as StepFunctions will handle retries"
9597
# checkov:skip=CKV_AWS_116: "DLQ not required for this function as StepFunctions will handle retries"
9698
# checkov:skip=CKV_AWS_117: "Function does not require VPC access as it only interacts with AWS services via APIs"
9799
# checkov:skip=CKV_AWS_115: "Function does not require reserved concurrency as it scales based on demand"

options/bedrockkb/template.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -750,6 +750,8 @@ Resources:
750750
reason: "Function does not require VPC access as it only interacts with AWS services via APIs"
751751
- id: W92
752752
reason: "Function does not require reserved concurrency as it scales based on demand"
753+
- id: W58
754+
reason: "DLQ not required for Cfn Custom Resource function"
753755
# checkov:skip=CKV_AWS_116: "DLQ not required for Cfn Custom Resource function"
754756
# checkov:skip=CKV_AWS_117: "Function does not require VPC access as it only interacts with AWS services via APIs"
755757
# checkov:skip=CKV_AWS_115: "Function does not require reserved concurrency as it scales based on demand"

patterns/pattern-2/template.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1046,6 +1046,8 @@ Resources:
10461046
reason: "Function does not require concurrent execution limits as it is designed to scale based on demand"
10471047
- id: W11
10481048
reason: "Cloudwatch does not support resource-level permissions, and Bedrock should support any enabled Bedrock model_id or inference profile"
1049+
- id: W76
1050+
reason: "Suppressing W76: SPCM for IAM policy document is higher than 25"
10491051
# checkov:skip=CKV_AWS_116: "DLQ not required for this function as StepFunctions will handle retries"
10501052
# checkov:skip=CKV_AWS_173: "Environment variables do not contain sensitive data - only configuration values like feature flags and non-sensitive settings"
10511053
# checkov:skip=CKV_AWS_117: "Function does not require VPC access as it only interacts with AWS services via APIs"

template.yaml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3548,6 +3548,10 @@ Resources:
35483548
reason: "Function does not require VPC access as it only interacts with AWS services via APIs"
35493549
- id: W92
35503550
reason: "Function does not require reserved concurrency as it scales based on demand"
3551+
- id: W58
3552+
reason: "DLQ not required for Cfn Custom Resource function"
3553+
- id: W76
3554+
reason: "Suppressing W76: SPCM for IAM policy document is higher than 25"
35513555
# checkov:skip=CKV_AWS_116: "DLQ not required for analytics processor as it's invoked asynchronously by request handler with error handling and job status tracking in DynamoDB"
35523556
# checkov:skip=CKV_AWS_117: "Function does not require VPC access as it only interacts with AWS services via APIs"
35533557
# checkov:skip=CKV_AWS_115: "Function does not require reserved concurrency as it scales based on demand"
@@ -4330,6 +4334,8 @@ Resources:
43304334
reason: "Function does not require VPC access as it only interacts with AWS services via APIs"
43314335
- id: W92
43324336
reason: "Function does not require reserved concurrency as it scales based on demand"
4337+
- id: W58
4338+
reason: "DLQ not required for Cfn Custom Resource function"
43334339
# checkov:skip=CKV_AWS_116: "DLQ not required for Cfn Custom Resource function"
43344340
# checkov:skip=CKV_AWS_117: "Function does not require VPC access as it only interacts with AWS services via APIs"
43354341
# checkov:skip=CKV_AWS_115: "Function does not require reserved concurrency as it scales based on demand"
@@ -4527,6 +4533,8 @@ Resources:
45274533
reason: "Function does not require VPC access as it only interacts with AWS services via APIs"
45284534
- id: W92
45294535
reason: "Function does not require reserved concurrency as it scales based on demand"
4536+
- id: W58
4537+
reason: "DLQ not required for Cfn Custom Resource function"
45304538
# checkov:skip=CKV_AWS_116: "DLQ not required for Cfn Custom Resource function"
45314539
# checkov:skip=CKV_AWS_117: "Function does not require VPC access as it only interacts with AWS services via APIs"
45324540
# checkov:skip=CKV_AWS_115: "Function does not require reserved concurrency as it scales based on demand"

0 commit comments

Comments
 (0)