Skip to content

Commit ad98577

Browse files
committed
Merge branch 'fix/duplicate-glue-tables' into 'develop'
Fix/duplicate glue tables See merge request genaiic-reusable-assets/engagement-artifacts/genaiic-idp-accelerator!308
2 parents 489a970 + 7978663 commit ad98577

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

CHANGELOG.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,8 @@ SPDX-License-Identifier: MIT-0
88
### Fixed
99
- **GovCloud Template Generation - CloudFront Policy Removal**
1010
- Fixed issue where CloudFront policy statements were still appearing in generated GovCloud templates despite CloudFront resources being removed
11-
11+
- **Duplicate Glue tables created when dash used in document class name**
12+
- Duplicate Glue tables are created when using a document class that contains a dash (-). Resolved by replacing dash in section types with underscore character when creating the table, to align with the table name generated later by the Glue crawler - resolves #57.
1213

1314
## [0.3.15]
1415

lib/idp_common_pkg/idp_common/reporting/save_reporting_data.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -376,7 +376,7 @@ def _create_or_update_glue_table(
376376
return False
377377

378378
# Escape section_type to make it table-name-safe
379-
escaped_section_type = re.sub(r"[/\\:*?\"<>|]", "_", section_type.lower())
379+
escaped_section_type = re.sub(r"[/\\:*?\"<>|-]", "_", section_type.lower())
380380
table_name = f"document_sections_{escaped_section_type}"
381381

382382
# Convert schema to Glue columns

0 commit comments

Comments
 (0)