Skip to content

Commit e1c570c

Browse files
committed
Merge branch 'fixes/appsec-packages' into 'develop'
Update IDP CLI dependencies to address security vulnerabilities See merge request genaiic-reusable-assets/engagement-artifacts/genaiic-idp-accelerator!302
2 parents e2e0b35 + 6838ba5 commit e1c570c

File tree

3 files changed

+64
-29
lines changed

3 files changed

+64
-29
lines changed

memory-bank/activeContext.md

Lines changed: 34 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,41 @@
22

33
## Current Task Status
44

5-
**Feature Implementation**: ✅ **COMPLETED** - Service Principal GovCloud Compatibility Updates
5+
**Security Vulnerability Mitigation**: ✅ **COMPLETED** - IDP CLI Dependency Security Updates
66

7-
## Feature Overview
7+
**Previous Task**: ✅ **COMPLETED** - Service Principal GovCloud Compatibility Updates
8+
9+
## Security Vulnerability Mitigation Overview
10+
11+
Successfully addressed critical security vulnerabilities in the IDP CLI development tool by updating vulnerable dependencies:
12+
13+
### Issues Resolved:
14+
1. **urllib3 vulnerabilities (Medium severity - CVSS 5.3)**:
15+
- CVE-2025-50181: Redirect handling bypass vulnerability
16+
- CVE-2025-50182: Browser/Node.js redirect control issues
17+
- Updated from version 2.3.0 → 2.5.0
18+
19+
2. **tornado vulnerability (High severity - CVSS 7.5)**:
20+
- CVE-2025-47287: DoS through multipart/form-data parser logging
21+
- Updated from version 6.4.2 → 6.5.2
22+
23+
### Implementation Details:
24+
- **Location**: `scripts/sdlc/idp-cli/` (Development CLI tool)
25+
- **Method**: Direct dependency version constraints in `pyproject.toml`
26+
- **Approach**: Added explicit version requirements to force secure versions
27+
- **Testing**: Verified dependency resolution and basic functionality
28+
29+
### Files Modified:
30+
- `scripts/sdlc/idp-cli/pyproject.toml` - Added urllib3 >= 2.5.0 and tornado >= 6.5 constraints
31+
- `scripts/sdlc/idp-cli/poetry.lock` - Updated with new secure dependency versions
32+
33+
### Security Status:
34+
- ✅ All identified vulnerabilities resolved
35+
- ✅ Dependencies updated to secure versions
36+
- ✅ Functionality verified
37+
- ✅ Low implementation risk (development tool only)
38+
39+
## Previous Feature Overview (GovCloud Compatibility)
840

941
Successfully updated all CloudFormation templates to replace hardcoded AWS service principals with dynamic expressions for GovCloud compatibility:
1042

scripts/sdlc/idp-cli/poetry.lock

Lines changed: 27 additions & 26 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

scripts/sdlc/idp-cli/pyproject.toml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,8 @@ dependencies = [
1313
"typer (>=0.15.1,<0.16.0)",
1414
"loguru (>=0.7.3,<0.8.0)",
1515
"python-slugify (>=8.0.4,<9.0.0)",
16-
"pytest (>=8.3.4,<9.0.0)"
16+
"pytest (>=8.3.4,<9.0.0)",
17+
"urllib3 (>=2.5.0,<3.0.0)"
1718
]
1819

1920
[tool.poetry]
@@ -24,6 +25,7 @@ idpcli = "idp_cli.cli.main:app"
2425

2526
[tool.poetry.group.dev.dependencies]
2627
ipykernel = "^6.29.5"
28+
tornado = ">=6.5,<7.0"
2729

2830
[build-system]
2931
requires = ["poetry-core>=2.0.0,<3.0.0"]

0 commit comments

Comments
 (0)