Skip to content

Commit 7506418

Browse files
committed
minor fixes
1 parent 53440cd commit 7506418

File tree

3 files changed

+5
-6
lines changed

3 files changed

+5
-6
lines changed

data-collection/deploy/deploy-data-collection.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1477,14 +1477,14 @@ Resources:
14771477
Type: AWS::CloudFormation::Stack
14781478
Condition: DeployResilienceHubModule
14791479
Properties:
1480-
TemplateURL: !Sub "https://${CFNSourceBucket}.s3.${AWS::URLSuffix}/cfn/data-collection/v3.10.0/module-resilience-hub.yaml"
1480+
TemplateURL: !Sub "https://${CFNSourceBucket}.s3.${AWS::URLSuffix}/cfn/data-collection/v3.11.0/module-resilience-hub.yaml"
14811481
Parameters:
1482-
DestinationBucket: !Ref S3Bucket
1482+
DestinationBucket: !Ref S3Bucket # this includes account id
1483+
BucketPrefix: !Ref DestinationBucket # this is just a prefix
14831484
MultiAccountRoleName: !Sub "${ResourcePrefix}${MultiAccountRoleName}"
14841485
DataBucketsKmsKeysArns: !Ref DataBucketsKmsKeysArns
14851486
Schedule: !Ref ScheduleFrequent
14861487
ResourcePrefix: !Ref ResourcePrefix
1487-
BucketPrefix: !Ref DestinationBucket
14881488
RegionsInScope:
14891489
Fn::If:
14901490
- RegionsInScopeIsEmpty

data-collection/deploy/module-resilience-hub.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -422,4 +422,3 @@ Resources:
422422
# Parameters:
423423
# EXTERNAL: "TRUE"
424424
# skip.header.line.count: "1"
425-

test/utils.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -202,7 +202,7 @@ def initial_deploy_stacks(cloudformation, account_id, org_unit_id, bucket):
202202
{'ParameterKey': 'IncludeHealthEventsModule', 'ParameterValue': "yes"},
203203
{'ParameterKey': 'IncludeLicenseManagerModule', 'ParameterValue': "yes"},
204204
{'ParameterKey': 'IncludeServiceQuotasModule', 'ParameterValue': "yes"},
205-
{'ParameterKey': 'IncludeResiliencyHubModule', 'ParameterValue': "yes"},
205+
{'ParameterKey': 'IncludeResilienceHubModule', 'ParameterValue': "yes"},
206206
]
207207
)
208208

@@ -239,7 +239,7 @@ def initial_deploy_stacks(cloudformation, account_id, org_unit_id, bucket):
239239
{'ParameterKey': 'IncludeQuickSightModule', 'ParameterValue': "yes"},
240240
{'ParameterKey': 'IncludeServiceQuotasModule', 'ParameterValue': "yes"},
241241
{'ParameterKey': 'IncludeEUCUtilizationModule', 'ParameterValue': "yes"},
242-
{'ParameterKey': 'IncludeResiliencyHubModule', 'ParameterValue': "yes"},
242+
{'ParameterKey': 'IncludeResilienceHubModule', 'ParameterValue': "yes"},
243243
]
244244
)
245245

0 commit comments

Comments
 (0)