Skip to content

Commit 86c18bd

Browse files
authored
fix kms usecase on init (#333)
1 parent c53377d commit 86c18bd

File tree

5 files changed

+17
-7
lines changed

5 files changed

+17
-7
lines changed

data-collection/deploy/deploy-data-collection.yaml

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# https://github.com/awslabs/cid-data-collection-framework/blob/main/data-collection/deploy/deploy-data-collection.yaml
22
AWSTemplateFormatVersion: '2010-09-09'
3-
Description: CID Data Collection Stack v3.9.0 - AWS Solution SO9011
3+
Description: CID Data Collection Stack v3.9.1 - AWS Solution SO9011
44
Metadata:
55
AWS::CloudFormation::Interface:
66
ParameterGroups:
@@ -596,6 +596,17 @@ Resources:
596596
- !Sub "arn:${AWS::Partition}:glue:${AWS::Region}:${AWS::AccountId}:catalog"
597597
- !Sub "arn:${AWS::Partition}:glue:${AWS::Region}:${AWS::AccountId}:database/${DatabaseName}"
598598
- !Sub "arn:${AWS::Partition}:glue:${AWS::Region}:${AWS::AccountId}:table/${DatabaseName}/*"
599+
- !If
600+
- NeedDataBucketsKms
601+
- PolicyName: "KMS"
602+
PolicyDocument:
603+
Version: "2012-10-17"
604+
Statement:
605+
- Effect: "Allow"
606+
Action:
607+
- "kms:Decrypt"
608+
Resource: !Split [ ',', !Ref DataBucketsKmsKeysArns ]
609+
- !Ref AWS::NoValue
599610

600611
KmsPolicyForCidResources:
601612
Type: AWS::IAM::Policy
@@ -610,7 +621,6 @@ Resources:
610621
- 'kms:Decrypt'
611622
Resource: !Split [ ',', !Ref DataBucketsKmsKeysArns ]
612623
Roles:
613-
- !Ref LambdaInitRole
614624
- !Ref StepFunctionExecutionRole
615625
- !Ref LambdaManageGlueTableRole
616626
- !Ref GlueRole

data-collection/deploy/deploy-data-read-permissions.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# https://github.com/awslabs/cid-data-collection-framework/blob/main/data-collection/deploy/deploy-data-read-permissions.yaml
22
AWSTemplateFormatVersion: '2010-09-09'
3-
Description: CID Data Collection - All-in-One for Management Account v3.9.0 - AWS Solution SO9011
3+
Description: CID Data Collection - All-in-One for Management Account v3.9.1 - AWS Solution SO9011
44
Metadata:
55
AWS::CloudFormation::Interface:
66
ParameterGroups:
@@ -223,7 +223,7 @@ Resources:
223223
DataCollectorOrgAccountModulesReadStackSet:
224224
Type: AWS::CloudFormation::StackSet
225225
Properties:
226-
Description: "StackSet in charge of deploying read roles across organization accounts v3.9.0"
226+
Description: "StackSet in charge of deploying read roles across organization accounts v3.9.1"
227227
PermissionModel: SERVICE_MANAGED
228228
AutoDeployment:
229229
Enabled: true

data-collection/deploy/deploy-in-linked-account.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
AWSTemplateFormatVersion: '2010-09-09'
2-
Description: CID Data Collection - Role for Linked Account v3.9.0
2+
Description: CID Data Collection - Role for Linked Account v3.9.1
33
Metadata:
44
AWS::CloudFormation::Interface:
55
ParameterGroups:

data-collection/deploy/deploy-in-management-account.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
AWSTemplateFormatVersion: '2010-09-09'
2-
Description: CID Data Collection - Role for Management Account v3.9.0
2+
Description: CID Data Collection - Role for Management Account v3.9.1
33
Metadata:
44
AWS::CloudFormation::Interface:
55
ParameterGroups:

data-collection/utils/version.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
{
2-
"version": "3.9.0"
2+
"version": "3.9.1"
33
}

0 commit comments

Comments
 (0)