Skip to content

Commit 99d0966

Browse files
committed
a bit of refactoring on utils and pipelines
1 parent 719d5d0 commit 99d0966

File tree

7 files changed

+6
-171
lines changed

7 files changed

+6
-171
lines changed

.github/workflows/python.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,4 +22,4 @@ jobs:
2222
pip install cfn-flip pylint urllib3 boto3 bandit
2323
- name: Pylint all
2424
run: |
25-
python data-collection/utils/pylint.py
25+
python utils/pylint.py

.github/workflows/security-scan.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,4 +30,4 @@ jobs:
3030
pip install --no-cache-dir packaging cyclonedx-python-lib=='5.2.0' #https://github.com/bridgecrewio/checkov/issues/5841
3131
- name: Scan all templates
3232
run: |
33-
data-collection/utils/lint.sh
33+
utils/lint.sh

data-collection/CONTRIBUTING.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -57,19 +57,19 @@ aws s3api create-bucket --bucket $bucket
5757

5858
Cloud Formation:
5959
```bash
60-
./data-collection/utils/lint.sh
60+
./utils/lint.sh
6161
```
6262

6363
Pylint:
6464
```bash
65-
python3 ./data-collection/utils/pylint.py
65+
python3 ./utils/pylint.py
6666
```
6767

6868

6969
3. Upload the code to a bucket and run integration tests in your testing environment
7070

7171
```bash
72-
./data-collection/test/run-test-from-scratch.sh --no-teardown
72+
./test/run-test-from-scratch.sh --no-teardown
7373
```
7474

7575
The test will install stacks from scratch in a single account, then it will check the presence of Athena tables. After running tests, it will delete the stacks and all artifacts that are not deleted by CFN. You can avoid teardown by providing a flag `--no-teardown`.

data-collection/utils/lint.sh

Lines changed: 0 additions & 81 deletions
This file was deleted.

data-collection/utils/pylint.py

Lines changed: 0 additions & 84 deletions
This file was deleted.
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ GREEN='\033[0;32m'
77
YELLOW='\033[0;33m'
88
NC='\033[0m' # No Color
99

10-
folder=$(git rev-parse --show-toplevel)/data-collection/deploy
10+
folder=$(git rev-parse --show-toplevel)
1111
success_count=0
1212
failure_count=0
1313

0 commit comments

Comments
 (0)