fix deployedTemplate none issue (#466)

* Update common.py

* check if source template is not none + version bump

* return none instead of exception

Co-authored-by: Prykhodko <[email protected]>

Author: iakov-aws

cfn-templates/cid-cfn.yml

@@ -128,7 +128,7 @@ Parameters:
   CidVersion:
     Type: String
     MinLength: 5
-    Default: 0.2.11
+    Default: 0.2.12
     Description: A version of CID package
   Suffix:
     Type: String

cid/_version.py

@@ -1,2 +1,2 @@
 
-__version__ = '0.2.11'
+__version__ = '0.2.12'

cid/common.py

@@ -783,15 +783,20 @@ def check_dashboard_version_compatibility(self, dashboard_id):
         if not dashboard:
             print(f'Dashboard "{dashboard_id}" is not deployed')
             return None
-        
+        if not isinstance(dashboard.deployedTemplate, CidQsTemplate): 
+            print(f'Dashboard "{dashboard_id}" does not have a versioned template')
+            return None
+        if not isinstance(dashboard.sourceTemplate, CidQsTemplate):
+            print(f"Cannot access QuickSight source template for {dashboard_id}")
+            return None
         try:
-            cid_version = dashboard.deployedTemplate.cid_version if isinstance(dashboard.deployedTemplate, CidQsTemplate) else "N/A"            
+            cid_version = dashboard.deployedTemplate.cid_version            
         except ValueError:
             logger.debug("The cid version of the deployed dashboard could not be retrieved")
             cid_version = "N/A"
 
         try:
-            cid_version_latest = dashboard.sourceTemplate.cid_version if isinstance(dashboard.sourceTemplate, CidQsTemplate) else "N/A"
+            cid_version_latest = dashboard.sourceTemplate.cid_version
         except ValueError:
             logger.debug("The latest version of the dashboard could not be retrieved")
             cid_version_latest = "N/A"