Skip to content

Commit d6551de

Browse files
committed
[sdlf-utils] update parameters in examples
1 parent cc9ee3f commit d6551de

File tree

3 files changed

+12
-19
lines changed

3 files changed

+12
-19
lines changed

sdlf-utils/workshop-examples/10-demo/sdlf-workshop/dataset-legislators.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ Resources:
1111
Type: awslabs::sdlf::dataset::MODULE
1212
Properties:
1313
pPipelineReference: !Ref pPipelineReference
14-
pDatasetName: legislators
1514
pS3Prefix: legislators
1615
pDeploymentInstance: dev
1716
pStorageDeploymentInstance: dev

sdlf-utils/workshop-examples/10-demo/sdlf-workshop/pipeline-main.yaml

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,7 @@ Resources:
1010
rMainA:
1111
Type: awslabs::sdlf::stagelambda::MODULE
1212
Properties:
13-
pStageName: A
14-
pPipeline: main
15-
pDataset: legislators
16-
pDeploymentInstance: maina
13+
pDeploymentInstance: mainA
1714
pStorageDeploymentInstance: dev
1815
pDatasetDeploymentInstance: dev
1916
pTriggerType: event
@@ -35,13 +32,10 @@ Resources:
3532
rMainB:
3633
Type: awslabs::sdlf::stageglue::MODULE
3734
Properties:
38-
pStageName: B
39-
pPipeline: main
40-
pDataset: legislators
41-
pDeploymentInstance: mainb
35+
pDeploymentInstance: mainB
4236
pStorageDeploymentInstance: dev
4337
pDatasetDeploymentInstance: dev
44-
pGlueJobName: sdlf-legislators-glue-job
38+
pGlueJobName: sdlf-mainB-glue-job
4539
pGlueNumberOfWorkers: 10
4640
pGlueWorkerType: G.1X
4741
pTriggerType: schedule
@@ -54,7 +48,7 @@ Resources:
5448
"name": ["{{resolve:ssm:/sdlf/storage/rStageBucket/dev}}"]
5549
},
5650
"object": {
57-
"key": [{ "prefix": "legislators/main/A/" }]
51+
"key": [{ "prefix": "legislators/mainA/" }]
5852
}
5953
}
6054
}
@@ -65,6 +59,6 @@ Resources:
6559
"--job-bookmark-option": "job-bookmark-enable",
6660
"--enable-metrics": "",
6761
"--enable-auto-scaling": "true",
68-
"--SOURCE_LOCATION": !Sub "s3://{{resolve:ssm:/sdlf/storage/rStageBucket/dev}}/legislators/main/A",
69-
"--OUTPUT_LOCATION": !Sub "s3://{{resolve:ssm:/sdlf/storage/rAnalyticsBucket/dev}}/legislators/main/B"
62+
"--SOURCE_LOCATION": !Sub "s3://{{resolve:ssm:/sdlf/storage/rStageBucket/dev}}/legislators/mainA",
63+
"--OUTPUT_LOCATION": !Sub "s3://{{resolve:ssm:/sdlf/storage/rAnalyticsBucket/dev}}/legislators/mainB"
7064
}

sdlf-utils/workshop-examples/legislators/scripts/legislators-glue-job.yaml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,10 @@ AWSTemplateFormatVersion: 2010-09-09
22
Description: Glue Job Sample
33

44
Parameters:
5-
pDatasetName:
6-
Description: The dataset name
5+
pPipelineDeploymentInstance:
76
Type: String
8-
Default: legislators
7+
Description: specific pipeline stage deployment instance this job is for
8+
Default: mainB
99
pArtifactsBucket:
1010
Description: S3 bucket used to store artifacts (from CICD or generated by data pipelines)
1111
Type: AWS::SSM::Parameter::Value<String>
@@ -37,7 +37,7 @@ Resources:
3737
- !Sub arn:${AWS::Partition}:iam::aws:policy/AmazonS3FullAccess
3838
- !Sub arn:${AWS::Partition}:iam::aws:policy/CloudWatchLogsFullAccess
3939
Policies:
40-
- PolicyName: !Sub sdlf-${pDatasetName}-glue-job
40+
- PolicyName: !Sub sdlf-${pPipelineDeploymentInstance}-glue-job
4141
PolicyDocument:
4242
Version: 2012-10-17
4343
Statement:
@@ -60,7 +60,7 @@ Resources:
6060
Command:
6161
Name: glueetl
6262
PythonVersion: "3"
63-
ScriptLocation: !Sub s3://${pArtifactsBucket}/artifacts/${pDatasetName}-glue-job.py
63+
ScriptLocation: !Sub s3://${pArtifactsBucket}/artifacts/${pPipelineDeploymentInstance}-glue-job.py
6464
DefaultArguments: !If
6565
- RunInVpc
6666
-
@@ -75,6 +75,6 @@ Resources:
7575
MaxRetries: 0
7676
MaxCapacity: 2.0
7777
GlueVersion: "4.0"
78-
Name: !Sub sdlf-${pDatasetName}-glue-job
78+
Name: !Sub sdlf-${pPipelineDeploymentInstance}-glue-job
7979
SecurityConfiguration: "{{resolve:ssm:/sdlf/dataset/rGlueSecurityConfiguration/dev:1}}"
8080
Role: !Ref rGlueRole

0 commit comments

Comments
 (0)