From 65d786da3f1c996b3f167b0d7225d8542bb83405 Mon Sep 17 00:00:00 2001 From: Diego Valencia <112521660+Bauxitiego@users.noreply.github.com> Date: Fri, 26 Apr 2024 16:12:05 +0200 Subject: [PATCH 1/2] provide ability to override default glue database name Added parameter for provide ability to override default glue database name instead of default database name --- sdlf-dataset/template.yaml | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/sdlf-dataset/template.yaml b/sdlf-dataset/template.yaml index 85121921..5c276a82 100644 --- a/sdlf-dataset/template.yaml +++ b/sdlf-dataset/template.yaml @@ -29,6 +29,10 @@ Parameters: Description: Name of the team owning the pipeline (all lowercase, no symbols or spaces) Type: String AllowedPattern: "[a-z0-9]*" + pGlueDatabaseName: + Description: The name of the Glue database (all lowercase, alphanumeric and underscore characters only) + Type: String + AllowedPattern: "[a-z0-9_]{2,14}" pPipelineDetails: Type: String Default: >- @@ -54,7 +58,8 @@ Resources: CatalogId: !Ref AWS::AccountId DatabaseInput: Description: !Sub "${pTeamName} team ${pDatasetName} metadata catalog" - Name: !Sub ${pOrg}_${pDomain}_${pEnvironment}_${pTeamName}_${pDatasetName}_db + #Name: !Sub ${pOrg}_${pDomain}_${pEnvironment}_${pTeamName}_${pDatasetName}_db + Name: !Ref pGlueDatabaseName rGlueDataCatalogLakeFormationTag: Type: AWS::LakeFormation::TagAssociation From fcbdc5a7a8a07bdf5bd420a7f513557f3165f150 Mon Sep 17 00:00:00 2001 From: Diego Valencia <112521660+Bauxitiego@users.noreply.github.com> Date: Fri, 26 Apr 2024 16:21:27 +0200 Subject: [PATCH 2/2] Added pGlueDatabaseName instead of pGlueDataSetName --- sdlf-dataset/template.yaml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sdlf-dataset/template.yaml b/sdlf-dataset/template.yaml index 5c276a82..ee8eb689 100644 --- a/sdlf-dataset/template.yaml +++ b/sdlf-dataset/template.yaml @@ -58,8 +58,7 @@ Resources: CatalogId: !Ref AWS::AccountId DatabaseInput: Description: !Sub "${pTeamName} team ${pDatasetName} metadata catalog" - #Name: !Sub ${pOrg}_${pDomain}_${pEnvironment}_${pTeamName}_${pDatasetName}_db - Name: !Ref pGlueDatabaseName + Name: !Sub ${pOrg}_${pDomain}_${pEnvironment}_${pTeamName}_${pGlueDatabaseName}_db rGlueDataCatalogLakeFormationTag: Type: AWS::LakeFormation::TagAssociation