Skip to content

Commit cc31291

Browse files
author
Joshua Leaverton
committed
cron string fix
1 parent 107aa72 commit cc31291

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

README.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -81,11 +81,11 @@ AWS Solutions use two buckets: a bucket for global access to templates, which is
8181

8282
**Build the solution**
8383

84-
From the *deployment* folder in your cloned repo, run build-s3-dist.sh, passing the root name of your bucket (ex. mybucket) and the version you are building (ex. v1.0.0). We recommend using a semver version based on the version downloaded from GitHub (ex. GitHub: v1.0.0, your build: v1.0.0.mybuild)
84+
From the *deployment* folder in your cloned repo, run build-s3-dist.sh, passing the root name of your bucket (ex. mybucket), name of the solution i.e. aws-instance-scheduler and the version you are building (ex. v1.3.3). We recommend using a similar version based on the version downloaded from GitHub (ex. GitHub: v1.3.3, your build: v1.3.3.mybuild)
8585

8686
```
8787
chmod +x build-s3-dist.sh
88-
build-s3-dist.sh <bucketname> <version>
88+
build-s3-dist.sh <bucketname> aws-instance-scheduler <version>
8989
```
9090

9191
**Run Unit Tests**
@@ -102,22 +102,22 @@ Confirm that all unit tests pass.
102102

103103
Upload the template and the lambda to your bucket in the following pattern,
104104
```
105-
s3://mybucket/aws-instance-scheduler/v1.3.3/instance-scheduler.zip (lambda Code)
105+
s3://mybucket-us-east-1/aws-instance-scheduler/v1.3.3/instance-scheduler.zip (lambda Code)
106106
```
107107

108108
Templates
109109
```
110-
s3://mybucket-us-east-1/aws-instance-scheduler/v1.3.3/AwsInstanceScheduler.template
111-
s3://mybucket-us-east-1/aws-instance-scheduler/v1.3.3/AwsInstanceSchedulerRemote.template
110+
s3://mybucket/aws-instance-scheduler/v1.3.3/instance-scheduler.template
111+
s3://mybucket/aws-instance-scheduler/v1.3.3/instance-scheduler-remote.template
112112
```
113113

114114
## Deploy
115115

116-
See the (AWS Instance Scheduler Implementation Guide)[https://s3.amazonaws.com/solutions-reference/aws-instance-scheduler/latest/instance-scheduler.pdf] for deployment instructions, using the link to the AwsInstanceScheduler.template from your bucket, rather than the one for AWS Solutions. Ex. https://mybucket.s3.amazonaws.com/aws-instance-scheduler/v1.0.0.mybuild/AwsInstanceScheduler.template
116+
See the [AWS Instance Scheduler Implementation Guide](https://s3.amazonaws.com/solutions-reference/aws-instance-scheduler/latest/instance-scheduler.pdf) for deployment instructions, using the link to the instance-scheduler.template from your bucket, rather than the one for AWS Solutions. Ex. https://mybucket.s3.amazonaws.com/aws-instance-scheduler/v1.3.3.mybuild/instance-scheduler.template
117117

118118
## CDK Documentation
119119

120-
AWS Instance Scheduler templates are generated using AWS CDK, for further information on CDK please refer to the (documentation)[https://docs.aws.amazon.com/cdk/latest/guide/getting_started.html].
120+
AWS Instance Scheduler templates are generated using AWS CDK, for further information on CDK please refer to the [documentation](https://docs.aws.amazon.com/cdk/latest/guide/getting_started.html)
121121

122122

123123
***

source/lib/aws-instance-scheduler-stack.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -612,7 +612,7 @@ export class AwsInstanceSchedulerStack extends cdk.Stack {
612612
mappings.setValue("Timeouts", "10", "cron(0/10 * * * ? *)")
613613
mappings.setValue("Timeouts", "15", "cron(0/15 * * * ? *)")
614614
mappings.setValue("Timeouts", "30", "cron(0/30 * * * ? *)")
615-
mappings.setValue("Timeouts", "60", "cron(0/1 * * ? *)")
615+
mappings.setValue("Timeouts", "60", "cron(0 0/1 * * ? *)")
616616
mappings.setValue("Settings", "MetricsUrl", "https://metrics.awssolutionsbuilder.com/generic")
617617
mappings.setValue("Settings", "MetricsSolutionId", "S00030")
618618

source/test/__snapshots__/aws-instance-scheduler-stack.test.ts.snap

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ Object {
2525
"2": "cron(0/2 * * * ? *)",
2626
"30": "cron(0/30 * * * ? *)",
2727
"5": "cron(0/5 * * * ? *)",
28-
"60": "cron(0/1 * * ? *)",
28+
"60": "cron(0 0/1 * * ? *)",
2929
},
3030
"TrueFalse": Object {
3131
"No": "False",

0 commit comments

Comments
 (0)