update to v1.5.2 open-source release (#195)

Author: simonkrol

.viperlightignore

@@ -12,4 +12,15 @@ deployment/simple-file-manager-for-amazon-efs.yaml:74
 deployment/simple-file-manager-for-amazon-efs.yaml:59
 deployment/simple-file-manager-for-amazon-efs.yaml:84
 deployment/simple-file-manager-for-amazon-efs.yaml:69
-test/
+test/
+
+[node-npmoutdated]
+@aws-amplify/api=4.0.64 
+@aws-amplify/core=4.7.15
+aws-amplify=4.3.46
+bootstrap=4.6.2
+vue=2.7.14
+vue-router=3.6.5
+eslint=7.32.0
+eslint-plugin-vue=7.20.0
+webpack-subresource-integrity=1.5.2

.viperlightrc

@@ -4,6 +4,11 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [1.5.2] - 2023-05-19
+### Bug Fixes:
+- elasticfilesystem:TagResource permission added to Manager Lambda
+- Urllib3 downgraded to < v2
+
 ## [1.5.1] - 2023-04-13
 ### Security:
 - Enable versioning/encryption on logging bucket 

CHANGELOG.md

@@ -18,6 +18,7 @@ Selenium under the Apache License Version 2.0
 Boto3 under the Apache License Version 2.0
 Pyyaml under the MIT License (MIT)
 Requests_toolbelt under the Apache License Version 2.0
+Urllib3 under the the MIT License (MIT)
 Aws-amplify under the Apache License Version 2.0
 Aws-amplify-vue under the Apache License Version 2.0
 Bootstrap under the MIT License (MIT)

NOTICE.txt

@@ -179,6 +179,15 @@ Resources:
                   - "arn:aws:elasticfilesystem:*:*:file-system/*"
                   - "arn:aws:elasticfilesystem:*:*:access-point/*"
                   - "arn:aws:elasticfilesystem:*:*:*"
+              - Effect: Allow
+                Action:
+                  - "elasticfilesystem:TagResource"
+                Resource:
+                  - "arn:aws:elasticfilesystem:*:*:access-point/*"
+                  - "arn:aws:elasticfilesystem:*:*:file-system/*"
+                Condition:
+                  StringEquals:
+                    elasticfilesystem:CreateAction: CreateAccessPoint
               - Effect: Allow
                 Action:
                   - "iam:PassRole"

deployment/simple-file-manager-for-amazon-efs.yaml

@@ -35,6 +35,8 @@
 
 DEFAULT_ERROR_MESSAGE = 'Check API logs for more information'
 
+DEFAULT_MISSING_PARAMS_ERROR_MESSAGE = 'Missing required query param: {e}'
+
 # Cognito resources
 # From cloudformation stack
 
@@ -500,8 +502,8 @@ def upload(filesystem_id):
         path = app.current_request.query_params['path']
         filename = app.current_request.query_params['filename']
     except KeyError as error:
-        app.log.error('Missing required query param: {e}'.format(e=error))
-        raise BadRequestError('Missing required query param: {e}'.format(e=error))
+        app.log.error(DEFAULT_MISSING_PARAMS_ERROR_MESSAGE.format(e=error))
+        raise BadRequestError(DEFAULT_MISSING_PARAMS_ERROR_MESSAGE.format(e=error))
 
     request = app.current_request
     chunk_data = request.json_body
@@ -534,8 +536,8 @@ def download(filesystem_id):
         path = query_params['path']
         filename = query_params['filename']
     except KeyError as error:
-        app.log.error('Missing required query param: {e}'.format(e=error))
-        raise BadRequestError('Missing required query param: {e}'.format(e=error))
+        app.log.error(DEFAULT_MISSING_PARAMS_ERROR_MESSAGE.format(e=error))
+        raise BadRequestError(DEFAULT_MISSING_PARAMS_ERROR_MESSAGE.format(e=error))
 
     try:
         chunk_index = query_params['dzchunkindex']
@@ -600,8 +602,8 @@ def delete_object(filesystem_id):
         name = app.current_request.query_params['name']
         path = app.current_request.query_params['path']
     except KeyError as error:
-        app.log.error('Missing required query param: {e}'.format(e=error))
-        raise BadRequestError('Missing required query param: {e}'.format(e=error))
+        app.log.error(DEFAULT_MISSING_PARAMS_ERROR_MESSAGE.format(e=error))
+        raise BadRequestError(DEFAULT_MISSING_PARAMS_ERROR_MESSAGE.format(e=error))
 
     filemanager_event = {"operation": "delete", "path": path, "name": name}
     operation_result = proxy_operation_to_efs_lambda(filesystem_id, filemanager_event)
@@ -623,8 +625,8 @@ def list_objects(filesystem_id):
     try:
         path = app.current_request.query_params['path']
     except KeyError as error:
-        app.log.error('Missing required query param: {e}'.format(e=error))
-        raise BadRequestError('Missing required query param: {e}'.format(e=error))
+        app.log.error(DEFAULT_MISSING_PARAMS_ERROR_MESSAGE.format(e=error))
+        raise BadRequestError(DEFAULT_MISSING_PARAMS_ERROR_MESSAGE.format(e=error))
 
     filemanager_event = {"operation": "list", "path": path}
     operation_result = proxy_operation_to_efs_lambda(filesystem_id, filemanager_event)

source/api/app.py

@@ -24,10 +24,10 @@ def delete(event):
     path = event['path']
     name = event['name']
 
-    file = path + '/' + name
+    file_path = path + '/' + name
 
     try:
-        os.remove(file)
+        os.remove(file_path)
     except OSError:
         return {"message": "couldn't delete the file", "statusCode": 500}
     else:
@@ -151,7 +151,7 @@ def list(event):
         return {"path": path, "directiories": dir_items, "files": file_items, "statusCode": 200}
 
 
-def lambda_handler(event, context):
+def lambda_handler(event, _context):
     # get operation type
     try:
         operation_type = event['operation']

source/api/chalicelib/efs_lambda.py

@@ -1,2 +1,3 @@
 pyyaml
-requests_toolbelt
+requests_toolbelt
+urllib3<2

source/api/requirements.txt

@@ -50,5 +50,11 @@
     "> 1%",
     "last 2 versions",
     "not dead"
-  ]
+  ],
+  "overrides": {
+    "fast-xml-parser": "4.2.4"
+  },
+  "resolutions": {
+    "fast-xml-parser": "4.2.4"
+ } 
 }