[Target Allocator] Enable Deployment and Daemonset modes for Agent (#253)

okankoAMZ · web-flow · commit b74b110a32a1 · 2024-10-21T18:13:38.000-04:00
* Changes error to warning
diff --git a/apis/v1alpha1/collector_webhook.go b/apis/v1alpha1/collector_webhook.go
@@ -171,7 +171,7 @@ func (c CollectorWebhook) validate(r *AmazonCloudWatchAgent) (admission.Warnings
 
 	// validate target allocation
 	if r.Spec.TargetAllocator.Enabled && r.Spec.Mode != ModeStatefulSet {
-		return warnings, fmt.Errorf("the OpenTelemetry Collector mode is set to %s, which does not support the target allocation deployment", r.Spec.Mode)
+		warnings = append(warnings, fmt.Sprintf("The Amazon CloudWatch Agent mode is set to %s, we do not recommend enabling Target Allocator when not running as a StatefulSet", r.Spec.Mode))
 	}
 
 	// validate Prometheus config for target allocation

Original file line number	Diff line number	Diff line change
`@@ -171,7 +171,7 @@ func (c CollectorWebhook) validate(r *AmazonCloudWatchAgent) (admission.Warnings`
`171`	`171`
`172`	`172`	`// validate target allocation`
`173`	`173`	`if r.Spec.TargetAllocator.Enabled && r.Spec.Mode != ModeStatefulSet {`
`174`		`- return warnings, fmt.Errorf("the OpenTelemetry Collector mode is set to %s, which does not support the target allocation deployment", r.Spec.Mode)`
	`174`	`+ warnings = append(warnings, fmt.Sprintf("The Amazon CloudWatch Agent mode is set to %s, we do not recommend enabling Target Allocator when not running as a StatefulSet", r.Spec.Mode))`
`175`	`175`	`}`
`176`	`176`
`177`	`177`	`// validate Prometheus config for target allocation`