Skip to content

Conversation

@sky333999
Copy link
Contributor

@sky333999 sky333999 commented Aug 8, 2025

Description:

  • Introduces new Collector CRD config options for configuring & managing the ClusterIP Service, Headless Service & Monitoring Service.
  • For each of the Services, config to Enable/Disable the service and override the Name of the service.
  • To maintain backwards compatibility, I considered the following two options and decided to go with the second.
    • Call the flag Disabled instead of Enabled such that it initializes to false when not set and the behavior stays the same.
    • Make the flags pointers instead of bools such that we can know whether the flag was explicitly provided i.e. nil implies retain old behavior.

Description:

  • Unit Testing: Added new unit tests
  • Local Testing: Built image with changes, validated on dev cluster with helm chart to test creation & disabling of services.

Default installation:
image

Updated CR to disable ClusterIP service only:
image

Updated CR to disable all 3 services for cloudwatch-agent:
image

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

resources:
- amazoncloudwatchagents
- dcgmexporters
- instrumentations
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are these updates expected?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think this is effectively a no-op where the changes got consolidated. Likely due to we updated kubebuilder version and I now ran make manifests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants