Skip to content

Commit bc787a3

Browse files
authored
Revert per events header bytes to 200 (#1513)
1 parent 7b2b664 commit bc787a3

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

plugins/outputs/cloudwatchlogs/internal/pusher/batch.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ const (
2222
// The maximum number of log events in a batch.
2323
reqEventsLimit = 10000
2424
// The bytes required for metadata for each log event.
25-
perEventHeaderBytes = 26
25+
perEventHeaderBytes = 200
2626
// A batch of log events in a single request cannot span more than 24 hours. Otherwise, the operation fails.
2727
batchTimeRangeLimit = 24 * time.Hour
2828
)

plugins/outputs/cloudwatchlogs/internal/pusher/batch_test.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -70,20 +70,20 @@ func TestLogEventBatch(t *testing.T) {
7070
t.Run("HasSpace", func(t *testing.T) {
7171
batch := newLogEventBatch(Target{Group: "G", Stream: "S"}, nil)
7272

73+
event := newLogEvent(time.Now(), "Test message", nil)
74+
maxEvents := reqSizeLimit / event.eventBytes
75+
7376
// Add events until close to the limit
74-
for i := 0; i < reqEventsLimit-1; i++ {
75-
event := newLogEvent(time.Now(), "Test message", nil)
77+
for i := 0; i < maxEvents-1; i++ {
7678
batch.append(event)
7779
}
7880

79-
assert.True(t, batch.hasSpace(100), "Batch should have space for one more small event")
80-
assert.False(t, batch.hasSpace(reqSizeLimit), "Batch should not have space for an event that exceeds the size limit")
81+
assert.True(t, batch.hasSpace(event.eventBytes))
8182

8283
// Add one more event to reach the limit
83-
event := newLogEvent(time.Now(), "Last message", nil)
8484
batch.append(event)
8585

86-
assert.False(t, batch.hasSpace(1), "Batch should not have space after reaching event limit")
86+
assert.False(t, batch.hasSpace(event.eventBytes))
8787
})
8888

8989
t.Run("Build", func(t *testing.T) {

0 commit comments

Comments
 (0)