generated from amazon-archives/__template_Custom
-
Notifications
You must be signed in to change notification settings - Fork 237
Adding Container Insights Jmx Pipeline #1382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
translator/translate/otel/pipeline/containerinsightsjmx/translator.go
Outdated
Show resolved
Hide resolved
translator/config/sampleSchema/invalidContainerInsightsJmx.json
Outdated
Show resolved
Hide resolved
jefchien
reviewed
Oct 10, 2024
translator/translate/otel/pipeline/containerinsightsjmx/translator.go
Outdated
Show resolved
Hide resolved
translator/translate/otel/pipeline/containerinsightsjmx/translator.go
Outdated
Show resolved
Hide resolved
translator/translate/otel/pipeline/containerinsightsjmx/translator.go
Outdated
Show resolved
Hide resolved
translator/translate/otel/processor/resourceprocessor/translator.go
Outdated
Show resolved
Hide resolved
jefchien
reviewed
Oct 10, 2024
jefchien
reviewed
Oct 10, 2024
translator/translate/otel/processor/resourceprocessor/translator.go
Outdated
Show resolved
Hide resolved
jefchien
reviewed
Oct 10, 2024
translator/translate/otel/processor/transformprocessor/translate.go
Outdated
Show resolved
Hide resolved
translator/translate/otel/processor/filterprocessor/translator.go
Outdated
Show resolved
Hide resolved
sky333999
reviewed
Oct 11, 2024
translator/translate/otel/pipeline/containerinsightsjmx/translator.go
Outdated
Show resolved
Hide resolved
translator/translate/otel/processor/filterprocessor/testdata/ContainerInsightsJmxConfig.yaml
Show resolved
Hide resolved
translator/translate/otel/processor/resourceprocessor/translator.go
Outdated
Show resolved
Hide resolved
translator/translate/otel/processor/resourceprocessor/translator.go
Outdated
Show resolved
Hide resolved
translator/translate/otel/processor/transformprocessor/translate.go
Outdated
Show resolved
Hide resolved
sky333999
reviewed
Oct 11, 2024
translator/translate/otel/processor/transformprocessor/testdata/config.yaml
Show resolved
Hide resolved
sky333999
reviewed
Oct 11, 2024
Contributor
|
We should update |
musa-asad
reviewed
Oct 11, 2024
translator/translate/otel/processor/filterprocessor/translator_test.go
Outdated
Show resolved
Hide resolved
jefchien
approved these changes
Oct 11, 2024
sky333999
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
We want to be able to have java/jmx container insights dashboards populated.
Pipeline overview
Reciever
Processors
Exporters
1.. Debug exporter - Helps visualize which metrics are being created (can be removed)

2. Aws Emf Exporter - send metrics to Namespace: ContainerInsights/Prometheus (based off of documentation) with Log group name /aws/containerinsights/{ClusterName}/jmx and log stream name: {NodeName}. Both ClusterName and NodeName comes from the resource attributes.
Note one requirement for the Container Insight Java/Jmx dashboards to be populated is to have
java_lang_operatingsystem_totalphysicalmemorysizemetric. Without this metric the dashboard will not be populated.Description of changes
How does this change address the problem?
License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
Created unit tests for each processor and tocwconfig test which test the full generated yaml from json. The test is called
TestContainerInsightsJMXRequirements
Before commit the code, please do the following steps.
make fmtandmake fmt-shmake lint