Skip to content

Commit 18516b1

Browse files
committed
fix: Fix PR Comments
1 parent d5fdb70 commit 18516b1

File tree

6 files changed

+14
-7
lines changed

6 files changed

+14
-7
lines changed

.gitignore

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,3 +49,5 @@ book/
4949
.env*
5050

5151
run-build.sh
52+
# Amazon Q CLI files
53+
.amazonq/

Cargo.lock

Lines changed: 4 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

crates/fig_log/Cargo.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ default = []
1616
# sentry = ["dep:sentry-tracing"]
1717

1818
[dependencies]
19+
fig_os_shim.workspace = true
1920
fig_util.workspace = true
2021
parking_lot.workspace = true
2122
thiserror.workspace = true

crates/fig_log/src/lib.rs

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ use std::path::Path;
33
use std::sync::Mutex;
44

55
use fig_util::CHAT_BINARY_NAME;
6-
use fig_util::env_var::Q_LOG_LEVEL;
76
use thiserror::Error;
87
use tracing::info;
98
use tracing::level_filters::LevelFilter;
@@ -193,7 +192,9 @@ pub fn initialize_logging<T: AsRef<Path>>(args: LogArgs<T>) -> Result<LogGuard,
193192
/// Returns a string identifying the current log level.
194193
pub fn get_log_level() -> String {
195194
Q_LOG_LEVEL_GLOBAL.lock().unwrap().clone().unwrap_or_else(|| {
196-
std::env::var(Q_LOG_LEVEL).unwrap_or_else(|_| DEFAULT_FILTER.to_string()) // ALLOWED: fig_log doesn't have fig_os_shim dependency
195+
fig_os_shim::Env::new()
196+
.q_log_level()
197+
.unwrap_or_else(|_| DEFAULT_FILTER.to_string())
197198
})
198199
}
199200

@@ -245,7 +246,7 @@ fn create_filter_layer() -> EnvFilter {
245246
.lock()
246247
.unwrap()
247248
.clone()
248-
.or_else(|| std::env::var(Q_LOG_LEVEL).ok()); // ALLOWED: fig_log doesn't have fig_os_shim dependency
249+
.or_else(|| fig_os_shim::Env::new().q_log_level().ok());
249250

250251
match log_level {
251252
Some(level) => EnvFilter::builder()

crates/fig_request/Cargo.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ workspace = true
1818
bytes.workspace = true
1919
cfg-if.workspace = true
2020
cookie = "0.18.0"
21+
fig_os_shim.workspace = true
2122
fig_settings.workspace = true
2223
fig_util.workspace = true
2324
reqwest_cookie_store = "0.8.0"

crates/fig_request/src/reqwest_client.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,8 @@ pub fn create_default_root_cert_store() -> RootCertStore {
2323
let _ = root_cert_store.add(cert);
2424
}
2525

26-
let custom_cert = std::env::var("Q_CUSTOM_CERT") // ALLOWED: fig_request doesn't have fig_os_shim dependency
26+
let custom_cert = fig_os_shim::Env::new()
27+
.q_custom_cert()
2728
.ok()
2829
.or_else(|| fig_settings::state::get_string("Q_CUSTOM_CERT").ok().flatten());
2930

0 commit comments

Comments
 (0)