Address clippy failures and update sdk behavior versions (#869)

Author: kkashilk

Cargo.lock

@@ -87,7 +87,7 @@ pub fn client(region: Region) -> Client {
     Client::new(
         &aws_types::SdkConfig::builder()
             .http_client(crate::aws_common::http_client::client())
-            .behavior_version(BehaviorVersion::v2025_01_17())
+            .behavior_version(BehaviorVersion::v2025_08_07())
             .endpoint_url(oidc_url(&region))
             .region(region)
             .retry_config(RetryConfig::standard().with_max_attempts(3))

crates/chat-cli/src/auth/builder_id.rs

@@ -17,7 +17,7 @@ pub fn app_name() -> AppName {
 }
 
 pub fn behavior_version() -> BehaviorVersion {
-    BehaviorVersion::v2025_01_17()
+    BehaviorVersion::v2025_08_07()
 }
 
 #[cfg(test)]

crates/chat-cli/src/aws_common/mod.rs

@@ -29,7 +29,7 @@ pub async fn get_cognito_credentials_send(
     trace!("Creating new cognito credentials");
 
     let conf = aws_sdk_cognitoidentity::Config::builder()
-        .behavior_version(BehaviorVersion::v2025_01_17())
+        .behavior_version(BehaviorVersion::v2025_08_07())
         .region(telemetry_stage.region.clone())
         .app_name(app_name())
         .build();

crates/chat-cli/src/telemetry/cognito.rs

@@ -405,7 +405,7 @@ impl TelemetryClient {
             Some(ToolkitTelemetryClient::from_conf(
                 Config::builder()
                     .http_client(crate::aws_common::http_client::client())
-                    .behavior_version(BehaviorVersion::v2025_01_17())
+                    .behavior_version(BehaviorVersion::v2025_08_07())
                     .endpoint_resolver(StaticEndpoint(TelemetryStage::EXTERNAL_PROD.endpoint))
                     .app_name(app_name())
                     .region(TelemetryStage::EXTERNAL_PROD.region.clone())

crates/chat-cli/src/telemetry/mod.rs

@@ -100,7 +100,7 @@ pub(crate) fn client(region: Region) -> Client {
     let retry_config = RetryConfig::standard().with_max_attempts(3);
     let sdk_config = aws_types::SdkConfig::builder()
         .http_client(fig_aws_common::http_client::client())
-        .behavior_version(BehaviorVersion::v2025_01_17())
+        .behavior_version(BehaviorVersion::v2025_08_07())
         .endpoint_url(oidc_url(&region))
         .region(region)
         .retry_config(retry_config)

crates/fig_auth/src/builder_id.rs

@@ -17,7 +17,7 @@ pub fn app_name() -> AppName {
 }
 
 pub fn behavior_version() -> BehaviorVersion {
-    BehaviorVersion::v2025_01_17()
+    BehaviorVersion::v2025_08_07()
 }
 
 #[cfg(test)]

crates/fig_aws_common/src/lib.rs

@@ -28,7 +28,7 @@ pub(crate) async fn get_cognito_credentials_send(
     telemetry_stage: &TelemetryStage,
 ) -> Result<Credentials, CredentialsError> {
     let conf = aws_sdk_cognitoidentity::Config::builder()
-        .behavior_version(BehaviorVersion::v2025_01_17())
+        .behavior_version(BehaviorVersion::v2025_08_07())
         .region(telemetry_stage.region.clone())
         .app_name(app_name())
         .build();

crates/fig_telemetry/src/cognito.rs

@@ -208,7 +208,7 @@ impl Client {
         let toolkit_telemetry_client = Some(amzn_toolkit_telemetry_client::Client::from_conf(
             Config::builder()
                 .http_client(fig_aws_common::http_client::client())
-                .behavior_version(BehaviorVersion::v2025_01_17())
+                .behavior_version(BehaviorVersion::v2025_08_07())
                 .endpoint_resolver(StaticEndpoint(telemetry_stage.endpoint))
                 .app_name(app_name())
                 .region(telemetry_stage.region.clone())

crates/fig_telemetry/src/lib.rs

@@ -231,7 +231,7 @@ pub trait ReadHalf: std::fmt::Debug + Send + Sync + 'static {
     /// The default implementation simply panics. Implementers must override either `read_message`
     /// or this method.
     async fn recvmsg(&mut self, _buf: &mut [u8]) -> RecvmsgResult {
-        unimplemented!("`ReadHalf` implementers must either override `read_message` or `recvmsg`");
+        panic!("`ReadHalf` implementers must either override `read_message` or `recvmsg`");
     }
 
     /// Return whether passing file descriptors is supported.
@@ -299,7 +299,7 @@ pub trait WriteHalf: std::fmt::Debug + Send + Sync + 'static {
     /// The default implementation simply panics. Implementers must override either `send_message`
     /// or this method.
     async fn sendmsg(&mut self, _buffer: &[u8], #[cfg(unix)] _fds: &[BorrowedFd<'_>]) -> io::Result<usize> {
-        unimplemented!("`WriteHalf` implementers must either override `send_message` or `sendmsg`");
+        panic!("`WriteHalf` implementers must either override `send_message` or `sendmsg`");
     }
 
     /// The dbus daemon on `freebsd` and `dragonfly` currently requires sending the zero byte