Skip to content

Commit 7362da6

Browse files
committed
feat(build): Parameterize manifest.py with binary name constants
- Import APP_NAME, CLI_BINARY_NAME, PTY_BINARY_NAME, CHAT_BINARY_NAME - Replace hardcoded 'Amazon Q.app' with f-string using APP_NAME - Replace hardcoded binary paths and identifiers with constants 🤖 Assisted by Amazon Q Developer
1 parent e9f4d99 commit 7362da6

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

build-scripts/manifest.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
from dataclasses import dataclass
22
from enum import Enum
33

4-
from const import APPLE_TEAM_ID
4+
from const import APPLE_TEAM_ID, APP_NAME, CLI_BINARY_NAME, PTY_BINARY_NAME, CHAT_BINARY_NAME
55

66

77
class CdSigningType(Enum):
@@ -52,21 +52,21 @@ def manifest(
5252

5353
def app_manifest():
5454
return manifest(
55-
name="Amazon Q.app",
55+
name=f"{APP_NAME}.app",
5656
identifier="com.amazon.codewhisperer",
5757
entitlements=True,
5858
embedded_requirements=[
5959
EmbeddedRequirement(
60-
path="Contents/MacOS/q",
61-
identifier="com.amazon.q",
60+
path=f"Contents/MacOS/{CLI_BINARY_NAME}",
61+
identifier=f"com.amazon.{CLI_BINARY_NAME}",
6262
),
6363
EmbeddedRequirement(
64-
path="Contents/MacOS/qterm",
65-
identifier="com.amazon.qterm",
64+
path=f"Contents/MacOS/{PTY_BINARY_NAME}",
65+
identifier=f"com.amazon.{PTY_BINARY_NAME}",
6666
),
6767
EmbeddedRequirement(
68-
path="Contents/MacOS/qchat",
69-
identifier="com.amazon.qchat",
68+
path=f"Contents/MacOS/{CHAT_BINARY_NAME}",
69+
identifier=f"com.amazon.{CHAT_BINARY_NAME}",
7070
),
7171
],
7272
)

0 commit comments

Comments
 (0)