remove cloudshell special casing (#156)

Author: chaynabors

crates/chat-cli/src/api_client/clients/shared.rs

@@ -8,11 +8,7 @@ use aws_credential_types::provider::ProvideCredentials;
 use aws_types::SdkConfig;
 use aws_types::sdk_config::StalledStreamProtectionConfig;
 
-use crate::api_client::credentials::CredentialsChain;
-use crate::api_client::{
-    ApiClientError,
-    Endpoint,
-};
+use crate::api_client::Endpoint;
 use crate::aws_common::behavior_version;
 use crate::database::Database;
 use crate::database::settings::Setting;
@@ -59,13 +55,3 @@ pub async fn bearer_sdk_config(database: &Database, endpoint: &Endpoint) -> SdkC
     let credentials = Credentials::new("xxx", "xxx", None, None, "xxx");
     base_sdk_config(database, endpoint.region().clone(), credentials).await
 }
-
-pub async fn sigv4_sdk_config(database: &Database, endpoint: &Endpoint) -> Result<SdkConfig, ApiClientError> {
-    let credentials_chain = CredentialsChain::new().await;
-
-    if let Err(err) = credentials_chain.provide_credentials().await {
-        return Err(ApiClientError::Credentials(err));
-    };
-
-    Ok(base_sdk_config(database, endpoint.region().clone(), credentials_chain).await)
-}

crates/chat-cli/src/api_client/clients/streaming_client.rs

@@ -4,7 +4,6 @@ use std::sync::{
 };
 
 use amzn_codewhisperer_streaming_client::Client as CodewhispererStreamingClient;
-use amzn_qdeveloper_streaming_client::Client as QDeveloperStreamingClient;
 use aws_types::request_id::RequestId;
 use tracing::{
     debug,
@@ -13,7 +12,6 @@ use tracing::{
 
 use super::shared::{
     bearer_sdk_config,
-    sigv4_sdk_config,
     stalled_stream_protection_config,
 };
 use crate::api_client::interceptor::opt_out::OptOutInterceptor;
@@ -42,14 +40,12 @@ mod inner {
     };
 
     use amzn_codewhisperer_streaming_client::Client as CodewhispererStreamingClient;
-    use amzn_qdeveloper_streaming_client::Client as QDeveloperStreamingClient;
 
     use crate::api_client::model::ChatResponseStream;
 
     #[derive(Clone, Debug)]
     pub enum Inner {
         Codewhisperer(CodewhispererStreamingClient),
-        QDeveloper(QDeveloperStreamingClient),
         Mock(Arc<Mutex<std::vec::IntoIter<Vec<ChatResponseStream>>>>),
     }
 }
@@ -62,15 +58,7 @@ pub struct StreamingClient {
 
 impl StreamingClient {
     pub async fn new(database: &mut Database) -> Result<Self, ApiClientError> {
-        Ok(
-            if crate::util::system_info::in_cloudshell()
-                || std::env::var("Q_USE_SENDMESSAGE").is_ok_and(|v| !v.is_empty())
-            {
-                Self::new_qdeveloper_client(database, &Endpoint::load_q(database)).await?
-            } else {
-                Self::new_codewhisperer_client(database, &Endpoint::load_codewhisperer(database)).await?
-            },
-        )
+        Self::new_codewhisperer_client(database, &Endpoint::load_codewhisperer(database)).await
     }
 
     pub fn mock(events: Vec<Vec<ChatResponseStream>>) -> Self {
@@ -108,24 +96,6 @@ impl StreamingClient {
         Ok(Self { inner, profile })
     }
 
-    pub async fn new_qdeveloper_client(database: &Database, endpoint: &Endpoint) -> Result<Self, ApiClientError> {
-        let conf_builder: amzn_qdeveloper_streaming_client::config::Builder =
-            (&sigv4_sdk_config(database, endpoint).await?).into();
-        let conf = conf_builder
-            .http_client(crate::aws_common::http_client::client())
-            .interceptor(OptOutInterceptor::new(database))
-            .interceptor(UserAgentOverrideInterceptor::new())
-            .app_name(app_name())
-            .endpoint_url(endpoint.url())
-            .stalled_stream_protection(stalled_stream_protection_config())
-            .build();
-        let client = QDeveloperStreamingClient::from_conf(conf);
-        Ok(Self {
-            inner: inner::Inner::QDeveloper(client),
-            profile: None,
-        })
-    }
-
     pub async fn send_message(
         &self,
         conversation_state: ConversationState,
@@ -180,27 +150,6 @@ impl StreamingClient {
                     },
                 }
             },
-            inner::Inner::QDeveloper(client) => {
-                let conversation_state_builder = amzn_qdeveloper_streaming_client::types::ConversationState::builder()
-                    .set_conversation_id(conversation_id)
-                    .current_message(amzn_qdeveloper_streaming_client::types::ChatMessage::UserInputMessage(
-                        user_input_message.into(),
-                    ))
-                    .chat_trigger_type(amzn_qdeveloper_streaming_client::types::ChatTriggerType::Manual)
-                    .set_history(
-                        history
-                            .map(|v| v.into_iter().map(|i| i.try_into()).collect::<Result<Vec<_>, _>>())
-                            .transpose()?,
-                    );
-
-                Ok(SendMessageOutput::QDeveloper(
-                    client
-                        .send_message()
-                        .conversation_state(conversation_state_builder.build().expect("fix me"))
-                        .send()
-                        .await?,
-                ))
-            },
             inner::Inner::Mock(events) => {
                 let mut new_events = events.lock().unwrap().next().unwrap_or_default().clone();
                 new_events.reverse();
@@ -215,15 +164,13 @@ pub enum SendMessageOutput {
     Codewhisperer(
         amzn_codewhisperer_streaming_client::operation::generate_assistant_response::GenerateAssistantResponseOutput,
     ),
-    QDeveloper(amzn_qdeveloper_streaming_client::operation::send_message::SendMessageOutput),
     Mock(Vec<ChatResponseStream>),
 }
 
 impl SendMessageOutput {
     pub fn request_id(&self) -> Option<&str> {
         match self {
             SendMessageOutput::Codewhisperer(output) => output.request_id(),
-            SendMessageOutput::QDeveloper(output) => output.request_id(),
             SendMessageOutput::Mock(_) => None,
         }
     }
@@ -235,7 +182,6 @@ impl SendMessageOutput {
                 .recv()
                 .await?
                 .map(|s| s.into())),
-            SendMessageOutput::QDeveloper(output) => Ok(output.send_message_response.recv().await?.map(|s| s.into())),
             SendMessageOutput::Mock(vec) => Ok(vec.pop()),
         }
     }
@@ -245,7 +191,6 @@ impl RequestId for SendMessageOutput {
     fn request_id(&self) -> Option<&str> {
         match self {
             SendMessageOutput::Codewhisperer(output) => output.request_id(),
-            SendMessageOutput::QDeveloper(output) => output.request_id(),
             SendMessageOutput::Mock(_) => Some("<mock-request-id>"),
         }
     }
@@ -267,7 +212,6 @@ mod tests {
 
         let _ = StreamingClient::new(&mut database).await;
         let _ = StreamingClient::new_codewhisperer_client(&mut database, &endpoint).await;
-        let _ = StreamingClient::new_qdeveloper_client(&database, &endpoint).await;
     }
 
     #[tokio::test]

crates/chat-cli/src/api_client/consts.rs

@@ -4,9 +4,6 @@ use aws_config::Region;
 pub const PROD_CODEWHISPERER_ENDPOINT_URL: &str = "https://codewhisperer.us-east-1.amazonaws.com";
 pub const PROD_CODEWHISPERER_ENDPOINT_REGION: Region = Region::from_static("us-east-1");
 
-pub const PROD_Q_ENDPOINT_URL: &str = "https://q.us-east-1.amazonaws.com";
-pub const PROD_Q_ENDPOINT_REGION: Region = Region::from_static("us-east-1");
-
 // FRA endpoint constants
 pub const PROD_CODEWHISPERER_FRA_ENDPOINT_URL: &str = "https://q.eu-central-1.amazonaws.com/";
 pub const PROD_CODEWHISPERER_FRA_ENDPOINT_REGION: Region = Region::from_static("eu-central-1");

crates/chat-cli/src/api_client/credentials/mod.rs

@@ -9,8 +9,6 @@ use crate::api_client::consts::{
     PROD_CODEWHISPERER_ENDPOINT_URL,
     PROD_CODEWHISPERER_FRA_ENDPOINT_REGION,
     PROD_CODEWHISPERER_FRA_ENDPOINT_URL,
-    PROD_Q_ENDPOINT_REGION,
-    PROD_Q_ENDPOINT_URL,
 };
 use crate::database::Database;
 use crate::database::settings::Setting;
@@ -30,10 +28,6 @@ impl Endpoint {
         url: Cow::Borrowed(PROD_CODEWHISPERER_ENDPOINT_URL),
         region: PROD_CODEWHISPERER_ENDPOINT_REGION,
     };
-    pub const PROD_Q: Self = Self {
-        url: Cow::Borrowed(PROD_Q_ENDPOINT_URL),
-        region: PROD_Q_ENDPOINT_REGION,
-    };
 
     pub fn load_codewhisperer(database: &Database) -> Self {
         let (endpoint, region) = if let Some(Value::Object(o)) = database.settings.get(Setting::ApiCodeWhispererService)
@@ -69,24 +63,6 @@ impl Endpoint {
         }
     }
 
-    pub fn load_q(database: &Database) -> Self {
-        match database.settings.get(Setting::ApiQService) {
-            Some(Value::Object(o)) => {
-                let endpoint = o.get("endpoint").and_then(|v| v.as_str());
-                let region = o.get("region").and_then(|v| v.as_str());
-
-                match (endpoint, region) {
-                    (Some(endpoint), Some(region)) => Self {
-                        url: endpoint.to_owned().into(),
-                        region: Region::new(region.to_owned()),
-                    },
-                    _ => Endpoint::PROD_Q,
-                }
-            },
-            _ => Endpoint::PROD_Q,
-        }
-    }
-
     pub(crate) fn url(&self) -> &str {
         &self.url
     }
@@ -106,7 +82,6 @@ mod tests {
     async fn test_endpoints() {
         let database = Database::new().await.unwrap();
         let _ = Endpoint::load_codewhisperer(&database);
-        let _ = Endpoint::load_q(&database);
 
         let prod = &Endpoint::DEFAULT_ENDPOINT;
         Url::parse(prod.url()).unwrap();

crates/chat-cli/src/api_client/endpoints.rs

@@ -7,7 +7,6 @@ use amzn_consolas_client::operation::generate_recommendations::GenerateRecommend
 use amzn_consolas_client::operation::list_customizations::ListCustomizationsError;
 use amzn_qdeveloper_streaming_client::operation::send_message::SendMessageError as QDeveloperSendMessageError;
 use amzn_qdeveloper_streaming_client::types::error::ChatResponseStreamError as QDeveloperChatResponseStreamError;
-use aws_credential_types::provider::error::CredentialsError;
 use aws_smithy_runtime_api::client::orchestrator::HttpResponse;
 pub use aws_smithy_runtime_api::client::result::SdkError;
 use aws_smithy_types::event_stream::RawMessage;
@@ -18,9 +17,6 @@ use crate::aws_common::SdkErrorDisplay;
 
 #[derive(Debug, Error)]
 pub enum ApiClientError {
-    #[error("failed to load credentials: {}", .0)]
-    Credentials(CredentialsError),
-
     // Generate completions errors
     #[error("{}", SdkErrorDisplay(.0))]
     GenerateCompletions(#[from] SdkError<GenerateCompletionsError, HttpResponse>),
@@ -87,7 +83,6 @@ mod tests {
 
     fn all_errors() -> Vec<ApiClientError> {
         vec![
-            ApiClientError::Credentials(CredentialsError::unhandled("<unhandled>")),
             ApiClientError::GenerateCompletions(SdkError::service_error(
                 GenerateCompletionsError::unhandled("<unhandled>"),
                 response(),

crates/chat-cli/src/api_client/error.rs

@@ -1,6 +1,5 @@
 pub mod clients;
 pub(crate) mod consts;
-pub(crate) mod credentials;
 pub mod customization;
 mod endpoints;
 mod error;

crates/chat-cli/src/api_client/mod.rs

@@ -141,7 +141,6 @@ use util::{
     animate_output,
     drop_matched_context_files,
     play_notification_bell,
-    region_check,
 };
 use uuid::Uuid;
 use winnow::Partial;
@@ -166,7 +165,6 @@ use crate::telemetry::{
     TelemetryResult,
     TelemetryThread,
 };
-use crate::util::CLI_BINARY_NAME;
 
 #[derive(Debug, Clone, PartialEq, Eq, Default, Args)]
 pub struct ChatArgs {
@@ -197,15 +195,6 @@ pub struct ChatArgs {
 
 impl ChatArgs {
     pub async fn execute(self, database: &mut Database, telemetry: &TelemetryThread) -> Result<ExitCode> {
-        if !crate::util::system_info::in_cloudshell() && !crate::auth::is_logged_in(database).await {
-            bail!(
-                "You are not logged in, please log in with {}",
-                format!("{CLI_BINARY_NAME} login").bold()
-            );
-        }
-
-        region_check("chat")?;
-
         let ctx = Context::new();
 
         let stdin = std::io::stdin();

crates/chat-cli/src/cli/chat/mod.rs

@@ -14,21 +14,6 @@ use eyre::Result;
 
 use super::ChatError;
 use super::token_counter::TokenCounter;
-use crate::util::system_info::in_cloudshell;
-
-const GOV_REGIONS: &[&str] = &["us-gov-east-1", "us-gov-west-1"];
-
-pub fn region_check(capability: &'static str) -> eyre::Result<()> {
-    let Ok(region) = std::env::var("AWS_REGION") else {
-        return Ok(());
-    };
-
-    if in_cloudshell() && GOV_REGIONS.contains(&region.as_str()) {
-        eyre::bail!("AWS GovCloud ({region}) is not supported for {capability}.");
-    }
-
-    Ok(())
-}
 
 pub fn truncate_safe(s: &str, max_bytes: usize) -> &str {
     if s.len() <= max_bytes {