Skip to content

Commit c0f0e19

Browse files
committed
Fixes to successfully create binary
1 parent a77bc8b commit c0f0e19

File tree

36 files changed

+81
-62
lines changed

36 files changed

+81
-62
lines changed

build-config/buildspec-macos_aarch64.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,11 @@ phases:
1212
commands:
1313
- export AWS_MAX_ATTEMPTS=10
1414
- echo "path - $PATH"
15+
- echo "user - $(whoami)"
1516
- AWS_ACCOUNT=`aws sts get-caller-identity | jq -r '.Account'`
1617
# For now assume there is a suitable EC2 instance running. Obviously, we could add a StepFunction here to
1718
# get a new one, but this is a start
18-
- INSTANCE_ID=`aws ec2 describe-instances --filters "Name=tag:Name,Values=FigIoDesktop MacOS aarch64 Build Server 1" "Name=instance-state-name,Values=running" | jq -r '.Reservations[0].Instances[0].InstanceId'`
19+
- INSTANCE_ID=`aws ec2 describe-instances --filters "Name=tag:Name,Values=FigIoDesktop MacOS aarch64 Build Server V2" "Name=instance-state-name,Values=running" | jq -r '.Reservations[0].Instances[0].InstanceId'`
1920
- echo "ec2 instance id - $INSTANCE_ID"
2021
# The name of the SSM document has to change every time its deployed, so go look for it
2122
# We can make this an environment variable passed into CodeBuild.
@@ -36,6 +37,7 @@ phases:
3637
# TODO(grant): change bucket name to env var
3738
- aws s3 cp --recursive s3://fig-io-desktop-build-output-$AWS_ACCOUNT-$AWS_REGION/staging .
3839
- aws s3 rm --recursive s3://fig-io-desktop-build-output-$AWS_ACCOUNT-$AWS_REGION/staging
40+
- ls -la
3941

4042
artifacts:
4143
files:
Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
type: :app # no need to change this for .pkg, .dmg and executables
22
os: :osx
3-
name: Amazon Q.app
3+
name: Kiro-Cli.app
44
outputs:
55
- label: macos
6-
path: Amazon Q.app
6+
path: Kiro-Cli.app
77
app:
88
:identifier: com.amazon.codewhisperer # this has to be same as Bundle identifier value in info.plist
99
signing_requirements:
@@ -12,9 +12,9 @@ app:
1212
signing_args:
1313
entitlements_path: SIGNING_METADATA/entitlements.plist
1414
embedded_requirements:
15-
Contents/MacOS/q:
16-
:identifier: com.amazon.q
15+
Contents/MacOS/kiro-cli:
16+
:identifier: com.amazon.kiro-cli
1717
signing_args:
18-
Contents/MacOS/qterm:
19-
:identifier: com.amazon.qterm
18+
Contents/MacOS/kiro-cli-term:
19+
:identifier: com.amazon.kiro-cli-term
2020
signing_args:

build-scripts/build-macos.sh

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,9 +50,8 @@ done
5050
export CARGO_HOME="$PWD/../.cargo"
5151
RUSTUP_HOME="$PWD/../.rustup"
5252

53-
# TODO: reenable once mise fixes http issues
54-
# mise install --verbose
55-
# eval "$(mise activate bash --shims)"
53+
mise install --verbose
54+
eval "$(mise activate bash --shims)"
5655

5756
# clean up old install
5857
rm -rf "$CARGO_HOME"

build-scripts/build.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,7 @@
5353
PTY_BINARY_NAME,
5454
PTY_PACKAGE_NAME,
5555
URL_SCHEMA,
56+
CHAT_BINARY_BRANCH,
5657
)
5758

5859
BUILD_DIR_RELATIVE = pathlib.Path(os.environ.get("BUILD_DIR") or "build")
@@ -208,7 +209,7 @@ def fetch_chat_bin(chat_build_bucket_name: str | None, chat_download_role_arn: s
208209
# The path to the download should be:
209210
# BUILD_BUCKET/prod/latest/{target}/kiro-cli-chat.zip
210211
target = get_target_triple()
211-
chat_bucket_path = f"prod/latest/{target}/{CHAT_BINARY_NAME}.zip"
212+
chat_bucket_path = f"{CHAT_BINARY_BRANCH}/latest/{target}/{CHAT_BINARY_NAME}.zip"
212213
chat_dl_dir = BUILD_DIR / "chat_download"
213214
chat_dl_dir.mkdir(exist_ok=True)
214215
chat_dl_path = chat_dl_dir / f"{CHAT_BINARY_NAME}.zip"

build-scripts/const.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
URL_SCHEMA = "kiro-cli"
1010
TAURI_PRODUCT_NAME = "kiro_cli_desktop"
1111
LINUX_PACKAGE_NAME = "kiro-cli"
12+
CHAT_BINARY_BRANCH = "qv2"
1213

1314
# macos specific
1415
MACOS_BUNDLE_ID = "com.amazon.codewhisperer"

bundle/deb/control

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
Package: amazon-q
1+
Package: kiro-cli
22
Description: Amazon Q CLI for Linux
33
Maintainer: Amazon Q CLI Team <[email protected]>
44
Homepage: https://github.com/aws/q-cli
55
Version: $VERSION
66
Architecture: $APT_ARCH
7-
Conflicts: amazon-q-minimal
7+
Conflicts: kiro-cli-minimal
88
Depends: libayatana-appindicator3-1, libwebkit2gtk-4.1-0, libgtk-3-0, util-linux

bundle/deb/control_minimal

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
Package: amazon-q-minimal
1+
Package: kiro-cli-minimal
22
Description: Amazon Q CLI for Linux
33
Maintainer: Amazon Q CLI Team <[email protected]>
44
Homepage: https://github.com/aws/q-cli
55
Version: $VERSION
66
Architecture: $APT_ARCH
7-
Conflicts: amazon-q
7+
Conflicts: kiro-cli

bundle/deb/postrm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
#!/bin/bash
22

3-
killall q-desktop || true
3+
killall kiro-cli-desktop || true

bundle/linux/install.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@ if [ -n "${Q_INSTALL_GLOBAL:-}" ]; then
143143
install -m 755 "$SCRIPT_DIR/bin/$CHAT_BINARY_NAME" /usr/local/bin/
144144
install -m 755 "$SCRIPT_DIR/bin/$PTY_BINARY_NAME" /usr/local/bin/
145145

146-
if [ -z "${Q_SKIP_SETUP:-}" ]; then
146+
if [ -z "${KIRO_CLI_SKIP_SETUP:-}" ]; then
147147
/usr/local/bin/q integrations install dotfiles
148148
/usr/local/bin/q setup --global "$@"
149149
fi
@@ -154,7 +154,7 @@ else
154154
install -m 755 "$SCRIPT_DIR/bin/$CHAT_BINARY_NAME" "$HOME/.local/bin/"
155155
install -m 755 "$SCRIPT_DIR/bin/$PTY_BINARY_NAME" "$HOME/.local/bin/"
156156

157-
if [ -z "${Q_SKIP_SETUP:-}" ]; then
157+
if [ -z "${KIRO_CLI_SKIP_SETUP:-}" ]; then
158158
"$HOME/.local/bin/q" setup "$@"
159159
fi
160160
fi

crates/chat-cli/src/cli/chat/context.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -251,6 +251,7 @@ impl ContextManager {
251251
///
252252
/// # Returns
253253
/// A Result containing a vector of profile names, with "default" always first
254+
#[cfg_attr(target_os = "windows", allow(dead_code))]
254255
pub fn list_profiles_blocking(&self, os: &Os) -> Result<Vec<String>> {
255256
let _ = self;
256257

0 commit comments

Comments
 (0)