Skip to content

Commit e325a1d

Browse files
committed
fix(shell): suppress shellcheck SC2329 warning for __bp_adjust_histcontrol
Add SC2329 to the existing shellcheck disable comment for the __bp_adjust_histcontrol function in bash-preexec.sh. This function appears unused to shellcheck because it's overridden by a stub function, but it's actually called from within the __bp_install function. Fixes failing init lint tests for bash shell integrations. 🤖 Assisted by Amazon Q Developer
1 parent 3eb52b7 commit e325a1d

File tree

5 files changed

+9
-9
lines changed

5 files changed

+9
-9
lines changed

crates/fig_integrations/src/shell/scripts/bash-preexec.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ __bp_require_not_readonly() {
8888
# Remove ignorespace and or replace ignoreboth from HISTCONTROL
8989
# so we can accurately invoke preexec with a command from our
9090
# history even if it starts with a space.
91-
# shellcheck disable=SC2317
91+
# shellcheck disable=SC2317,SC2329
9292
__bp_adjust_histcontrol() {
9393
local histcontrol
9494
histcontrol="${HISTCONTROL:-}"

crates/q_cli/tests/snapshots/init__init_snapshot_bash_post_bash_profile.snap

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
---
2-
source: q_cli/tests/init.rs
2+
source: crates/q_cli/tests/init.rs
33
expression: init
44
---
55
Q_SHELL="/bin/zsh"
@@ -94,7 +94,7 @@ __bp_require_not_readonly() {
9494
# Remove ignorespace and or replace ignoreboth from HISTCONTROL
9595
# so we can accurately invoke preexec with a command from our
9696
# history even if it starts with a space.
97-
# shellcheck disable=SC2317
97+
# shellcheck disable=SC2317,SC2329
9898
__bp_adjust_histcontrol() {
9999
local histcontrol
100100
histcontrol="${HISTCONTROL:-}"

crates/q_cli/tests/snapshots/init__init_snapshot_bash_post_bashrc.snap

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
---
2-
source: q_cli/tests/init.rs
2+
source: crates/q_cli/tests/init.rs
33
expression: init
44
---
55
Q_SHELL="/bin/zsh"
@@ -94,7 +94,7 @@ __bp_require_not_readonly() {
9494
# Remove ignorespace and or replace ignoreboth from HISTCONTROL
9595
# so we can accurately invoke preexec with a command from our
9696
# history even if it starts with a space.
97-
# shellcheck disable=SC2317
97+
# shellcheck disable=SC2317,SC2329
9898
__bp_adjust_histcontrol() {
9999
local histcontrol
100100
histcontrol="${HISTCONTROL:-}"

crates/q_cli/tests/snapshots/init__init_snapshot_bash_pre_bash_profile.snap

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
---
2-
source: q_cli/tests/init.rs
2+
source: crates/q_cli/tests/init.rs
33
expression: init
44
---
55
Q_SHELL="/bin/zsh"
@@ -95,7 +95,7 @@ __bp_require_not_readonly() {
9595
# Remove ignorespace and or replace ignoreboth from HISTCONTROL
9696
# so we can accurately invoke preexec with a command from our
9797
# history even if it starts with a space.
98-
# shellcheck disable=SC2317
98+
# shellcheck disable=SC2317,SC2329
9999
__bp_adjust_histcontrol() {
100100
local histcontrol
101101
histcontrol="${HISTCONTROL:-}"

crates/q_cli/tests/snapshots/init__init_snapshot_bash_pre_bashrc.snap

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
---
2-
source: q_cli/tests/init.rs
2+
source: crates/q_cli/tests/init.rs
33
expression: init
44
---
55
Q_SHELL="/bin/zsh"
@@ -95,7 +95,7 @@ __bp_require_not_readonly() {
9595
# Remove ignorespace and or replace ignoreboth from HISTCONTROL
9696
# so we can accurately invoke preexec with a command from our
9797
# history even if it starts with a space.
98-
# shellcheck disable=SC2317
98+
# shellcheck disable=SC2317,SC2329
9999
__bp_adjust_histcontrol() {
100100
local histcontrol
101101
histcontrol="${HISTCONTROL:-}"

0 commit comments

Comments
 (0)