Adding boolean setting for history hints (#2298)

Author: raghavchawla

crates/chat-cli/src/cli/chat/prompt.rs

@@ -215,12 +215,24 @@ impl Completer for ChatCompleter {
 pub struct ChatHinter {
     /// Command history for providing suggestions based on past commands
     history: Vec<String>,
+    /// Whether history-based hints are enabled
+    history_hints_enabled: bool,
 }
 
 impl ChatHinter {
     /// Creates a new ChatHinter instance
-    pub fn new() -> Self {
-        Self { history: Vec::new() }
+    pub fn new(os: &Os) -> Self {
+        // Default to disabled if setting doesn't exist
+        let history_hints_enabled = os
+            .database
+            .settings
+            .get_bool(Setting::ChatEnableHistoryHints)
+            .unwrap_or(false);
+
+        Self {
+            history: Vec::new(),
+            history_hints_enabled,
+        }
     }
 
     /// Updates the history with a new command
@@ -245,12 +257,16 @@ impl ChatHinter {
                 .map(|cmd| cmd[line.len()..].to_string());
         }
 
-        // Try to find a hint from history
-        self.history
-            .iter()
-            .rev() // Start from most recent
-            .find(|cmd| cmd.starts_with(line) && cmd.len() > line.len())
-            .map(|cmd| cmd[line.len()..].to_string())
+        // Try to find a hint from history if history hints are enabled
+        if self.history_hints_enabled {
+            return self.history
+                .iter()
+                .rev() // Start from most recent
+                .find(|cmd| cmd.starts_with(line) && cmd.len() > line.len())
+                .map(|cmd| cmd[line.len()..].to_string());
+        }
+
+        None
     }
 }
 
@@ -368,7 +384,7 @@ pub fn rl(
         .build();
     let h = ChatHelper {
         completer: ChatCompleter::new(sender, receiver),
-        hinter: ChatHinter::new(),
+        hinter: ChatHinter::new(os),
         validator: MultiLineValidator,
     };
     let mut rl = Editor::with_config(config)?;
@@ -401,6 +417,28 @@ mod tests {
     use rustyline::highlight::Highlighter;
 
     use super::*;
+    use crate::database::Settings;
+    use crate::os::{
+        Fs,
+        Os,
+    };
+
+    // Helper function to create a mock Os for testing
+    fn create_mock_os() -> Os {
+        let mut os = Os {
+            database: crate::database::Database {
+                pool: r2d2::Pool::builder()
+                    .build(r2d2_sqlite::SqliteConnectionManager::memory())
+                    .unwrap(),
+                settings: Settings::default(),
+            },
+            fs: Fs::new(),
+            env: crate::os::Env::new(),
+            telemetry: crate::telemetry::Telemetry::new(),
+        };
+        os
+    }
+
     #[test]
     fn test_chat_completer_command_completion() {
         let (prompt_request_sender, _) = std::sync::mpsc::channel::<Option<String>>();
@@ -446,9 +484,10 @@ mod tests {
     fn test_highlight_prompt_basic() {
         let (prompt_request_sender, _) = std::sync::mpsc::channel::<Option<String>>();
         let (_, prompt_response_receiver) = std::sync::mpsc::channel::<Vec<String>>();
+        let mock_os = create_mock_os();
         let helper = ChatHelper {
             completer: ChatCompleter::new(prompt_request_sender, prompt_response_receiver),
-            hinter: ChatHinter::new(),
+            hinter: ChatHinter::new(&mock_os),
             validator: MultiLineValidator,
         };
 
@@ -462,9 +501,10 @@ mod tests {
     fn test_highlight_prompt_with_warning() {
         let (prompt_request_sender, _) = std::sync::mpsc::channel::<Option<String>>();
         let (_, prompt_response_receiver) = std::sync::mpsc::channel::<Vec<String>>();
+        let mock_os = create_mock_os();
         let helper = ChatHelper {
             completer: ChatCompleter::new(prompt_request_sender, prompt_response_receiver),
-            hinter: ChatHinter::new(),
+            hinter: ChatHinter::new(&mock_os),
             validator: MultiLineValidator,
         };
 
@@ -478,9 +518,10 @@ mod tests {
     fn test_highlight_prompt_with_profile() {
         let (prompt_request_sender, _) = std::sync::mpsc::channel::<Option<String>>();
         let (_, prompt_response_receiver) = std::sync::mpsc::channel::<Vec<String>>();
+        let mock_os = create_mock_os();
         let helper = ChatHelper {
             completer: ChatCompleter::new(prompt_request_sender, prompt_response_receiver),
-            hinter: ChatHinter::new(),
+            hinter: ChatHinter::new(&mock_os),
             validator: MultiLineValidator,
         };
 
@@ -494,9 +535,10 @@ mod tests {
     fn test_highlight_prompt_with_profile_and_warning() {
         let (prompt_request_sender, _) = std::sync::mpsc::channel::<Option<String>>();
         let (_, prompt_response_receiver) = std::sync::mpsc::channel::<Vec<String>>();
+        let mock_os = create_mock_os();
         let helper = ChatHelper {
             completer: ChatCompleter::new(prompt_request_sender, prompt_response_receiver),
-            hinter: ChatHinter::new(),
+            hinter: ChatHinter::new(&mock_os),
             validator: MultiLineValidator,
         };
 
@@ -513,9 +555,10 @@ mod tests {
     fn test_highlight_prompt_invalid_format() {
         let (prompt_request_sender, _) = std::sync::mpsc::channel::<Option<String>>();
         let (_, prompt_response_receiver) = std::sync::mpsc::channel::<Vec<String>>();
+        let mock_os = create_mock_os();
         let helper = ChatHelper {
             completer: ChatCompleter::new(prompt_request_sender, prompt_response_receiver),
-            hinter: ChatHinter::new(),
+            hinter: ChatHinter::new(&mock_os),
             validator: MultiLineValidator,
         };
 
@@ -527,7 +570,8 @@ mod tests {
 
     #[test]
     fn test_chat_hinter_command_hint() {
-        let hinter = ChatHinter::new();
+        let mock_os = create_mock_os();
+        let hinter = ChatHinter::new(&mock_os);
 
         // Test hint for a command
         let line = "/he";
@@ -550,14 +594,42 @@ mod tests {
     }
 
     #[test]
-    fn test_chat_hinter_history_hint() {
-        let mut hinter = ChatHinter::new();
+    fn test_chat_hinter_history_hint_disabled() {
+        let mock_os = create_mock_os();
+        let mut hinter = ChatHinter::new(&mock_os); // Default is disabled
+
+        // Add some history
+        hinter.update_history("Hello, world!");
+        hinter.update_history("How are you?");
+
+        // Test hint from history - should be None since history hints are disabled
+        let line = "How";
+        let pos = line.len();
+        let empty_history = DefaultHistory::new();
+        let ctx = Context::new(&empty_history);
+
+        let hint = hinter.hint(line, pos, &ctx);
+        assert_eq!(hint, None);
+    }
+
+    #[test]
+    fn test_chat_hinter_history_hint_enabled() {
+        let mut mock_os = create_mock_os();
+
+        // Enable history hints
+        mock_os
+            .database
+            .settings
+            .0
+            .insert("chat.enableHistoryHints".to_string(), serde_json::Value::Bool(true));
+
+        let mut hinter = ChatHinter::new(&mock_os);
 
         // Add some history
         hinter.update_history("Hello, world!");
         hinter.update_history("How are you?");
 
-        // Test hint from history
+        // Test hint from history - should work since history hints are enabled
         let line = "How";
         let pos = line.len();
         let empty_history = DefaultHistory::new();

crates/chat-cli/src/database/settings.rs

@@ -35,6 +35,7 @@ pub enum Setting {
     ChatDefaultModel,
     ChatDefaultAgent,
     ChatDisableAutoCompaction,
+    ChatEnableHistoryHints,
 }
 
 impl AsRef<str> for Setting {
@@ -58,6 +59,7 @@ impl AsRef<str> for Setting {
             Self::ChatDefaultModel => "chat.defaultModel",
             Self::ChatDefaultAgent => "chat.defaultAgent",
             Self::ChatDisableAutoCompaction => "chat.disableAutoCompaction",
+            Self::ChatEnableHistoryHints => "chat.enableHistoryHints",
         }
     }
 }
@@ -91,6 +93,7 @@ impl TryFrom<&str> for Setting {
             "chat.defaultModel" => Ok(Self::ChatDefaultModel),
             "chat.defaultAgent" => Ok(Self::ChatDefaultAgent),
             "chat.disableAutoCompaction" => Ok(Self::ChatDisableAutoCompaction),
+            "chat.enableHistoryHints" => Ok(Self::ChatEnableHistoryHints),
             _ => Err(DatabaseError::InvalidSetting(value.to_string())),
         }
     }