Fix clippy and fmt issues

Author: kkashilk

crates/chat-cli/src/cli/chat/cli/knowledge.rs

@@ -326,13 +326,9 @@ impl KnowledgeSubcommand {
 
         // Try path first, then name
         if store.remove_by_path(&sanitized_path.to_string_lossy()).await.is_ok() {
-            OperationResult::Success(format!(
-                "Removed {scope_desc} knowledge base entry with path '{path}'"
-            ))
+            OperationResult::Success(format!("Removed {scope_desc} knowledge base entry with path '{path}'"))
         } else if store.remove_by_name(path).await.is_ok() {
-            OperationResult::Success(format!(
-                "Removed {scope_desc} knowledge base entry with name '{path}'"
-            ))
+            OperationResult::Success(format!("Removed {scope_desc} knowledge base entry with name '{path}'"))
         } else {
             OperationResult::Warning(format!("Entry not found in {scope_desc} knowledge base: {path}"))
         }

crates/chat-cli/src/cli/chat/cli/prompts.rs

@@ -2500,10 +2500,7 @@ mod tests {
         let prompt_name = "test_prompt";
         let server_names = ["server1", "server2", "server3"];
 
-        let alt_names: Vec<String> = server_names
-            .iter()
-            .map(|s| format!("- @{s}/{prompt_name}"))
-            .collect();
+        let alt_names: Vec<String> = server_names.iter().map(|s| format!("- @{s}/{prompt_name}")).collect();
         let alt_msg = format!("\n{}\n", alt_names.join("\n"));
 
         assert_eq!(

crates/chat-cli/src/cli/chat/mod.rs

@@ -1747,7 +1747,7 @@ impl ChatSession {
             execute!(self.stderr, cursor::Hide, style::Print("\n"))?;
             self.spinner = Some(Spinner::new(
                 Spinners::Dots,
-                format!("Generating agent config for '{}'...", agent_name),
+                format!("Generating agent config for '{agent_name}'..."),
             ));
         }
 

crates/chat-cli/src/cli/chat/tools/delegate.rs

@@ -163,9 +163,7 @@ pub async fn launch_agent(os: &Os, agent: &str, agents: &Agents, task: &str) ->
 }
 
 fn format_launch_success(agent: &str, task: &str) -> String {
-    format!(
-        "✓ Agent '{agent}' launched successfully.\nTask: {task}\n\nUse 'status' operation to check progress."
-    )
+    format!("✓ Agent '{agent}' launched successfully.\nTask: {task}\n\nUse 'status' operation to check progress.")
 }
 
 pub fn display_agent_info(agent: &str, task: &str, config: &AgentConfig) -> Result<()> {

crates/chat-cli/src/cli/chat/tools/execute/mod.rs

@@ -695,9 +695,7 @@ mod tests {
         let user_agent_value = env_vars.get(USER_AGENT_ENV_VAR).unwrap();
 
         // Check the format is correct
-        let expected_metadata = format!(
-            "{USER_AGENT_APP_NAME} {USER_AGENT_VERSION_KEY}/{USER_AGENT_VERSION_VALUE}"
-        );
+        let expected_metadata = format!("{USER_AGENT_APP_NAME} {USER_AGENT_VERSION_KEY}/{USER_AGENT_VERSION_VALUE}");
         assert!(user_agent_value.contains(&expected_metadata));
     }
 

crates/chat-cli/src/cli/chat/tools/fs_read.rs

@@ -697,10 +697,7 @@ impl FsDirectory {
             style::Print(" "),
         )?;
         let depth = self.depth.unwrap_or_default();
-        Ok(queue!(
-            updates,
-            style::Print(format!("with maximum depth of {depth}"))
-        )?)
+        Ok(queue!(updates, style::Print(format!("with maximum depth of {depth}")))?)
     }
 
     pub async fn invoke(&self, os: &Os, updates: &mut impl Write) -> Result<InvokeOutput> {

crates/chat-cli/src/cli/chat/tools/fs_write.rs

@@ -699,23 +699,13 @@ fn print_diff(
             style::Print(sign),
             style::Print(" ")
         )?;
-        queue!(
-            output,
-            style::Print(format!(
-                "{old_i_str:>old_line_num_width$}"
-            ))
-        )?;
+        queue!(output, style::Print(format!("{old_i_str:>old_line_num_width$}")))?;
         if sign == " " {
             queue!(output, style::Print(", "))?;
         } else {
             queue!(output, style::Print("  "))?;
         }
-        queue!(
-            output,
-            style::Print(format!(
-                "{new_i_str:>new_line_num_width$}"
-            ))
-        )?;
+        queue!(output, style::Print(format!("{new_i_str:>new_line_num_width$}")))?;
         // Print the line.
         queue!(
             output,

crates/chat-cli/src/cli/chat/tools/knowledge.rs

@@ -507,9 +507,7 @@ impl Knowledge {
                         output
                     },
                     (Err(contexts_err), Err(status_err)) => {
-                        format!(
-                            "Failed to get contexts: {contexts_err}\nFailed to get status: {status_err}"
-                        )
+                        format!("Failed to get contexts: {contexts_err}\nFailed to get status: {status_err}")
                     },
                 }
             },

crates/chat-cli/src/cli/chat/tools/mod.rs

@@ -517,9 +517,8 @@ pub fn env_vars_with_user_agent(os: &Os) -> std::collections::HashMap<String, St
     let mut env_vars: std::collections::HashMap<String, String> = std::env::vars().collect();
 
     // Set up additional metadata for the AWS CLI user agent
-    let user_agent_metadata_value = format!(
-        "{USER_AGENT_APP_NAME} {USER_AGENT_VERSION_KEY}/{USER_AGENT_VERSION_VALUE}"
-    );
+    let user_agent_metadata_value =
+        format!("{USER_AGENT_APP_NAME} {USER_AGENT_VERSION_KEY}/{USER_AGENT_VERSION_VALUE}");
 
     // Check if the user agent metadata env var already exists using Os
     let existing_value = os.env.get(USER_AGENT_ENV_VAR).ok();

crates/chat-cli/src/cli/mcp.rs

@@ -408,11 +408,7 @@ impl StatusArgs {
                             "Env Vars: {}\n",
                             cfg.env.map_or_else(
                                 || "(none)".into(),
-                                |e| e
-                                    .iter()
-                                    .map(|(k, v)| format!("{k}={v}"))
-                                    .collect::<Vec<_>>()
-                                    .join(", ")
+                                |e| e.iter().map(|(k, v)| format!("{k}={v}")).collect::<Vec<_>>().join(", ")
                             )
                         )),
                     )?;