Merge branch 'main' into feed_update

Author: evanliu048

crates/chat-cli/src/cli/chat/tools/execute/mod.rs

@@ -288,7 +288,10 @@ mod tests {
     use std::collections::HashMap;
 
     use super::*;
-    use crate::cli::agent::{Agent, ToolSettingTarget};
+    use crate::cli::agent::{
+        Agent,
+        ToolSettingTarget,
+    };
 
     #[test]
     fn test_requires_acceptance_for_readonly_commands() {
@@ -620,14 +623,14 @@ mod tests {
 
     #[tokio::test]
     async fn test_eval_perm_denied_commands_invalid_regex() {
-
         let os = Os::new().await.unwrap();
+        let tool_name = if cfg!(windows) { "execute_cmd" } else { "execute_bash" };
         let agent = Agent {
             name: "test_agent".to_string(),
             tools_settings: {
                 let mut map = HashMap::<ToolSettingTarget, serde_json::Value>::new();
                 map.insert(
-                    ToolSettingTarget("execute_bash".to_string()),
+                    ToolSettingTarget(tool_name.to_string()),
                     serde_json::json!({
                         "deniedCommands": ["^(?!ls$).*"]  // Invalid regex with unsupported lookahead
                     }),
@@ -640,7 +643,11 @@ mod tests {
         // Test command that should be denied by the pattern
         let pwd_cmd = serde_json::from_value::<ExecuteCommand>(serde_json::json!({"command": "pwd",})).unwrap();
         let res = pwd_cmd.eval_perm(&os, &agent);
-        assert!(matches!(res, PermissionEvalResult::Deny(_)), "Invalid regex should deny all commands, got {:?}", res);
+        assert!(
+            matches!(res, PermissionEvalResult::Deny(_)),
+            "Invalid regex should deny all commands, got {:?}",
+            res
+        );
     }
 
     #[tokio::test]