adds output to show mcp init errors

Author: dingfeli

crates/q_cli/src/cli/chat/conversation_state.rs

@@ -614,8 +614,14 @@ mod tests {
     #[tokio::test]
     async fn test_conversation_state_history_handling_truncation() {
         let tool_manager = ToolManager::default();
-        let mut conversation_state =
-            ConversationState::new(Context::new_fake(), tool_manager.load_tools().await.unwrap(), None).await;
+        let buf = Vec::<u8>::new();
+        let mut output = std::io::BufWriter::new(buf);
+        let mut conversation_state = ConversationState::new(
+            Context::new_fake(),
+            tool_manager.load_tools(&mut output).await.unwrap(),
+            None,
+        )
+        .await;
 
         // First, build a large conversation history. We need to ensure that the order is always
         // User -> Assistant -> User -> Assistant ...and so on.
@@ -636,8 +642,14 @@ mod tests {
     async fn test_conversation_state_history_handling_with_tool_results() {
         // Build a long conversation history of tool use results.
         let tool_manager = ToolManager::default();
-        let mut conversation_state =
-            ConversationState::new(Context::new_fake(), tool_manager.load_tools().await.unwrap(), None).await;
+        let buf = Vec::<u8>::new();
+        let mut output = std::io::BufWriter::new(buf);
+        let mut conversation_state = ConversationState::new(
+            Context::new_fake(),
+            tool_manager.load_tools(&mut output).await.unwrap(),
+            None,
+        )
+        .await;
         conversation_state.append_new_user_message("start".to_string()).await;
         for i in 0..=(MAX_CONVERSATION_STATE_HISTORY_LEN + 100) {
             let s = conversation_state.as_sendable_conversation_state().await;
@@ -659,8 +671,12 @@ mod tests {
         }
 
         // Build a long conversation history of user messages mixed in with tool results.
-        let mut conversation_state =
-            ConversationState::new(Context::new_fake(), tool_manager.load_tools().await.unwrap(), None).await;
+        let mut conversation_state = ConversationState::new(
+            Context::new_fake(),
+            tool_manager.load_tools(&mut output).await.unwrap(),
+            None,
+        )
+        .await;
         conversation_state.append_new_user_message("start".to_string()).await;
         for i in 0..=(MAX_CONVERSATION_STATE_HISTORY_LEN + 100) {
             let s = conversation_state.as_sendable_conversation_state().await;
@@ -697,7 +713,10 @@ mod tests {
         ctx.fs().write(AMAZONQ_FILENAME, "test context").await.unwrap();
 
         let tool_manager = ToolManager::default();
-        let mut conversation_state = ConversationState::new(ctx, tool_manager.load_tools().await.unwrap(), None).await;
+        let buf = Vec::<u8>::new();
+        let mut output = std::io::BufWriter::new(buf);
+        let mut conversation_state =
+            ConversationState::new(ctx, tool_manager.load_tools(&mut output).await.unwrap(), None).await;
 
         // First, build a large conversation history. We need to ensure that the order is always
         // User -> Assistant -> User -> Assistant ...and so on.

crates/q_cli/src/cli/chat/mod.rs

@@ -282,7 +282,7 @@ impl<W: Write> ChatContext<W> {
     pub async fn new(
         ctx: Arc<Context>,
         settings: Settings,
-        output: W,
+        mut output: W,
         input: Option<String>,
         input_source: InputSource,
         interactive: bool,
@@ -293,9 +293,10 @@ impl<W: Write> ChatContext<W> {
         profile: Option<String>,
     ) -> Result<Self> {
         let mcp_server_config = mcp_server_config.unwrap_or_default();
-        let tool_manager = ToolManager::from_configs(mcp_server_config).await?;
+        let tool_manager = ToolManager::from_configs(mcp_server_config, &mut output).await?;
         let ctx_clone = Arc::clone(&ctx);
-        let conversation_state = ConversationState::new(ctx_clone, tool_manager.load_tools().await?, profile).await;
+        let conversation_state =
+            ConversationState::new(ctx_clone, tool_manager.load_tools(&mut output).await?, profile).await;
         Ok(Self {
             ctx,
             settings,

crates/q_cli/src/cli/chat/tool_manager.rs

@@ -10,6 +10,7 @@ use std::sync::Arc;
 
 use convert_case::Casing;
 use crossterm::{
+    execute,
     queue,
     style,
 };
@@ -98,7 +99,7 @@ pub struct ToolManager {
 }
 
 impl ToolManager {
-    pub async fn from_configs(config: McpServerConfig) -> eyre::Result<Self> {
+    pub async fn from_configs(config: McpServerConfig, output: &mut impl Write) -> eyre::Result<Self> {
         let McpServerConfig { mcp_servers } = config;
         let regex = regex::Regex::new(VALID_TOOL_NAME)?;
         let mut hasher = DefaultHasher::new();
@@ -131,14 +132,25 @@ impl ToolManager {
                     }
                 },
                 Err(e) => {
+                    execute!(
+                        output,
+                        style::SetForegroundColor(style::Color::Red),
+                        style::Print("Error"),
+                        style::ResetColor,
+                        style::Print(": Init for MCP server "),
+                        style::SetForegroundColor(style::Color::Green),
+                        style::Print(&name),
+                        style::ResetColor,
+                        style::Print(format!(" has failed: {:?}", e))
+                    )?;
                     error!("Error initializing for mcp client {}: {:?}", name, e);
                 },
             }
         }
         Ok(Self { clients })
     }
 
-    pub async fn load_tools(&self) -> eyre::Result<HashMap<String, ToolSpec>> {
+    pub async fn load_tools(&self, output: &mut impl Write) -> eyre::Result<HashMap<String, ToolSpec>> {
         let mut tool_specs = serde_json::from_str::<HashMap<String, ToolSpec>>(include_str!("tools/tool_index.json"))?;
         let load_tool = self
             .clients
@@ -169,6 +181,17 @@ impl ToolManager {
                     }
                 },
                 Err(e) => {
+                    execute!(
+                        output,
+                        style::SetForegroundColor(style::Color::Red),
+                        style::Print("Error"),
+                        style::ResetColor,
+                        style::Print(": Failed to obtain tool specs for "),
+                        style::SetForegroundColor(style::Color::Green),
+                        style::Print(&server_name),
+                        style::ResetColor,
+                        style::Print(format!(": {:?}", e))
+                    )?;
                     error!("Error obtaining tool spec for {}: {:?}", server_name, e);
                 },
             }