fix: 🔧 Improve glibc version detection in install.sh (#851)

Enhanced the glibc version detection with multiple fallback methods:
- Added dedicated function to check if glibc version is sufficient
- Implemented three detection methods (direct library check, ldd, getconf)
- Added support for ARM64 architecture by checking additional library paths
- Made error messages more informative with dynamic version requirements
- Fixed parameter passing to allow setup command to receive arguments

These changes improve reliability of installation across different Linux distributions and architectures.

Author: jsamuel1

bundle/linux/install.sh

@@ -56,37 +56,72 @@ is_target_triple_gnu() {
     fi
 }
 
-# checks that the system has atleast glibc 2.34
-check_glibc_version() {
-    if [ -f /lib64/libc.so.6 ]; then
-        LIBC_PATH=/lib64/libc.so.6
-    elif [ -f /lib/libc.so.6 ]; then
-        LIBC_PATH=/lib/libc.so.6
-    elif [ -f /usr/lib/x86_64-linux-gnu/libc.so.6 ]; then
-        LIBC_PATH=/usr/lib/x86_64-linux-gnu/libc.so.6
+# Minimum required glibc version
+GLIBC_MIN_MAJOR=2
+GLIBC_MIN_MINOR=34
+
+# Check if a glibc version meets the minimum requirement
+is_glibc_version_sufficient() {
+    local version="$1"
+    local major minor
+
+    IFS='.' read -r major minor <<EOF
+$version
+EOF
+    if [ -z "$minor" ]; then
+        minor=0
+    fi
+
+    if [ "$major" -gt "$GLIBC_MIN_MAJOR" ] || { [ "$major" -eq "$GLIBC_MIN_MAJOR" ] && [ "$minor" -ge "$GLIBC_MIN_MINOR" ]; }; then
+        return 0
     else
-        log_error "Could not find glibc."
         return 1
     fi
+}
 
-    glibc_version=$("$LIBC_PATH" | sed -n 's/^GNU C Library (.*) stable release version \([0-9]*\)\.\([0-9]*\).*$/\1.\2/p')
-
-    if [ -z "$glibc_version" ]; then
-        log_error "Could not determine glibc version."
-        return 1
-    else
-        IFS='.' read -r major minor << EOF
-$glibc_version
-EOF
-        if [ -z "$minor" ]; then
-            minor=0
+# checks that the system has at least glibc 2.34
+check_glibc_version() {
+    # Method 1: Original approach - try common libc.so.6 locations
+    for LIBC_PATH in /lib64/libc.so.6 /lib/libc.so.6 /usr/lib/x86_64-linux-gnu/libc.so.6 \
+        /lib/aarch64-linux-gnu/libc.so.6; do
+        if [ -f "$LIBC_PATH" ]; then
+            glibc_version=$("$LIBC_PATH" | sed -n 's/^GNU C Library (.*) stable release version \([0-9]*\)\.\([0-9]*\).*$/\1.\2/p')
+            if [ -n "$glibc_version" ]; then
+                if is_glibc_version_sufficient "$glibc_version"; then
+                    return 0
+                else
+                    return 1
+                fi
+            fi
         fi
-        if [ "$major" -gt 2 ] || { [ "$major" -eq 2 ] && [ "$minor" -ge 34 ]; }; then
-            return 0
-        else
-            return 1
+    done
+
+    # Method 2: Try ldd --version as a more reliable alternative
+    if command -v ldd >/dev/null 2>&1; then
+        glibc_version=$(ldd --version 2>/dev/null | head -n 1 | grep -o '[0-9]\+\.[0-9]\+' | head -n 1)
+        if [ -n "$glibc_version" ]; then
+            if is_glibc_version_sufficient "$glibc_version"; then
+                return 0
+            else
+                return 1
+            fi
         fi
     fi
+
+    # Method 3: Try getconf as a fallback
+    if command -v getconf >/dev/null 2>&1; then
+        glibc_version=$(getconf GNU_LIBC_VERSION 2>/dev/null | awk '{print $2}')
+        if [ -n "$glibc_version" ]; then
+            if is_glibc_version_sufficient "$glibc_version"; then
+                return 0
+            else
+                return 1
+            fi
+        fi
+    fi
+
+    log_error "Could not determine glibc version. This CLI requires glibc $GLIBC_MIN_MAJOR.$GLIBC_MIN_MINOR or newer."
+    return 1
 }
 
 # checks that uname matches the target triple
@@ -96,7 +131,7 @@ if [ "$(uname)" != "$(target_triple_uname)" ]; then
 fi
 
 if is_target_triple_gnu && ! check_glibc_version; then
-    log_error "This release built for a GNU system with glibc 2.34 or newer, try installing the musl version of the CLI."
+    log_error "This release built for a GNU system with glibc $GLIBC_MIN_MAJOR.$GLIBC_MIN_MINOR or newer, try installing the musl version of the CLI."
     exit 1
 fi
 
@@ -105,12 +140,12 @@ if [ -n "${Q_INSTALL_GLOBAL:-}" ]; then
     install -m 755 "$SCRIPT_DIR/bin/qterm" /usr/local/bin/
 
     /usr/local/bin/q integrations install dotfiles
-    /usr/local/bin/q setup --global
+    /usr/local/bin/q setup --global "$@"
 else
     mkdir -p "$HOME/.local/bin"
 
     install -m 755 "$SCRIPT_DIR/bin/q" "$HOME/.local/bin/"
     install -m 755 "$SCRIPT_DIR/bin/qterm" "$HOME/.local/bin/"
 
-    "$HOME/.local/bin/q" setup
+    "$HOME/.local/bin/q" setup "$@"
 fi