feat: added similar feature gating of tangent to tangent mode and introspect tool (#2720)

Author: abhraina-aws

crates/chat-cli/src/cli/chat/cli/mod.rs

@@ -89,7 +89,9 @@ pub enum SlashCommand {
     Experiment(ExperimentArgs),
     /// Upgrade to a Q Developer Pro subscription for increased query limits
     Subscribe(SubscribeArgs),
-    /// Toggle tangent mode for isolated conversations
+    /// (Beta) Toggle tangent mode for isolated conversations. Requires "q settings
+    /// chat.enableTangentMode true"
+    #[command(hide = true)]
     Tangent(TangentArgs),
     #[command(flatten)]
     Persist(PersistSubcommand),

crates/chat-cli/src/cli/chat/cli/tangent.rs

@@ -10,13 +10,31 @@ use crate::cli::chat::{
     ChatSession,
     ChatState,
 };
+use crate::database::settings::Setting;
 use crate::os::Os;
 
 #[derive(Debug, PartialEq, Args)]
 pub struct TangentArgs;
 
 impl TangentArgs {
     pub async fn execute(self, os: &Os, session: &mut ChatSession) -> Result<ChatState, ChatError> {
+        // Check if tangent mode is enabled
+        if !os
+            .database
+            .settings
+            .get_bool(Setting::EnabledTangentMode)
+            .unwrap_or(false)
+        {
+            execute!(
+                session.stderr,
+                style::SetForegroundColor(Color::Red),
+                style::Print("\nTangent mode is disabled. Enable it with: q settings chat.enableTangentMode true\n"),
+                style::SetForegroundColor(Color::Reset)
+            )?;
+            return Ok(ChatState::PromptUser {
+                skip_printing_tools: true,
+            });
+        }
         if session.conversation.is_in_tangent_mode() {
             // Get duration before exiting tangent mode
             let duration_seconds = session.conversation.get_tangent_duration_seconds().unwrap_or(0);

crates/chat-cli/src/cli/chat/mod.rs

@@ -2092,8 +2092,13 @@ impl ChatSession {
         if os
             .database
             .settings
-            .get_bool(Setting::IntrospectTangentMode)
+            .get_bool(Setting::EnabledTangentMode)
             .unwrap_or(false)
+            && os
+                .database
+                .settings
+                .get_bool(Setting::IntrospectTangentMode)
+                .unwrap_or(false)
             && !self.conversation.is_in_tangent_mode()
             && self
                 .tool_uses

crates/chat-cli/src/cli/chat/tools/introspect.rs

@@ -104,8 +104,13 @@ impl Introspect {
         if os
             .database
             .settings
-            .get_bool(Setting::IntrospectTangentMode)
+            .get_bool(Setting::EnabledTangentMode)
             .unwrap_or(false)
+            && os
+                .database
+                .settings
+                .get_bool(Setting::IntrospectTangentMode)
+                .unwrap_or(false)
         {
             let tangent_key_char = os
                 .database

crates/chat-cli/src/database/settings.rs

@@ -41,6 +41,8 @@ pub enum Setting {
     KnowledgeIndexType,
     #[strum(message = "Key binding for fuzzy search command (single character)")]
     SkimCommandKey,
+    #[strum(message = "Enable tangent mode feature (boolean)")]
+    EnabledTangentMode,
     #[strum(message = "Key binding for tangent mode toggle (single character)")]
     TangentModeKey,
     #[strum(message = "Auto-enter tangent mode for introspect questions (boolean)")]
@@ -90,6 +92,7 @@ impl AsRef<str> for Setting {
             Self::KnowledgeChunkOverlap => "knowledge.chunkOverlap",
             Self::KnowledgeIndexType => "knowledge.indexType",
             Self::SkimCommandKey => "chat.skimCommandKey",
+            Self::EnabledTangentMode => "chat.enableTangentMode",
             Self::TangentModeKey => "chat.tangentModeKey",
             Self::IntrospectTangentMode => "introspect.tangentMode",
             Self::ChatGreetingEnabled => "chat.greeting.enabled",
@@ -133,6 +136,7 @@ impl TryFrom<&str> for Setting {
             "knowledge.chunkOverlap" => Ok(Self::KnowledgeChunkOverlap),
             "knowledge.indexType" => Ok(Self::KnowledgeIndexType),
             "chat.skimCommandKey" => Ok(Self::SkimCommandKey),
+            "chat.enableTangentMode" => Ok(Self::EnabledTangentMode),
             "chat.tangentModeKey" => Ok(Self::TangentModeKey),
             "introspect.tangentMode" => Ok(Self::IntrospectTangentMode),
             "chat.greeting.enabled" => Ok(Self::ChatGreetingEnabled),