fix: make todo lists an experimental feature (#2740)

Author: kiran-garre

crates/chat-cli/src/cli/chat/cli/experiment.rs

@@ -12,6 +12,7 @@ use crossterm::{
 };
 use dialoguer::Select;
 
+use crate::cli::chat::conversation::format_tool_spec;
 use crate::cli::chat::{
     ChatError,
     ChatSession,
@@ -44,6 +45,11 @@ static AVAILABLE_EXPERIMENTS: &[Experiment] = &[
         description: "Enables entering into a temporary mode for sending isolated conversations (/tangent)",
         setting_key: Setting::EnabledTangentMode,
     },
+    Experiment {
+        name: "Todo Lists",
+        description: "Enables Q to create todo lists that can be viewed and managed using /todos",
+        setting_key: Setting::EnabledTodoList,
+    },
 ];
 
 #[derive(Debug, PartialEq, Args)]
@@ -135,11 +141,14 @@ async fn select_experiment(os: &mut Os, session: &mut ChatSession) -> Result<Opt
             .map_err(|e| ChatError::Custom(format!("Failed to update experiment setting: {e}").into()))?;
 
         // Reload tools to reflect the experiment change
-        let _ = session
+        let tools = session
             .conversation
             .tool_manager
             .load_tools(os, &mut session.stderr)
-            .await;
+            .await
+            .map_err(|e| ChatError::Custom(format!("Failed to update tool spec: {e}").into()))?;
+
+        session.conversation.tools = format_tool_spec(tools);
 
         let status_text = if new_state { "enabled" } else { "disabled" };
 

crates/chat-cli/src/cli/chat/cli/todos.rs

@@ -8,6 +8,7 @@ use dialoguer::Select;
 use eyre::Result;
 
 use crate::cli::chat::tools::todo::{
+    TodoList,
     TodoListState,
     delete_todo,
     get_all_todos,
@@ -65,6 +66,18 @@ impl std::fmt::Display for TodoDisplayEntry {
 
 impl TodoSubcommand {
     pub async fn execute(self, os: &mut Os, session: &mut ChatSession) -> Result<ChatState, ChatError> {
+        // Check if todo lists are enabled
+        if !TodoList::is_enabled(os) {
+            execute!(
+                session.stderr,
+                style::SetForegroundColor(style::Color::Red),
+                style::Print("Todo lists are disabled. Enable them with: q settings chat.enableTodoList true\n"),
+                style::SetForegroundColor(style::Color::Reset)
+            )?;
+            return Ok(ChatState::PromptUser {
+                skip_printing_tools: true,
+            });
+        }
         TodoListState::init_dir(os)
             .await
             .map_err(|e| ChatError::Custom(format!("Could not create todos directory: {e}").into()))?;

crates/chat-cli/src/cli/chat/conversation.rs

@@ -188,19 +188,7 @@ impl ConversationState {
             history: VecDeque::new(),
             valid_history_range: Default::default(),
             transcript: VecDeque::with_capacity(MAX_CONVERSATION_STATE_HISTORY_LEN),
-            tools: tool_config
-                .into_values()
-                .fold(HashMap::<ToolOrigin, Vec<Tool>>::new(), |mut acc, v| {
-                    let tool = Tool::ToolSpecification(ToolSpecification {
-                        name: v.name,
-                        description: v.description,
-                        input_schema: v.input_schema.into(),
-                    });
-                    acc.entry(v.tool_origin)
-                        .and_modify(|tools| tools.push(tool.clone()))
-                        .or_insert(vec![tool]);
-                    acc
-                }),
+            tools: format_tool_spec(tool_config),
             context_manager,
             tool_manager,
             context_message_length: None,
@@ -854,6 +842,22 @@ Return only the JSON configuration, no additional text.",
     }
 }
 
+pub fn format_tool_spec(tool_spec: HashMap<String, ToolSpec>) -> HashMap<ToolOrigin, Vec<Tool>> {
+    tool_spec
+        .into_values()
+        .fold(HashMap::<ToolOrigin, Vec<Tool>>::new(), |mut acc, v| {
+            let tool = Tool::ToolSpecification(ToolSpecification {
+                name: v.name,
+                description: v.description,
+                input_schema: v.input_schema.into(),
+            });
+            acc.entry(v.tool_origin)
+                .and_modify(|tools| tools.push(tool.clone()))
+                .or_insert(vec![tool]);
+            acc
+        })
+}
+
 /// Represents a conversation state that can be converted into a [FigConversationState] (the type
 /// used by the API client). Represents borrowed data, and reflects an exact [FigConversationState]
 /// that can be generated from [ConversationState] at any point in time.

crates/chat-cli/src/cli/chat/tool_manager.rs

@@ -650,6 +650,9 @@ impl ToolManager {
             if !crate::cli::chat::tools::knowledge::Knowledge::is_enabled(os) {
                 tool_specs.remove("knowledge");
             }
+            if !crate::cli::chat::tools::todo::TodoList::is_enabled(os) {
+                tool_specs.remove("todo_list");
+            }
 
             #[cfg(windows)]
             {

crates/chat-cli/src/cli/chat/tools/mod.rs

@@ -58,7 +58,7 @@ use crate::cli::chat::line_tracker::FileLineTracker;
 use crate::os::Os;
 
 pub const DEFAULT_APPROVE: [&str; 1] = ["fs_read"];
-pub const NATIVE_TOOLS: [&str; 7] = [
+pub const NATIVE_TOOLS: [&str; 8] = [
     "fs_read",
     "fs_write",
     #[cfg(windows)]
@@ -69,6 +69,7 @@ pub const NATIVE_TOOLS: [&str; 7] = [
     "gh_issue",
     "knowledge",
     "thinking",
+    "todo_list",
 ];
 
 /// Represents an executable tool use.

crates/chat-cli/src/cli/chat/tools/todo.rs

@@ -24,6 +24,7 @@ use serde::{
 };
 
 use super::InvokeOutput;
+use crate::database::settings::Setting;
 use crate::os::Os;
 
 #[derive(Debug, Default, Serialize, Deserialize, Clone)]
@@ -213,7 +214,23 @@ pub enum TodoList {
 }
 
 impl TodoList {
+    /// Checks if todo lists are enabled
+    pub fn is_enabled(os: &Os) -> bool {
+        os.database.settings.get_bool(Setting::EnabledTodoList).unwrap_or(false)
+    }
+
     pub async fn invoke(&self, os: &Os, output: &mut impl Write) -> Result<InvokeOutput> {
+        if !Self::is_enabled(os) {
+            queue!(
+                output,
+                style::SetForegroundColor(style::Color::Red),
+                style::Print("Todo lists are disabled. Enable them with: q settings chat.enableTodoList true"),
+                style::SetForegroundColor(style::Color::Reset)
+            )?;
+            return Ok(InvokeOutput {
+                output: super::OutputKind::Text("Todo lists are disabled.".to_string()),
+            });
+        }
         if let Some(id) = self.get_id() {
             if !os.fs.exists(id_to_path(os, &id)?) {
                 let error_string = "No todo list exists with the given ID";

crates/chat-cli/src/database/settings.rs

@@ -75,6 +75,8 @@ pub enum Setting {
     ChatDisableAutoCompaction,
     #[strum(message = "Show conversation history hints (boolean)")]
     ChatEnableHistoryHints,
+    #[strum(message = "Enable the todo list feature (boolean)")]
+    EnabledTodoList,
 }
 
 impl AsRef<str> for Setting {
@@ -109,6 +111,7 @@ impl AsRef<str> for Setting {
             Self::ChatDefaultAgent => "chat.defaultAgent",
             Self::ChatDisableAutoCompaction => "chat.disableAutoCompaction",
             Self::ChatEnableHistoryHints => "chat.enableHistoryHints",
+            Self::EnabledTodoList => "chat.enableTodoList",
         }
     }
 }
@@ -153,6 +156,7 @@ impl TryFrom<&str> for Setting {
             "chat.defaultAgent" => Ok(Self::ChatDefaultAgent),
             "chat.disableAutoCompaction" => Ok(Self::ChatDisableAutoCompaction),
             "chat.enableHistoryHints" => Ok(Self::ChatEnableHistoryHints),
+            "chat.enableTodoList" => Ok(Self::EnabledTodoList),
             _ => Err(DatabaseError::InvalidSetting(value.to_string())),
         }
     }