fix: add vite coverage and resolve various lints (#209)

Author: grant0417

.github/workflows/typescript.yml

@@ -36,6 +36,12 @@ jobs:
         run: pnpm install --frozen-lockfile
       - run: pnpm run build
       - run: pnpm run test:ci
+      - name: Upload coverage to Codecov
+        uses: codecov/codecov-action@v5
+        with:
+          token: ${{ secrets.CODECOV_TOKEN }}
+          files: coverage/lcov.info
+          fail_ci_if_error: true
 
   run-lint:
     name: Lint

package.json

@@ -4,14 +4,15 @@
   "author": "Fig Team",
   "license": "MIT OR Apache-2.0",
   "packageManager": "[email protected]",
+  "type": "module",
   "engines": {
     "node": "^22.0.0"
   },
   "scripts": {
     "build": "turbo build",
     "b": "turbo build",
     "test": "vitest",
-    "test:ci": "vitest run --run",
+    "test:ci": "vitest run --run --coverage",
     "test:ui": "vitest --ui",
     "coverage": "vitest run --coverage",
     "lint": "turbo lint --parallel",
@@ -26,14 +27,14 @@
     "precommit": "lint-staged --config .lintstagedrc.mjs"
   },
   "devDependencies": {
-    "@vitest/coverage-v8": "^2.1.6",
-    "@vitest/ui": "^2.1.6",
+    "@vitest/coverage-v8": "^2.1.8",
+    "@vitest/ui": "^2.1.8",
     "husky": "^9.1.7",
     "lint-staged": "^15.2.10",
     "micromatch": "^4.0.8",
-    "prettier": "^3.4.1",
+    "prettier": "^3.4.2",
     "tsx": "^4.19.2",
     "turbo": "^2.3.3",
-    "vitest": "^2.1.6"
+    "vitest": "^2.1.8"
   }
 }

packages/api-bindings/src/auth.ts

@@ -2,7 +2,6 @@ import {
   AuthBuilderIdStartDeviceAuthorizationResponse,
   AuthCancelPkceAuthorizationResponse,
   AuthStartPkceAuthorizationResponse,
-  // eslint-disable-next-line camelcase
   AuthStatusResponse_AuthKind,
   AuthBuilderIdPollCreateTokenResponse_PollStatus as PollStatus,
 } from "@amzn/fig-io-proto/fig";
@@ -21,11 +20,9 @@ export function status() {
   return sendAuthStatusRequest({}).then((res) => {
     let authKind: "BuilderId" | "IamIdentityCenter" | undefined;
     switch (res.authKind) {
-      // eslint-disable-next-line camelcase
       case AuthStatusResponse_AuthKind.BUILDER_ID:
         authKind = "BuilderId";
         break;
-      // eslint-disable-next-line camelcase
       case AuthStatusResponse_AuthKind.IAM_IDENTITY_CENTER:
         authKind = "IamIdentityCenter";
         break;
@@ -84,12 +81,10 @@ export async function builderIdPollCreateToken({
   interval,
 }: AuthBuilderIdStartDeviceAuthorizationResponse) {
   for (let i = 0; i < Math.ceil(expiresIn / interval); i += 1) {
-    // eslint-disable-next-line no-await-in-loop
     await new Promise((resolve) => {
       setTimeout(resolve, interval * 1000);
     });
 
-    // eslint-disable-next-line no-await-in-loop
     const pollStatus = await sendAuthBuilderIdPollCreateTokenRequest({
       authRequestId,
     });

packages/api-bindings/src/event.ts

@@ -16,7 +16,7 @@ export function subscribe<T>(
           if (name === eventName) {
             try {
               return handler(payload ? JSON.parse(payload) : null);
-            } catch (err) {
+            } catch (_err) {
               // ignore on json parse failure (invalid event).
             }
           }

packages/api-bindings/src/global.d.ts

@@ -1,4 +1,4 @@
-/* eslint-disable no-var, vars-on-top */
+/* eslint-disable no-var */
 
 declare global {
   var fig:

packages/api-bindings/src/history.ts

@@ -1,10 +1,8 @@
-// eslint-disable-next-line camelcase
 import { HistoryQueryRequest_Param } from "@amzn/fig-io-proto/fig";
 import { sendHistoryQueryRequest } from "./requests.js";
 
 export type Param = string | number | Uint8Array | null;
 
-// eslint-disable-next-line camelcase
 function mapParam(param: Param): HistoryQueryRequest_Param {
   if (param === null) {
     return {

packages/api-bindings/src/install.ts

@@ -2,10 +2,8 @@ import {
   InstallAction,
   InstallComponent,
   InstallResponse,
-  // eslint-disable-next-line camelcase
   InstallResponse_InstallationStatus,
   NotificationType,
-  // eslint-disable-next-line camelcase
   Result_Result,
 } from "@amzn/fig-io-proto/fig";
 
@@ -48,11 +46,9 @@ function componentToProto(component: Component) {
 function handleBasicResponse(response: InstallResponse) {
   switch (response.response?.$case) {
     case "result":
-      // eslint-disable-next-line camelcase
       if (response.response.result.result === Result_Result.OK) {
         return;
       }
-      // eslint-disable-next-line camelcase
       if (response.response.result.result === Result_Result.ERROR) {
         throw Error(response.response.result.error);
       } else {
@@ -88,14 +84,12 @@ export async function isInstalled(component: Component) {
     case "installationStatus":
       if (
         response.response.installationStatus ===
-        // eslint-disable-next-line camelcase
         InstallResponse_InstallationStatus.INSTALLED
       ) {
         return true;
       }
       if (
         response.response.installationStatus ===
-        // eslint-disable-next-line camelcase
         InstallResponse_InstallationStatus.NOT_INSTALLED
       ) {
         return false;

packages/api-bindings/src/notifications.ts

@@ -20,7 +20,6 @@ export interface Subscription {
 
 const handlers: Partial<Record<NotificationType, NotificationHandler[]>> = {};
 
-// eslint-disable-next-line no-underscore-dangle
 export function _unsubscribe(
   type: NotificationType,
   handler?: NotificationHandler,
@@ -30,7 +29,6 @@ export function _unsubscribe(
   }
 }
 
-// eslint-disable-next-line no-underscore-dangle
 export function _subscribe(
   request: NotificationRequest,
   handler: NotificationHandler,
@@ -105,7 +103,6 @@ const unsubscribeFromAll = () => {
   });
 };
 
-// eslint-disable-next-line @typescript-eslint/ban-ts-comment
 if (!window?.fig?.quiet) {
   console.log("[q] unsubscribing any existing notifications...");
 }

packages/api-bindings/src/requests.ts

@@ -2,8 +2,6 @@
  * Do not edit directly! Instead run 'npm run generate-requests' in typescript-api-bindings
  */
 
-/* eslint-disable max-len */
-
 import {
   AggregateSessionMetricActionRequest,
   AppendToFileRequest,

packages/api-bindings/src/utils.ts

@@ -1,4 +1,3 @@
-/* eslint-disable no-bitwise */
 export const b64EncodeUnicode = (str: string): string =>
   // first we use encodeURIComponent to get percent-encoded UTF-8,
   // then we convert the percent encodings into raw bytes which