fix(chat): Add dedicated handler for ! command execution

Fixed the issue with ! command not parsing correctly by:
- Creating a dedicated ExecuteCommand handler
- Adding the handler to the command system
- Updating Command::to_handler() to use the new handler
- Setting requires_confirmation to true for security

Also fixed a clippy warning in prompts/list.rs by using first() instead of get(0)

🤖 Assisted by [Amazon Q Developer](https://aws.amazon.com/q/developer)

Author: jsamuel1

crates/chat-cli/src/cli/chat/command.rs

@@ -18,6 +18,7 @@ use crate::cli::chat::commands::clear::CLEAR_HANDLER;
 use crate::cli::chat::commands::compact::COMPACT_HANDLER;
 use crate::cli::chat::commands::context::CONTEXT_HANDLER;
 use crate::cli::chat::commands::editor::EDITOR_HANDLER;
+use crate::cli::chat::commands::execute::EXECUTE_HANDLER;
 // Import static handlers
 use crate::cli::chat::commands::help::HELP_HANDLER;
 use crate::cli::chat::commands::issue::ISSUE_HANDLER;
@@ -1067,8 +1068,8 @@ impl Command {
             Command::Quit => &QUIT_HANDLER,
             Command::Clear => &CLEAR_HANDLER,
             Command::Context { subcommand } => subcommand.to_handler(),
-            Command::Profile { subcommand } => subcommand.to_handler(), /* Use the to_handler method on
-                                                                          * ProfileSubcommand */
+            Command::Profile { subcommand } => subcommand.to_handler(), // Use the to_handler method on
+            // ProfileSubcommand
             Command::Tools { subcommand } => match subcommand {
                 Some(sub) => sub.to_handler(), // Use the to_handler method on ToolsSubcommand
                 None => &crate::cli::chat::commands::tools::LIST_TOOLS_HANDLER, /* Default to list handler when no
@@ -1079,11 +1080,12 @@ impl Command {
             Command::Usage => &USAGE_HANDLER,
             Command::Issue { .. } => &ISSUE_HANDLER,
             // These commands are not handled through the command system
-            Command::Ask { .. } => &HELP_HANDLER,     // Fallback to help handler
-            Command::Execute { .. } => &HELP_HANDLER, // Fallback to help handler
+            Command::Ask { .. } => &HELP_HANDLER,        // Fallback to help handler
+            Command::Execute { .. } => &EXECUTE_HANDLER, // Use the dedicated execute handler
             Command::Prompts { subcommand } => match subcommand {
                 Some(sub) => sub.to_handler(),
-                None => &crate::cli::chat::commands::prompts::LIST_PROMPTS_HANDLER, // Default to list handler when no subcommand
+                None => &crate::cli::chat::commands::prompts::LIST_PROMPTS_HANDLER, /* Default to list handler when
+                                                                                     * no subcommand */
             },
         }
     }

crates/chat-cli/src/cli/chat/commands/execute.rs

@@ -0,0 +1,93 @@
+use std::future::Future;
+use std::pin::Pin;
+use std::process::Command as ProcessCommand;
+
+use crossterm::{
+    queue,
+    style,
+};
+
+use crate::cli::chat::command::Command;
+use crate::cli::chat::commands::context_adapter::CommandContextAdapter;
+use crate::cli::chat::commands::handler::CommandHandler;
+use crate::cli::chat::{
+    ChatError,
+    ChatState,
+    QueuedTool,
+};
+
+/// Static instance of the execute command handler
+pub static EXECUTE_HANDLER: ExecuteCommand = ExecuteCommand;
+
+/// Handler for the execute command
+pub struct ExecuteCommand;
+
+impl CommandHandler for ExecuteCommand {
+    fn name(&self) -> &'static str {
+        "execute"
+    }
+
+    fn description(&self) -> &'static str {
+        "Execute a shell command"
+    }
+
+    fn usage(&self) -> &'static str {
+        "!<command>"
+    }
+
+    fn help(&self) -> String {
+        "Execute a shell command directly from the chat interface.".to_string()
+    }
+
+    fn llm_description(&self) -> String {
+        r#"
+Execute a shell command directly from the chat interface.
+
+Usage:
+!<command>
+
+Examples:
+- "!ls -la" - List files in the current directory
+- "!echo Hello, world!" - Print a message
+- "!git status" - Check git status
+
+This command allows you to run any shell command without leaving the chat interface.
+"#
+        .to_string()
+    }
+
+    fn to_command(&self, args: Vec<&str>) -> Result<Command, ChatError> {
+        let command = args.join(" ");
+        Ok(Command::Execute { command })
+    }
+
+    fn execute_command<'a>(
+        &'a self,
+        command: &'a Command,
+        ctx: &'a mut CommandContextAdapter<'a>,
+        tool_uses: Option<Vec<QueuedTool>>,
+        pending_tool_index: Option<usize>,
+    ) -> Pin<Box<dyn Future<Output = Result<ChatState, ChatError>> + Send + 'a>> {
+        Box::pin(async move {
+            if let Command::Execute { command } = command {
+                queue!(ctx.output, style::Print('\n'))?;
+                ProcessCommand::new("bash").args(["-c", command]).status().ok();
+                queue!(ctx.output, style::Print('\n'))?;
+
+                Ok(ChatState::PromptUser {
+                    tool_uses,
+                    pending_tool_index,
+                    skip_printing_tools: false,
+                })
+            } else {
+                Err(ChatError::Custom(
+                    "ExecuteCommand can only execute Execute commands".into(),
+                ))
+            }
+        })
+    }
+
+    fn requires_confirmation(&self, _args: &[&str]) -> bool {
+        true // Execute commands require confirmation for security
+    }
+}

crates/chat-cli/src/cli/chat/commands/mod.rs

@@ -3,6 +3,7 @@ pub mod compact;
 pub mod context;
 pub mod context_adapter;
 pub mod editor;
+pub mod execute;
 pub mod handler;
 pub mod help;
 pub mod issue;

crates/chat-cli/src/cli/chat/commands/prompts/list.rs

@@ -44,8 +44,8 @@ impl CommandHandler for ListPromptsCommand {
     }
 
     fn to_command(&self, args: Vec<&str>) -> Result<Command, ChatError> {
-        let search_word = args.get(0).map(|s| (*s).to_string());
-        
+        let search_word = args.first().map(|s| (*s).to_string());
+
         Ok(Command::Prompts {
             subcommand: Some(PromptsSubcommand::List { search_word }),
         })
@@ -75,17 +75,19 @@ impl CommandHandler for ListPromptsCommand {
                 style::SetForegroundColor(Color::Yellow),
                 style::Print("No MCP servers with prompts are currently available.\n\n"),
                 style::ResetColor,
-                style::Print("To use prompts, you need to install and configure MCP servers that provide prompt templates.\n\n")
+                style::Print(
+                    "To use prompts, you need to install and configure MCP servers that provide prompt templates.\n\n"
+                )
             )?;
-            
+
             if let Some(word) = search_word {
                 queue!(
                     ctx.output,
                     style::Print(format!("Search term: \"{}\"\n", word)),
                     style::Print("No matching prompts found.\n\n")
                 )?;
             }
-            
+
             ctx.output.flush()?;
 
             Ok(ChatState::PromptUser {