merge main

Author: evanliu048

Cargo.lock

@@ -31,11 +31,33 @@ mod inner {
     }
 }
 
+impl Drop for InputSource {
+    fn drop(&mut self) {
+        self.save_history().unwrap();
+    }
+}
 impl InputSource {
     pub fn new(os: &Os, sender: PromptQuerySender, receiver: PromptQueryResponseReceiver) -> Result<Self> {
         Ok(Self(inner::Inner::Readline(rl(os, sender, receiver)?)))
     }
 
+    /// Save history to file
+    pub fn save_history(&mut self) -> Result<()> {
+        if let inner::Inner::Readline(rl) = &mut self.0 {
+            if let Some(helper) = rl.helper() {
+                let history_path = helper.get_history_path();
+
+                // Create directory if it doesn't exist
+                if let Some(parent) = history_path.parent() {
+                    std::fs::create_dir_all(parent)?;
+                }
+
+                rl.append_history(&history_path)?;
+            }
+        }
+        Ok(())
+    }
+
     #[cfg(unix)]
     pub fn put_skim_command_selector(
         &mut self,
@@ -78,12 +100,9 @@ impl InputSource {
                 let curr_line = rl.readline(prompt);
                 match curr_line {
                     Ok(line) => {
-                        let _ = rl.add_history_entry(line.as_str());
-
-                        if let Some(helper) = rl.helper_mut() {
-                            helper.update_hinter_history(&line);
+                        if Self::should_append_history(&line) {
+                            let _ = rl.add_history_entry(line.as_str());
                         }
-
                         Ok(Some(line))
                     },
                     Err(ReadlineError::Interrupted | ReadlineError::Eof) => Ok(None),
@@ -97,6 +116,18 @@ impl InputSource {
         }
     }
 
+    fn should_append_history(line: &str) -> bool {
+        let trimmed = line.trim().to_lowercase();
+        if trimmed.is_empty() {
+            return false;
+        }
+
+        if matches!(trimmed.as_str(), "y" | "n" | "t") {
+            return false;
+        }
+        true
+    }
+
     // We're keeping this method for potential future use
     #[allow(dead_code)]
     pub fn set_buffer(&mut self, content: &str) {