fix(agent): removes agent rename (#2434)

Author: dingfeli

crates/chat-cli/src/cli/agent/root_command_args.rs

@@ -32,15 +32,6 @@ pub enum AgentSubcommands {
     /// List the available agents. Note that local agents are only discovered if the command is
     /// invoked at a directory that contains them
     List,
-    /// Renames a given agent to a new name
-    Rename {
-        /// Original name of the agent
-        #[arg(long, short)]
-        agent: String,
-        /// New name the agent shall be changed to
-        #[arg(long, short)]
-        new_name: String,
-    },
     /// Create an agent config. If path is not provided, Q CLI shall create this config in the
     /// global agent directory
     Create {
@@ -140,11 +131,6 @@ impl AgentArgs {
                     path_with_file_name.display()
                 )?;
             },
-            Some(AgentSubcommands::Rename { agent, new_name }) => {
-                let mut agents = Agents::load(os, None, true, &mut stderr).await.0;
-                rename_agent(os, &mut agents, agent.clone(), new_name.clone()).await?;
-                writeln!(stderr, "\n✓ Renamed agent '{}' to '{}'\n", agent, new_name)?;
-            },
             Some(AgentSubcommands::Validate { path }) => {
                 let mut global_mcp_config = None::<McpServerConfig>;
                 let agent = Agent::load(os, path.as_str(), &mut global_mcp_config).await;
@@ -354,43 +340,6 @@ pub async fn create_agent(
     Ok(path_with_file_name)
 }
 
-pub async fn rename_agent(os: &mut Os, agents: &mut Agents, agent: String, new_name: String) -> Result<()> {
-    if agents.agents.iter().any(|(name, _)| name == &new_name) {
-        bail!("New name {new_name} already exists in the current scope. Aborting");
-    }
-
-    match agents.switch(agent.as_str()) {
-        Ok(target_agent) => {
-            if let Some(path) = target_agent.path.as_ref() {
-                let new_path = path
-                    .parent()
-                    .map(|p| p.join(format!("{new_name}.json")))
-                    .ok_or(eyre::eyre!("Failed to retrieve parent directory of target config"))?;
-                os.fs.rename(path, new_path).await?;
-
-                if let Some(default_agent) = os.database.settings.get_string(Setting::ChatDefaultAgent) {
-                    let global_agent_path = directories::chat_global_agent_path(os)?;
-                    if default_agent == agent
-                        && target_agent
-                            .path
-                            .as_ref()
-                            .is_some_and(|p| p.parent().is_some_and(|p| p == global_agent_path))
-                    {
-                        os.database.settings.set(Setting::ChatDefaultAgent, new_name).await?;
-                    }
-                }
-            } else {
-                bail!("Target agent has no path associated. Aborting");
-            }
-        },
-        Err(e) => {
-            bail!(e);
-        },
-    }
-
-    Ok(())
-}
-
 #[cfg(test)]
 mod tests {
     use super::*;
@@ -420,17 +369,4 @@ mod tests {
             })
         );
     }
-
-    #[test]
-    fn test_agent_subcommand_rename() {
-        assert_parse!(
-            ["agent", "rename", "--agent", "old_name", "--new-name", "new_name"],
-            RootSubcommand::Agent(AgentArgs {
-                cmd: Some(AgentSubcommands::Rename {
-                    agent: "old_name".to_string(),
-                    new_name: "new_name".to_string(),
-                })
-            })
-        );
-    }
 }

crates/chat-cli/src/cli/chat/cli/profile.rs

@@ -26,7 +26,6 @@ use crate::cli::agent::{
     Agent,
     Agents,
     create_agent,
-    rename_agent,
 };
 use crate::cli::chat::{
     ChatError,
@@ -71,16 +70,6 @@ pub enum AgentSubcommand {
     /// Switch to the specified agent
     #[command(hide = true)]
     Set { name: String },
-    /// Rename an agent. Should this be the current active agent, its changes will take effect upon
-    /// next launch
-    Rename {
-        /// Original name of the agent
-        #[arg(long, short)]
-        agent: String,
-        /// New name the agent shall be changed to
-        #[arg(long, short)]
-        new_name: String,
-    },
     /// Show agent config schema
     Schema,
     /// Define a default agent to use when q chat launches
@@ -188,29 +177,6 @@ impl AgentSubcommand {
                     style::SetForegroundColor(Color::Reset)
                 )?;
             },
-            Self::Rename { agent, new_name } => {
-                let mut agents = Agents::load(os, None, true, &mut session.stderr).await.0;
-                rename_agent(os, &mut agents, agent.clone(), new_name.clone())
-                    .await
-                    .map_err(|e| ChatError::Custom(Cow::Owned(e.to_string())))?;
-
-                execute!(
-                    session.stderr,
-                    style::SetForegroundColor(Color::Green),
-                    style::Print("Agent "),
-                    style::SetForegroundColor(Color::Cyan),
-                    style::Print(agent),
-                    style::SetForegroundColor(Color::Green),
-                    style::Print(" has been renamed to "),
-                    style::SetForegroundColor(Color::Cyan),
-                    style::Print(new_name),
-                    style::SetForegroundColor(Color::Reset),
-                    style::Print("\n"),
-                    style::SetForegroundColor(Color::Yellow),
-                    style::Print("Changes take effect on next launch"),
-                    style::SetForegroundColor(Color::Reset)
-                )?;
-            },
             Self::Set { .. } | Self::Delete { .. } => {
                 // As part of the agent implementation, we are disabling the ability to
                 // switch / create profile after a session has started.
@@ -271,7 +237,6 @@ impl AgentSubcommand {
             Self::Create { .. } => "create",
             Self::Delete { .. } => "delete",
             Self::Set { .. } => "set",
-            Self::Rename { .. } => "rename",
             Self::Schema => "schema",
             Self::SetDefault { .. } => "set_default",
         }