used from/into instead of a new function

Author: abhraina-aws

crates/chat-cli/src/auth/builder_id.rs

@@ -273,6 +273,16 @@ pub enum TokenType {
     IamIdentityCenter,
 }
 
+impl From<Option<&str>> for TokenType {
+    fn from(start_url: Option<&str>) -> Self {
+        match start_url {
+            Some(url) if url == START_URL => TokenType::BuilderId,
+            None => TokenType::BuilderId,
+            Some(_) => TokenType::IamIdentityCenter,
+        }
+    }
+}
+
 #[derive(Debug, Clone, serde::Serialize, serde::Deserialize)]
 pub struct BuilderIdToken {
     pub access_token: Secret,
@@ -494,7 +504,7 @@ impl BuilderIdToken {
     }
 
     pub fn token_type(&self) -> TokenType {
-        token_type_from_start_url(self.start_url.as_deref())
+        TokenType::from(self.start_url.as_deref())
     }
 
     /// Check if the token is for the internal amzn start URL (`https://amzn.awsapps.com/start`),
@@ -505,14 +515,6 @@ impl BuilderIdToken {
     }
 }
 
-pub fn token_type_from_start_url(start_url: Option<&str>) -> TokenType {
-    match start_url {
-        Some(url) if url == START_URL => TokenType::BuilderId,
-        None => TokenType::BuilderId,
-        Some(_) => TokenType::IamIdentityCenter,
-    }
-}
-
 pub enum PollCreateToken {
     Pending,
     Complete,
@@ -568,7 +570,7 @@ pub async fn poll_create_token(
             error!(?err, "Failed to poll for builder id token");
 
             // Send telemetry for device code failure
-            let auth_method = match token_type_from_start_url(start_url.as_deref()) {
+            let auth_method = match TokenType::from(start_url.as_deref()) {
                 TokenType::BuilderId => "BuilderId",
                 TokenType::IamIdentityCenter => "IdentityCenter",
             };

crates/chat-cli/src/cli/user.rs

@@ -145,7 +145,7 @@ impl LoginArgs {
                             tokio::select! {
                                 res = registration.finish(&client, Some(&mut os.database)) => {
                                     if let Err(err) = res {
-                                        let auth_method = match crate::auth::builder_id::token_type_from_start_url(start_url.as_deref()) {
+                                        let auth_method = match crate::auth::builder_id::TokenType::from(start_url.as_deref()) {
                                             crate::auth::builder_id::TokenType::BuilderId => "BuilderId",
                                             crate::auth::builder_id::TokenType::IamIdentityCenter => "IdentityCenter",
                                         };