modifies doc

Author: dingfeli

crates/chat-cli/src/cli/agent/mod.rs

@@ -254,37 +254,37 @@ impl Agent {
                 // currently we only have four native tools that offers tool settings
                 match allowed_tool.as_str() {
                     "fs_read" => {
-                        if let Some(overriden_settings) = FsRead::allowable_field_to_be_overriden(settings) {
+                        if let Some(overridden_settings) = FsRead::allowable_field_to_be_overridden(settings) {
                             queue_permission_override_warning(
                                 allowed_tool.as_str(),
-                                overriden_settings.as_str(),
+                                overridden_settings.as_str(),
                                 output,
                             )?;
                         }
                     },
                     "fs_write" => {
-                        if let Some(overriden_settings) = FsWrite::allowable_field_to_be_overriden(settings) {
+                        if let Some(overridden_settings) = FsWrite::allowable_field_to_be_overridden(settings) {
                             queue_permission_override_warning(
                                 allowed_tool.as_str(),
-                                overriden_settings.as_str(),
+                                overridden_settings.as_str(),
                                 output,
                             )?;
                         }
                     },
                     "use_aws" => {
-                        if let Some(overriden_settings) = UseAws::allowable_field_to_be_overriden(settings) {
+                        if let Some(overridden_settings) = UseAws::allowable_field_to_be_overridden(settings) {
                             queue_permission_override_warning(
                                 allowed_tool.as_str(),
-                                overriden_settings.as_str(),
+                                overridden_settings.as_str(),
                                 output,
                             )?;
                         }
                     },
                     name if name == execute_name => {
-                        if let Some(overriden_settings) = ExecuteCommand::allowable_field_to_be_overriden(settings) {
+                        if let Some(overridden_settings) = ExecuteCommand::allowable_field_to_be_overridden(settings) {
                             queue_permission_override_warning(
                                 allowed_tool.as_str(),
-                                overriden_settings.as_str(),
+                                overridden_settings.as_str(),
                                 output,
                             )?;
                         }

crates/chat-cli/src/cli/chat/mod.rs

@@ -1756,6 +1756,12 @@ impl ChatSession {
                             .clone()
                             .unwrap_or(tool_use.name.clone());
                         self.conversation.agents.trust_tools(vec![formatted_tool_name]);
+
+                        if let Some(agent) = self.conversation.agents.get_active() {
+                            agent
+                                .validate_tool_settings(&mut self.stderr)
+                                .map_err(|_e| ChatError::Custom("Failed to validate agent tool settings".into()))?;
+                        }
                     }
                     tool_use.accepted = true;
 

crates/chat-cli/src/cli/chat/tools/execute/mod.rs

@@ -176,7 +176,7 @@ impl ExecuteCommand {
         Ok(())
     }
 
-    pub fn allowable_field_to_be_overriden(settings: &serde_json::Value) -> Option<String> {
+    pub fn allowable_field_to_be_overridden(settings: &serde_json::Value) -> Option<String> {
         settings
             .get("allowedCommands")
             .map(|value| format!("allowedCommands: {}", value))

crates/chat-cli/src/cli/chat/tools/fs_read.rs

@@ -102,7 +102,7 @@ impl FsRead {
         }
     }
 
-    pub fn allowable_field_to_be_overriden(settings: &serde_json::Value) -> Option<String> {
+    pub fn allowable_field_to_be_overridden(settings: &serde_json::Value) -> Option<String> {
         settings
             .get("allowedPaths")
             .map(|value| format!("allowedPaths: {}", value))

crates/chat-cli/src/cli/chat/tools/fs_write.rs

@@ -415,7 +415,7 @@ impl FsWrite {
         }
     }
 
-    pub fn allowable_field_to_be_overriden(settings: &serde_json::Value) -> Option<String> {
+    pub fn allowable_field_to_be_overridden(settings: &serde_json::Value) -> Option<String> {
         settings
             .get("allowedPaths")
             .map(|value| format!("allowedPaths: {}", value))

crates/chat-cli/src/cli/chat/tools/use_aws.rs

@@ -175,7 +175,7 @@ impl UseAws {
         }
     }
 
-    pub fn allowable_field_to_be_overriden(settings: &serde_json::Value) -> Option<String> {
+    pub fn allowable_field_to_be_overridden(settings: &serde_json::Value) -> Option<String> {
         settings
             .get("allowedServices")
             .map(|value| format!("allowedServices: {}", value))

docs/agent-format.md

@@ -160,6 +160,7 @@ Unlike the `tools` field, the `allowedTools` field does not support the `"*"` wi
 ## ToolsSettings Field
 
 The `toolsSettings` field provides configuration for specific tools. Each tool can have its own unique configuration options.
+Note that specifications that configure allowable patterns will be overridden if the tool is also included in `allowedTools`.
 
 ```json
 {