Improve Linux doctor checks, gnome extension, ibus behavior, and other bugs (#11)

* Improve Linux doctor checks, gnome extension, ibus behavior, and other bugs

* Improve Linux doctor checks, gnome extension, ibus behavior, and other bugs

Author: brandonskiser

apps/dashboard/src/App.tsx

@@ -36,6 +36,7 @@ import { useState } from "react";
 import { usePlatformInfo } from "./hooks/store/usePlatformInfo";
 import { Platform } from "@amzn/fig-io-api-bindings";
 import { matchesPlatformRestrictions } from "./lib/platform";
+import { gnomeExtensionInstallCheck } from "./data/install";
 
 function App() {
   const store = useRef(createStore()).current;
@@ -239,10 +240,20 @@ const useNavData = () => {
 };
 
 function Layout() {
+  const platformInfo = usePlatformInfo();
   const [accessibilityCheck] = useAccessibilityCheck();
   const [dotfilesCheck] = useDotfilesCheck();
+  const [gnomeExtensionCheck] = useGnomeExtensionCheck();
   const navData = useNavData();
-  const error = accessibilityCheck === false || dotfilesCheck === false;
+  const error =
+    accessibilityCheck === false ||
+    dotfilesCheck === false ||
+    (platformInfo &&
+      matchesPlatformRestrictions(
+        platformInfo,
+        gnomeExtensionInstallCheck.platformRestrictions,
+      ) &&
+      gnomeExtensionCheck === false);
 
   // eslint-disable-next-line
   const [notifCount, _] = useLocalStateZodDefault(

apps/dashboard/src/components/installs/modal/index.tsx

@@ -60,6 +60,8 @@ export default function OnboardingModal() {
   function finish() {
     refreshAccessibility();
     refreshDotfiles();
+    refreshDesktopEntry();
+    refreshGnomeExtension();
     Internal.sendOnboardingRequest({
       action: Fig.OnboardingAction.FINISH_ONBOARDING,
     })

apps/dashboard/src/components/installs/modal/install.tsx

@@ -68,6 +68,7 @@ export default function InstallModal({
           return;
         }
         if (key === "desktopEntry") {
+          // The app should autostart by default, thus immediately install the autostart entry.
           Install.install("autostartEntry")
             .then(() => {
               setChecking(false);

apps/dashboard/src/components/installs/statusCheck.tsx

@@ -8,7 +8,7 @@ import {
 } from "../ui/collapsible";
 import { Check, ChevronDown, X } from "lucide-react";
 import { Button } from "../ui/button";
-import { useStatusCheck } from "@/hooks/store";
+import { useSetting, useStatusCheck } from "@/hooks/store";
 
 export default function StatusCheck({
   check,
@@ -18,10 +18,28 @@ export default function StatusCheck({
   const [expanded, setExpanded] = useState(false);
   const [status, refreshStatus] = useStatusCheck(check.installKey);
   const [err, setErr] = useState("");
+  const [launchOnStartup] = useSetting("app.launchOnStartup");
 
   function fixInstall() {
     Install.install(check.installKey)
-      .then(() => refreshStatus())
+      .then(() => {
+        // Default behavior for launchOnStartup should be true, hence check for undefined.
+        if (
+          check.installKey === "desktopEntry" &&
+          (launchOnStartup === undefined || launchOnStartup === true)
+        ) {
+          Install.install("autostartEntry")
+            .then(() => {
+              refreshStatus();
+            })
+            .catch((e) => {
+              console.error(e);
+              setErr(e.toString());
+            });
+        }
+
+        refreshStatus();
+      })
       .catch((e) => {
         console.error(e);
         setErr(e.toString());

apps/dashboard/src/data/install.ts

@@ -15,6 +15,23 @@ const getBackupsDir = (): string => {
   }
 };
 
+export const gnomeExtensionInstallCheck = {
+  id: "gnomeExtension",
+  installKey: "gnomeExtension",
+  platformRestrictions: {
+    os: Platform.Os.LINUX,
+    desktopEnvironment: Platform.DesktopEnvironment.GNOME,
+    displayServerProtocol: Platform.DisplayServerProtocol.WAYLAND,
+  },
+  title: "Install the GNOME Shell Extension",
+  description: [
+    `In order for ${PRODUCT_NAME} to function properly under Wayland, we need to install the ${PRODUCT_NAME} GNOME Shell Extension.`,
+    `New GNOME Shell extensions will require you to restart your current session by logging out.`,
+  ],
+  image: gnome_shell_extension,
+  action: "Install",
+};
+
 const installChecks: InstallCheckWithInstallKey[] = [
   {
     id: "dotfiles",

apps/dashboard/src/lib/store.ts

@@ -183,6 +183,14 @@ export const createStore = () => {
     store.setState({ inputMethodIsInstalled: isInstalled });
   });
 
+  Install.isInstalled("desktopEntry").then((isInstalled) => {
+    store.setState({ desktopEntryIsInstalled: isInstalled });
+  });
+
+  Install.isInstalled("gnomeExtension").then((isInstalled) => {
+    store.setState({ gnomeExtensionIsInstalled: isInstalled });
+  });
+
   Install.installStatus.subscribe("accessibility", (isInstalled) => {
     store.setState({ accessibilityIsInstalled: isInstalled });
     return { unsubscribe: false };

build-config/buildspec-linux-ubuntu.yml

@@ -8,7 +8,7 @@ phases:
     run-as: root
     commands:
       - apt-get update
-      - apt-get install -y -qq build-essential pkg-config jq dpkg curl wget zsh zstd cmake clang libssl-dev libgtk-3-dev libayatana-appindicator3-dev librsvg2-dev libdbus-1-dev libwebkit2gtk-4.1-dev libjavascriptcoregtk-4.1-dev valac libibus-1.0-dev libglib2.0-dev sqlite3 libxdo-dev protobuf-compiler libfuse2 dpkg-sig
+      - apt-get install -y -qq build-essential pkg-config jq dpkg curl wget zsh zstd cmake clang libssl-dev libgtk-3-dev libayatana-appindicator3-dev librsvg2-dev libdbus-1-dev libwebkit2gtk-4.0-37 libwebkit2gtk-4.1-dev libjavascriptcoregtk-4.1-dev valac libibus-1.0-dev libglib2.0-dev sqlite3 libxdo-dev protobuf-compiler libfuse2 dpkg-sig
   pre_build:
     commands:
       - export HOME=/home/codebuild-user

fig_desktop/src/install.rs

@@ -480,6 +480,12 @@ where
             info!("Extension {} not installed, installing now.", extension_uuid);
             shell_extensions.install_bundled_extension(bundled_path).await?;
         },
+        ExtensionInstallationStatus::Errored => {
+            error!(
+                "Extension {} is in an errored state. It must be manually uninstalled, and the current desktop session must be restarted.",
+                extension_uuid
+            );
+        },
         ExtensionInstallationStatus::RequiresReboot => {
             info!(
                 "Extension {} already installed but not loaded. User must reboot their machine.",

fig_desktop/src/local_ipc/commands.rs

@@ -271,3 +271,25 @@ pub fn dump_state(
         DumpStateResponse { json },
     ))))
 }
+
+pub async fn connect_to_ibus(proxy: EventLoopProxy, platform_state: &PlatformState) -> LocalResult {
+    cfg_if::cfg_if! {
+        if #[cfg(target_os = "linux")] {
+            use crate::platform::ibus::launch_ibus_connection;
+            match launch_ibus_connection(proxy, platform_state.inner()).await {
+                Ok(_) => Ok(LocalResponse::Success(None)),
+                Err(err) => {
+                    Err(LocalResponse::Error {
+                        code: None,
+                        message: Some(format!("Failed connecting to ibus: {:?}", err)),
+                    })
+                },
+            }
+        } else {
+            Err(LocalResponse::Error {
+                code: None,
+                message: Some("Connecting to IBus is only supported on Linux".to_owned()),
+            })
+        }
+    }
+}

fig_desktop/src/local_ipc/mod.rs

@@ -164,6 +164,7 @@ async fn handle_local_ipc<Ctx>(
                     },
                     Some(command) => {
                         use fig_proto::local::command::Command::{
+                            ConnectToIbus,
                             DebugMode,
                             Devtools,
                             Diagnostics,
@@ -202,6 +203,7 @@ async fn handle_local_ipc<Ctx>(
                                 &webview_notifications_state,
                                 &platform_state,
                             ),
+                            ConnectToIbus(_) => commands::connect_to_ibus(proxy.clone(), &platform_state).await,
                             Update(_) => fig_install::update(
                                 ctx.context_arc(),
                                 Some(Box::new(move |_| {