fixes permission for in memory default agent

Author: dingfeli

crates/chat-cli/src/cli/agent.rs

@@ -429,6 +429,12 @@ impl Agents {
 
         local_agents.append(&mut global_agents);
 
+        // If we are told which agent to set as active, we will fall back to a default whose
+        // lifetime matches that of the session
+        if agent_name.is_none() {
+            local_agents.push(Agent::default());
+        }
+
         let _ = output.flush();
 
         Self {
@@ -443,8 +449,10 @@ impl Agents {
 
     /// Returns a label to describe the permission status for a given tool.
     pub fn display_label(&self, tool_name: &str, origin: &ToolOrigin) -> String {
+        error!("## perm: name: display_label called");
         let tool_trusted = self.get_active().is_some_and(|a| {
             a.allowed_tools.iter().any(|name| {
+                error!("## perm: name: {name}, tool_name: {tool_name}");
                 // Here the tool names can take the following forms:
                 // - @{server_name}{delimiter}{tool_name}
                 // - native_tool_name

crates/chat-cli/src/cli/chat/cli/tools.rs

@@ -110,6 +110,7 @@ impl ToolsArgs {
                 })
                 .collect::<BTreeSet<_>>();
 
+            tracing::error!("## perm: command called");
             let to_display = sorted_tools.iter().fold(String::new(), |mut acc, tool_name| {
                 let width = longest - tool_name.len() + 4;
                 acc.push_str(
@@ -356,11 +357,22 @@ impl ToolsSubcommand {
                     {
                         active_agent.allowed_tools = orig_agent.allowed_tools;
                     }
+                } else if session
+                    .conversation
+                    .agents
+                    .get_active()
+                    .is_some_and(|a| a.name.as_str() == "default")
+                {
+                    // We only want to reset the tool permission and nothing else
+                    if let Some(active_agent) = session.conversation.agents.get_active_mut() {
+                        active_agent.allowed_tools = Default::default();
+                        active_agent.tools_settings = Default::default();
+                    }
                 }
                 queue!(
                     session.stderr,
                     style::SetForegroundColor(Color::Green),
-                    style::Print("\nReset all tools to the permission levels as defined in persona."),
+                    style::Print("\nReset all tools to the permission levels as defined in agent."),
                     style::SetForegroundColor(Color::Reset),
                 )?;
             },