docs update for tool settings globbing support

Author: dingfeli

crates/chat-cli/src/cli/chat/tools/custom_tool.rs

@@ -24,7 +24,6 @@ use crate::cli::agent::{
 };
 use crate::cli::chat::CONTINUATION_LINE;
 use crate::cli::chat::token_counter::TokenCounter;
-use crate::os::Os;
 use crate::mcp_client::{
     Client as McpClient,
     ClientConfig as McpClientConfig,
@@ -37,6 +36,7 @@ use crate::mcp_client::{
     StdioTransport,
     ToolCallResult,
 };
+use crate::os::Os;
 
 // TODO: support http transport type
 #[derive(Clone, Serialize, Deserialize, Debug, Eq, PartialEq, JsonSchema)]
@@ -321,7 +321,10 @@ mod tests {
         }
 
         // Test basic substitution
-        assert_eq!(substitute_env_vars("Value is ${env:TEST_VAR}", &os.env), "Value is test_value");
+        assert_eq!(
+            substitute_env_vars("Value is ${env:TEST_VAR}", &os.env),
+            "Value is test_value"
+        );
 
         // Test multiple substitutions
         assert_eq!(
@@ -330,7 +333,10 @@ mod tests {
         );
 
         // Test non-existent variable
-        assert_eq!(substitute_env_vars("${env:NON_EXISTENT_VAR}", &os.env), "${NON_EXISTENT_VAR}");
+        assert_eq!(
+            substitute_env_vars("${env:NON_EXISTENT_VAR}", &os.env),
+            "${NON_EXISTENT_VAR}"
+        );
 
         // Test mixed content
         assert_eq!(

crates/chat-cli/src/cli/chat/tools/fs_write.rs

@@ -407,7 +407,7 @@ impl FsWrite {
                                     return PermissionEvalResult::Deny({
                                         denied_match_set
                                             .iter()
-                                            .filter_map(|i| sanitized_deny_list.get(*i).map(|s| s.to_string()))
+                                            .filter_map(|i| sanitized_deny_list.get(*i).map(|s| (*s).clone()))
                                             .collect::<Vec<_>>()
                                     });
                                 }

docs/built-in-tools.md

@@ -21,6 +21,7 @@ Execute the specified bash command.
   "toolsSettings": {
     "execute_bash": {
       "allowedCommands": ["git status", "git fetch"],
+      "deniedCommands": ["git commit .*", "git push .*"],
       "allowReadOnly": true
     }
   }
@@ -31,7 +32,8 @@ Execute the specified bash command.
 
 | Option | Type | Default | Description                                                                              |
 |--------|------|---------|------------------------------------------------------------------------------------------|
-| `allowedCommands` | array of strings | `[]` | List of specific commands that are allowed without prompting. Supports regex formatting. Note that regex entered are anchored with \A and \z. |
+| `allowedCommands` | array of strings | `[]` | List of specific commands that are allowed without prompting. Supports regex formatting. Note that regex entered are anchored with \A and \z |
+| `deniedCommands` | array of strings | `[]` | List of specific commands that are denied. Supports regex formatting. Note that regex entered are anchored with \A and \z. Deny rules are evaluated before allow rules |
 | `allowReadOnly` | boolean | `true` | Whether to allow read-only commands without prompting                                    |
 
 ## Fs_read Tool
@@ -44,7 +46,8 @@ Tool for reading files, directories, and images.
 {
   "toolsSettings": {
     "fs_read": {
-      "allowedPaths": ["~/projects", "./src/**"]
+      "allowedPaths": ["~/projects", "./src/**"],
+      "deniedPaths": ["/some/denied/path/", "/another/denied/path/**/file.txt"]
     }
   }
 }
@@ -54,7 +57,8 @@ Tool for reading files, directories, and images.
 
 | Option | Type | Default | Description |
 |--------|------|---------|-------------|
-| `allowedPaths` | array of strings | `[]` | List of paths that can be read without prompting. Supports glob patterns. |
+| `allowedPaths` | array of strings | `[]` | List of paths that can be read without prompting. Supports glob patterns |
+| `deniedPaths` | array of strings | `[]` | List of paths that are denied. Supports glob patterns. Deny rules are evaluated before allow rules |
 
 ## Fs_write Tool
 
@@ -66,7 +70,8 @@ Tool for creating and editing files.
 {
   "toolsSettings": {
     "fs_write": {
-      "allowedPaths": ["~/projects/output.txt", "./src/**"]
+      "allowedPaths": ["~/projects/output.txt", "./src/**"],
+      "deniedPaths": ["/some/denied/path/", "/another/denied/path/**/file.txt"]
     }
   }
 }
@@ -76,7 +81,8 @@ Tool for creating and editing files.
 
 | Option | Type | Default | Description |
 |--------|------|---------|-------------|
-| `allowedPaths` | array of strings | `[]` | List of paths that can be written to without prompting. Supports glob patterns. |
+| `allowedPaths` | array of strings | `[]` | List of paths that can be written to without prompting. Supports glob patterns |
+| `deniedPaths` | array of strings | `[]` | List of paths that are denied. Supports glob patterns. Deny rules are evaluated before allow rules |
 
 ## Report_issue Tool
 
@@ -106,7 +112,8 @@ Make AWS CLI API calls with the specified service, operation, and parameters.
 {
   "toolsSettings": {
     "use_aws": {
-      "allowedServices": ["s3", "lambda", "ec2"]
+      "allowedServices": ["s3", "lambda", "ec2"],
+      "deniedServices": ["eks", "rds"]
     }
   }
 }
@@ -117,6 +124,7 @@ Make AWS CLI API calls with the specified service, operation, and parameters.
 | Option | Type | Default | Description |
 |--------|------|---------|-------------|
 | `allowedServices` | array of strings | `[]` | List of AWS services that can be accessed without prompting |
+| `deniedServices` | array of strings | `[]` | List of AWS services to deny. Deny rules are evaluated before allow rules |
 
 ## Using Tool Settings in Agent Configuration