fix(agent): in memory default not reading from legacy mcp json (#2356)

* fixes in memory default not reading from legacy mcp json

* fixes typo

Author: dingfeli

crates/chat-cli/src/cli/agent/mod.rs

@@ -549,7 +549,31 @@ impl Agents {
                 );
             }
 
-            local_agents.push(Agent::default());
+            local_agents.push({
+                let mut agent = Agent::default();
+                'load_legacy_mcp_json: {
+                    if global_mcp_config.is_none() {
+                        let Ok(global_mcp_path) = directories::chat_legacy_mcp_config(os) else {
+                            tracing::error!("Error obtaining legacy mcp json path. Skipping");
+                            break 'load_legacy_mcp_json;
+                        };
+                        let legacy_mcp_config = match McpServerConfig::load_from_file(os, global_mcp_path).await {
+                            Ok(config) => config,
+                            Err(e) => {
+                                tracing::error!("Error loading global mcp json path: {e}. Skipping");
+                                break 'load_legacy_mcp_json;
+                            },
+                        };
+                        global_mcp_config.replace(legacy_mcp_config);
+                    }
+                }
+
+                if let Some(config) = &global_mcp_config {
+                    agent.mcp_servers = config.clone();
+                }
+
+                agent
+            });
             "default".to_string()
         };
 

docs/the-agent-format.md

@@ -148,7 +148,7 @@ Resources are data and content that your agent has access to. As of today, only
 
 ### The `hooks` field
 
-The `hooks` field invokes functions at specific trigger points. The output of these functions is persisted into context according to the lifetime rules of the trigger. Hooks that run once, on `agentSpawn` for example, will be added to persistant context while shorter lived hooks like `userPromptSubmit` exist inside of the rolling context window.  
+The `hooks` field invokes functions at specific trigger points. The output of these functions is persisted into context according to the lifetime rules of the trigger. Hooks that run once, on `agentSpawn` for example, will be added to persistent context while shorter lived hooks like `userPromptSubmit` exist inside of the rolling context window.  
 
 ```json
 {