fix: make command/url conditionally required based on MCP server type #3352
+14
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use if-then schema to conditionally require fields based on transport type - stdio type requires 'command' field - http type requires 'url' field - Fixes aws#3346
mschrage
approved these changes
Nov 3, 2025
|
Will this PR be merged once the qv2 project is completed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3346. Improves the MCP server configuration schema to conditionally require fields based on the transport type.
Problem
The previous schema required the command field for all MCP servers. However, http type MCP servers need a url field instead of command. This caused
incorrect validation for HTTP-based MCP server configurations.
Changes
• Introduced JSON Schema if-then-else syntax in schemas/agent-v1.json
• When type: "http", the url field is required
• Otherwise (for stdio), the command field is required
Impact
• Only affects agent configuration schema validation logic
• No impact on existing valid configurations
• Invalid configurations will now be detected more accurately
Before
After
Tool used