Skip to content

Commit 0d81dc0

Browse files
imabhichowkessplas
andauthored
Apply suggestions from code review
Co-authored-by: Kess Plasmeier <[email protected]>
1 parent ba2f4cc commit 0d81dc0

File tree

1 file changed

+11
-2
lines changed

1 file changed

+11
-2
lines changed

src/main/java/software/amazon/encryption/s3/internal/ConvertSDKRequests.java

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
import java.time.Instant;
44
import java.util.Map;
55

6+
import org.apache.commons.logging.LogFactory;
67
import software.amazon.awssdk.services.s3.model.ChecksumType;
78
import software.amazon.awssdk.services.s3.model.CompleteMultipartUploadResponse;
89
import software.amazon.awssdk.services.s3.model.CreateMultipartUploadRequest;
@@ -198,8 +199,16 @@ public static PutObjectResponse convertResponse(CompleteMultipartUploadResponse
198199
// These fields exist only in CompleteMultipartUploadResponse, not in PutObjectResponse
199200
break;
200201
default:
201-
// We should silently drop unknown fields because,
202-
// once the object is stored we expect to return success response.
202+
// We should NOT throw an exception for unknown fields because
203+
// once the object is stored, we expect to return a successful response.
204+
// Emit a log at info level for awareness.
205+
LogFactory.getLog(ConvertSDKRequests.class).info(f.memberName() + " returned in CompleteMultipartUploadResponse for "
206+
+ response.key() + " is an unknown field." +
207+
"The S3 Encryption Client does not recognize this option and cannot set it on the CompleteMultipartUploadResponse." +
208+
"This may be a new S3 feature." +
209+
"Please report this to the Amazon S3 Encryption Client for Java: " +
210+
"https://github.com/aws/amazon-s3-encryption-client-java/issues."
211+
);
203212
break;
204213
}
205214
}

0 commit comments

Comments
 (0)