Skip to content

Commit 541132e

Browse files
author
Anirav Kareddy
committed
fixed issue where materials description wasn't being passed to Encryption Materials in putObject by first creating a helper method in the RawKeyring class that both AES + RSA keyrings will call in the override modifyMaterials method to return materials description instead of empty encryption materials
1 parent 3ee7571 commit 541132e

File tree

3 files changed

+17
-1
lines changed

3 files changed

+17
-1
lines changed

src/main/java/software/amazon/encryption/s3/materials/AesKeyring.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,11 @@ public boolean isLegacy() {
8888
return false;
8989
}
9090

91+
@Override
92+
public EncryptionMaterials modifyMaterials(EncryptionMaterials materials) {
93+
return modifyMaterialHelper(materials);
94+
}
95+
9196
@Override
9297
public String keyProviderInfo() {
9398
return KEY_PROVIDER_INFO;

src/main/java/software/amazon/encryption/s3/materials/RawKeyring.java

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,14 @@ public MaterialsDescription getMaterialsDescription() {
2020
public boolean getReEncryptInstructionFile() {
2121
return _reEncryptInstructionFile;
2222
}
23-
public EncryptionMaterials modifyMaterials(EncryptionMaterials materials) {
23+
public EncryptionMaterials modifyMaterialHelper(EncryptionMaterials materials) {
2424
warnIfEncryptionContextIsPresent(materials);
25+
if (_materialsDescription != null && !_materialsDescription.isEmpty()) {
26+
materials = materials.toBuilder()
27+
.materialsDescription(_materialsDescription)
28+
.build();
29+
return materials;
30+
}
2531

2632
return materials;
2733
}

src/main/java/software/amazon/encryption/s3/materials/RsaKeyring.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -93,6 +93,11 @@ public boolean isLegacy() {
9393
return false;
9494
}
9595

96+
@Override
97+
public EncryptionMaterials modifyMaterials(EncryptionMaterials materials) {
98+
return modifyMaterialHelper(materials);
99+
}
100+
96101
@Override
97102
public String keyProviderInfo() {
98103
return KEY_PROVIDER_INFO;

0 commit comments

Comments
 (0)